home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1065424051

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6345#issuecomment-1065424051 https://api.github.com/repos/pydata/xarray/issues/6345 1065424051 IC_kwDOAMm_X84_gRSz 62192187 2022-03-11T19:28:18Z 2022-03-11T19:31:18Z CONTRIBUTOR

So it looks like changing

https://github.com/pydata/xarray/blob/d293f50f9590251ce09543319d1f0dc760466f1b/xarray/backends/api.py#L1280-L1301

to

```python def _validate_datatypes_for_zarr_append(store, dataset): """DataArray.name and Dataset keys must be a string or None"""

def check_dtype(vname):
    store_dtype = store.get_variables()[vname].dtype
    dataset_dtype = dataset[vname].dtype
    if not store_dtype == dataset_dtype:
        raise ValueError(
            f"Mismatched dtypes for variable {vname} between Zarr store on disk "
            f"and dataset to append. Store has dtype {store_dtype} but dataset to "
            f"append has dtype {dataset_dtype}."
        )

for vname in dataset.data_vars:
    check_dtype(vname)

``` could work?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1164454058
Powered by Datasette · Queries took 2.105ms · About: xarray-datasette