home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1065381346

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6345#issuecomment-1065381346 https://api.github.com/repos/pydata/xarray/issues/6345 1065381346 IC_kwDOAMm_X84_gG3i 1217238 2022-03-11T18:38:42Z 2022-03-11T18:38:42Z MEMBER

The data type restriction here seems to date back to the original PR adding support for appending. I turned up this comment that seems to summarize the motivation for this check: https://github.com/pydata/xarray/pull/2706#issuecomment-502481584

I think the original issue was that appending a fixed-width string could be a problem if the fixed-width does not match the width of the existing string dtype stored in Zarr.

This obviously doesn't apply in this case, because you are adding an entirely new variable. So I guess the check could be removed in that case.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1164454058
Powered by Datasette · Queries took 0.669ms · About: xarray-datasette