issue_comments: 1050713711

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6059#issuecomment-1050713711 https://api.github.com/repos/pydata/xarray/issues/6059 1050713711 IC_kwDOAMm_X84-oJ5v 10194086 2022-02-25T10:07:01Z 2022-02-25T10:16:09Z MEMBER

Turns out align does not entirely do what I thought it does. For e.g. da1 * da2 there is an align call for the DataArray and then broadcasting happens on the level of the Variable - which we skip here. Therefore, I updated the PR (5c251e0) - to use xr.broadcast to ensure da and weights have the same shape.

Notes 1. The tests should fail because I updated the skipna logic and this was also "wrong" (inconsistent with the rest of xarray) in xr.Dataset.quantile - thus this needs #6303 first. 2. broadcast does an outer join which is kind of pointless here because it adds NaN values that are then removed again (#6304)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1076265104