home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1047244743

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5692#issuecomment-1047244743 https://api.github.com/repos/pydata/xarray/issues/5692 1047244743 IC_kwDOAMm_X84-a6_H 4160723 2022-02-21T21:35:26Z 2022-02-21T21:35:26Z MEMBER

Thanks for the review @Illviljan! I addressed most of your comments.

Regarding the use of Literal, join options and {"raise", "ignore"} option values are used in several places, directly or indirectly related to this PR. I would suggest to take care of this in a follow-up PR.

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  966983801
Powered by Datasette · Queries took 0.781ms · About: xarray-datasette