issue_comments: 1041835577

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5692#issuecomment-1041835577 https://api.github.com/repos/pydata/xarray/issues/5692 1041835577 IC_kwDOAMm_X84-GSY5 4160723 2022-02-16T16:16:30Z 2022-02-16T16:16:30Z MEMBER

let's try it:

arr.roll(x=5): index is not dropped, the result for sel(indexers) is different from before the roll (I guess that makes sense? pandas indexes behave the same way...) copy: raises NotImplementedError arr.stack(z=("x", "y")): index is dropped arr.isel(x=slice(5, 10), y=slice(10, 20)): index is dropped

For arr.roll, the index is dropped if roll_coords=True and CustomIndex.roll() is not implemented. Otherwise, the index is kept as-is since the coordinates are not affected.

For copy, we should probably use copy.copy() by default instead of raising an error.

I don't have ideas on how to test the other operations right now.

Yeah this is something that we can do progressively as we're experimenting with custom indexes. But this first try is already great.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   966983801