home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1039079452

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5692#issuecomment-1039079452 https://api.github.com/repos/pydata/xarray/issues/5692 1039079452 IC_kwDOAMm_X8497xgc 14808389 2022-02-14T13:20:18Z 2022-02-14T13:20:18Z MEMBER

thanks, @benbovy, those changes look good to me for now. After this is merged I'll have to update the tests anyways.

In the meantime, if you find any tests where the behavior changed so much that it is tricky to fix them I'd be fine with xfailing / skipping them for now.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  966983801
Powered by Datasette · Queries took 238.421ms · About: xarray-datasette