home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1038881658

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5692#issuecomment-1038881658 https://api.github.com/repos/pydata/xarray/issues/5692 1038881658 IC_kwDOAMm_X8497BN6 4160723 2022-02-14T09:56:36Z 2022-02-14T10:16:17Z MEMBER

@keewis FYI in the two last commits (11bf070 and 35a7464) I've made some changes to fix failing tests in test_units.py, which are related to the implicit creation of indexes and coordinates from a multi-index given in Dataset or DataArray constructors.

That may not be a proper fix. The problem is quite tricky though, since multi-indexes may be passed - directly or wrapped in DataArrays (as data or via their coordinates) - either to data_vars or coords (it may even be passed to both at the same time). It gets even more complicated now that multi-indexes in DataArrays have multiple coordinates. That's a lot of implicit behavior that IMHO we should depreciate as soon as possible in favor of a more explicit way to pass (multi-)indexes to the Dataset and DataArray constructors.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  966983801
Powered by Datasette · Queries took 0.537ms · About: xarray-datasette