issue_comments: 1006093410
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/5892#issuecomment-1006093410 | https://api.github.com/repos/pydata/xarray/issues/5892 | 1006093410 | IC_kwDOAMm_X84798Ri | 14371165 | 2022-01-05T21:31:19Z | 2022-01-05T21:31:19Z | MEMBER | I think it should stay required until typing has matured more, there's too much good stuff coming out each release not to make use of it immediately. I feel having to do these kinds of workarounds is not nice and sucks out any willpower of improving typing: https://github.com/pydata/xarray/blob/e056cacdca55cc9d9118c830ca622ea965ebcdef/xarray/core/utils.py#L309-L336 (This Try Except is not necessary anymore if it stays a required dependency) We also don't run mypy with minimum requirements so it's very likely we miss typing errors while going through these convoluted workaround paths. Here's a few more examples from eariler PRs: 5678 - The necessary workaround if it's not required:5871 - Just a simple if check if it's required: |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
1034329171 |