home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1005039003

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6136#issuecomment-1005039003 https://api.github.com/repos/pydata/xarray/issues/6136 1005039003 IC_kwDOAMm_X847562b 14808389 2022-01-04T17:49:22Z 2022-01-04T17:49:22Z MEMBER

this does indeed look like a typo (even though as @mathause says that value will not be checked because the absence of data is checked first) but in any case it is valid to pass a str: dims="t", dims=["t"] and dims=("t",) mean the same thing to the DataArray constructor for 1D data. Maybe we should just remove the parens to make this clear? I would have hoped that black takes care of something like that...

We also have the same issue in the docstring of DataArray.from_dict, which by the way would really benefit from converting the code block to a doctest-style example (it will fail right now).

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1093467156
Powered by Datasette · Queries took 2.064ms · About: xarray-datasette