issue_comments: 1004751649

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6124#issuecomment-1004751649 https://api.github.com/repos/pydata/xarray/issues/6124 1004751649 IC_kwDOAMm_X84740sh 14371165 2022-01-04T12:04:42Z 2022-01-04T12:04:42Z MEMBER

I do wonder at what point a mapping isn't a mapping anymore?

For example DataFrames aren't considered mappings: python isinstance(df, collections.abc.Mapping) Out[4]: False And if we are to follow pandas example maybe we should just remove the Mapping inheritance? https://github.com/pydata/xarray/blob/60754fdbc4ecd9eb3c0978e82635c6d43e8d485b/xarray/core/dataset.py#L584

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1090229430