{"database": "github", "table": "issue_comments", "is_view": false, "human_description_en": "where issue = 896002237 and user = 1217238 sorted by updated_at descending", "rows": [["https://github.com/pydata/xarray/pull/5352#issuecomment-848019023", "https://api.github.com/repos/pydata/xarray/issues/5352", 848019023, "MDEyOklzc3VlQ29tbWVudDg0ODAxOTAyMw==", 1217238, "2021-05-25T16:18:57Z", "2021-05-25T16:18:57Z", "MEMBER", "> in any case, I think any changes to the signature of `_repr_inline_` should be a separate PR\r\n\r\nI agree, let's discuss this in https://github.com/pydata/xarray/issues/5372", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 896002237], ["https://github.com/pydata/xarray/pull/5352#issuecomment-846454152", "https://api.github.com/repos/pydata/xarray/issues/5352", 846454152, "MDEyOklzc3VlQ29tbWVudDg0NjQ1NDE1Mg==", 1217238, "2021-05-22T19:36:07Z", "2021-05-22T19:36:07Z", "MEMBER", "It's more that `_repr_inline_` sounds very generic, neither really specific to xarray or even multi-dimensional arrays. So if I saw that without knowing the context of how it is used in xarray, it would surprise me that it's supposed to omit `shape` and `dtype`, which are otherwise essential parts of the repr.\r\n\r\nOther possibilities:\r\n- Give the protocol a namespace, like `_xarray_repr_inline_` to make it clearer that it's for Xarray's use.\r\n- Maybe add an `omit` argument, e.g., `obj._repr_inline_(max_width, skip=['dtype', 'shape'])`. Attributes in `skip` are already represented elsewhere and can be skipped if desired.", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 896002237], ["https://github.com/pydata/xarray/pull/5352#issuecomment-846075001", "https://api.github.com/repos/pydata/xarray/issues/5352", 846075001, "MDEyOklzc3VlQ29tbWVudDg0NjA3NTAwMQ==", 1217238, "2021-05-21T16:16:09Z", "2021-05-21T16:16:09Z", "MEMBER", "I wonder if `_repr_inline_` should include something explicit about excluded fields in the protocol, e.g., `obj._repr_inline_(shape=False, dtype=False)` and/or if the name should make it clearer that it's for array objects, e.g., `_ndarray_repr_inline_`?", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 896002237]], "truncated": false, "filtered_table_rows_count": 3, "expanded_columns": [], "expandable_columns": [[{"column": "issue", "other_table": "issues", "other_column": "id"}, "title"], [{"column": "user", "other_table": "users", "other_column": "id"}, "login"]], "columns": ["html_url", "issue_url", "id", "node_id", "user", "created_at", "updated_at", "author_association", "body", "reactions", "performed_via_github_app", "issue"], "primary_keys": ["id"], "units": {}, "query": {"sql": "select html_url, issue_url, id, node_id, user, created_at, updated_at, author_association, body, reactions, performed_via_github_app, issue from issue_comments where \"issue\" = :p0 and \"user\" = :p1 order by updated_at desc limit 101", "params": {"p0": "896002237", "p1": "1217238"}}, "facet_results": {"user": {"name": "user", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?issue=896002237&user=1217238", "results": [{"value": 1217238, "label": "shoyer", "count": 3, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?issue=896002237", "selected": true}], "truncated": false}, "issue": {"name": "issue", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?issue=896002237&user=1217238", "results": [{"value": 896002237, "label": "prefer the objects _repr_inline_ over xarray's custom reprs", "count": 3, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?user=1217238", "selected": true}], "truncated": false}}, "suggested_facets": [], "next": null, "next_url": null, "private": false, "allow_execute_sql": true, "query_ms": 6796.885187999578}