{"database": "github", "table": "issue_comments", "is_view": false, "human_description_en": "where issue = 833778859 and user = 5635139 sorted by updated_at descending", "rows": [["https://github.com/pydata/xarray/pull/5045#issuecomment-847906655", "https://api.github.com/repos/pydata/xarray/issues/5045", 847906655, "MDEyOklzc3VlQ29tbWVudDg0NzkwNjY1NQ==", 5635139, "2021-05-25T14:14:23Z", "2021-05-25T14:14:23Z", "MEMBER", "Docs would be great! Particularly if the current docs are out of date now. Thanks @matzegoebel ", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 833778859], ["https://github.com/pydata/xarray/pull/5045#issuecomment-847654999", "https://api.github.com/repos/pydata/xarray/issues/5045", 847654999, "MDEyOklzc3VlQ29tbWVudDg0NzY1NDk5OQ==", 5635139, "2021-05-25T08:13:08Z", "2021-05-25T08:13:08Z", "MEMBER", "Thanks a lot @matzegoebel !", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 833778859], ["https://github.com/pydata/xarray/pull/5045#issuecomment-840731561", "https://api.github.com/repos/pydata/xarray/issues/5045", 840731561, "MDEyOklzc3VlQ29tbWVudDg0MDczMTU2MQ==", 5635139, "2021-05-13T18:01:58Z", "2021-05-13T18:01:58Z", "MEMBER", "> I've fixed the location of the whats-new note. Is this ready to go in?\r\n\r\nYes. I have one typing question but we can merge regardless if needed", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 833778859], ["https://github.com/pydata/xarray/pull/5045#issuecomment-831718694", "https://api.github.com/repos/pydata/xarray/issues/5045", 831718694, "MDEyOklzc3VlQ29tbWVudDgzMTcxODY5NA==", 5635139, "2021-05-04T06:46:46Z", "2021-05-04T06:46:46Z", "MEMBER", "> ok, I deleted the copy stuff and included a few checks to catch possible errors before setting the values. Did I miss anything? How do we check for \"type errors that don't coerce\", as you mentioned?\r\n\r\nExcellent. Re the checks \u2014 I mostly meant that it was going to be very rare for something to get through \u2014\u00a0I don't think it's necessary to check for something like \"type errors that don't coerce\". ", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 833778859], ["https://github.com/pydata/xarray/pull/5045#issuecomment-830229757", "https://api.github.com/repos/pydata/xarray/issues/5045", 830229757, "MDEyOklzc3VlQ29tbWVudDgzMDIyOTc1Nw==", 5635139, "2021-04-30T16:57:53Z", "2021-04-30T16:58:09Z", "MEMBER", "Which errors would `__getitem__` miss? At least type errors that don't coerce; are there other cases?\r\n\r\nThe issue with a deep copy of the whole dataset is that it's very expensive. It's probably better to have that rather than nothing, but it could have confusing performance effects given that people are often going to be mutating values to reduce copies.\r\n\r\nThese aren't strongly held views though. Any thoughts from others? ", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 833778859], ["https://github.com/pydata/xarray/pull/5045#issuecomment-822467179", "https://api.github.com/repos/pydata/xarray/issues/5045", 822467179, "MDEyOklzc3VlQ29tbWVudDgyMjQ2NzE3OQ==", 5635139, "2021-04-19T13:29:07Z", "2021-04-19T13:29:07Z", "MEMBER", "Great, this is shaping up.\n\nI think we can find a way of failing early on bad indexes without attempting the whole operation on a copy.\n\nAt the very least, we could call `__getitem__` with the indexes and see whether that passes. There may be better ways yet.\n\nI also think that because the currently proposed code uses a shallow copy, it may be mutating the original when bad indexes are passed \u2014 it's worth adding a test to confirm.", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 833778859], ["https://github.com/pydata/xarray/pull/5045#issuecomment-822055901", "https://api.github.com/repos/pydata/xarray/issues/5045", 822055901, "MDEyOklzc3VlQ29tbWVudDgyMjA1NTkwMQ==", 5635139, "2021-04-18T20:29:18Z", "2021-04-18T20:29:18Z", "MEMBER", "@matzegoebel forgive the very long delay on the review. We're planning to find a better system to ensure these don't drop through.\r\n\r\nI would be up for adding this, for consistency. I don't think I've ever needed the functionality, but it also doesn't make the interface more complicated given it's mirroring `__getitem__`.\r\n\r\nWe probably need to think through whether there are any corner cases here; I can't think of any atm.\r\n\r\nAny other thoughts?", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 833778859]], "truncated": false, "filtered_table_rows_count": 7, "expanded_columns": [], "expandable_columns": [[{"column": "issue", "other_table": "issues", "other_column": "id"}, "title"], [{"column": "user", "other_table": "users", "other_column": "id"}, "login"]], "columns": ["html_url", "issue_url", "id", "node_id", "user", "created_at", "updated_at", "author_association", "body", "reactions", "performed_via_github_app", "issue"], "primary_keys": ["id"], "units": {}, "query": {"sql": "select html_url, issue_url, id, node_id, user, created_at, updated_at, author_association, body, reactions, performed_via_github_app, issue from issue_comments where \"issue\" = :p0 and \"user\" = :p1 order by updated_at desc limit 101", "params": {"p0": "833778859", "p1": "5635139"}}, "facet_results": {"author_association": {"name": "author_association", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?issue=833778859&user=5635139", "results": [{"value": "MEMBER", "label": "MEMBER", "count": 7, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?issue=833778859&user=5635139&author_association=MEMBER", "selected": false}], "truncated": false}, "user": {"name": "user", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?issue=833778859&user=5635139", "results": [{"value": 5635139, "label": "max-sixty", "count": 7, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?issue=833778859", "selected": true}], "truncated": false}, "issue": {"name": "issue", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?issue=833778859&user=5635139", "results": [{"value": 833778859, "label": "Allow assigning values to a subset of a dataset", "count": 7, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?user=5635139", "selected": true}], "truncated": false}}, "suggested_facets": [{"name": "created_at", "type": "date", "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?issue=833778859&user=5635139&_facet_date=created_at"}, {"name": "updated_at", "type": "date", "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?issue=833778859&user=5635139&_facet_date=updated_at"}], "next": null, "next_url": null, "private": false, "allow_execute_sql": true, "query_ms": 124.98667800537078}