{"database": "github", "table": "issue_comments", "is_view": false, "human_description_en": "where issue = 417281904 and user = 5635139 sorted by updated_at descending", "rows": [["https://github.com/pydata/xarray/pull/2800#issuecomment-469845973", "https://api.github.com/repos/pydata/xarray/issues/2800", 469845973, "MDEyOklzc3VlQ29tbWVudDQ2OTg0NTk3Mw==", 5635139, "2019-03-05T20:32:01Z", "2019-03-05T20:32:01Z", "MEMBER", "Thanks a lot @TimoRoth - this looks good!\r\n\r\nI think the failures are unrelated. I'll merge shortly unless anyone knows something I don't. \r\n\r\nOutput pasted below for reference:\r\n\r\n\r\n<details>\r\n\r\n```\r\nself = <xarray.tests.test_backends.TestValidateAttrs object at 0x000000B367D524E0>\r\n    def test_validating_attrs(self):\r\n        def new_dataset():\r\n            return Dataset({'data': ('y', np.arange(10.0))},\r\n                           {'y': np.arange(10)})\r\n    \r\n        def new_dataset_and_dataset_attrs():\r\n            ds = new_dataset()\r\n            return ds, ds.attrs\r\n    \r\n        def new_dataset_and_data_attrs():\r\n            ds = new_dataset()\r\n            return ds, ds.data.attrs\r\n    \r\n        def new_dataset_and_coord_attrs():\r\n            ds = new_dataset()\r\n            return ds, ds.coords['y'].attrs\r\n    \r\n        for new_dataset_and_attrs in [new_dataset_and_dataset_attrs,\r\n                                      new_dataset_and_data_attrs,\r\n                                      new_dataset_and_coord_attrs]:\r\n            ds, attrs = new_dataset_and_attrs()\r\n    \r\n            attrs[123] = 'test'\r\n            with raises_regex(TypeError, 'Invalid name for attr'):\r\n                ds.to_netcdf('test.nc')\r\n    \r\n            ds, attrs = new_dataset_and_attrs()\r\n            attrs[MiscObject()] = 'test'\r\n            with raises_regex(TypeError, 'Invalid name for attr'):\r\n                ds.to_netcdf('test.nc')\r\n    \r\n            ds, attrs = new_dataset_and_attrs()\r\n            attrs[''] = 'test'\r\n            with raises_regex(ValueError, 'Invalid name for attr'):\r\n                ds.to_netcdf('test.nc')\r\n    \r\n            # This one should work\r\n            ds, attrs = new_dataset_and_attrs()\r\n            attrs['test'] = 'test'\r\n            with create_tmp_file() as tmp_file:\r\n                ds.to_netcdf(tmp_file)\r\n    \r\n            ds, attrs = new_dataset_and_attrs()\r\n            attrs['test'] = {'a': 5}\r\n            with raises_regex(TypeError, 'Invalid value for attr'):\r\n                ds.to_netcdf('test.nc')\r\n    \r\n            ds, attrs = new_dataset_and_attrs()\r\n            attrs['test'] = MiscObject()\r\n            with raises_regex(TypeError, 'Invalid value for attr'):\r\n                ds.to_netcdf('test.nc')\r\n    \r\n            ds, attrs = new_dataset_and_attrs()\r\n            attrs['test'] = 5\r\n            with create_tmp_file() as tmp_file:\r\n                ds.to_netcdf(tmp_file)\r\n    \r\n            ds, attrs = new_dataset_and_attrs()\r\n            attrs['test'] = 3.14\r\n            with create_tmp_file() as tmp_file:\r\n                ds.to_netcdf(tmp_file)\r\n    \r\n            ds, attrs = new_dataset_and_attrs()\r\n            attrs['test'] = [1, 2, 3, 4]\r\n            with create_tmp_file() as tmp_file:\r\n                ds.to_netcdf(tmp_file)\r\n    \r\n            ds, attrs = new_dataset_and_attrs()\r\n            attrs['test'] = (1.9, 2.5)\r\n            with create_tmp_file() as tmp_file:\r\n                ds.to_netcdf(tmp_file)\r\n    \r\n            ds, attrs = new_dataset_and_attrs()\r\n            attrs['test'] = np.arange(5)\r\n            with create_tmp_file() as tmp_file:\r\n                ds.to_netcdf(tmp_file)\r\n    \r\n            ds, attrs = new_dataset_and_attrs()\r\n            attrs['test'] = np.arange(12).reshape(3, 4)\r\n            with create_tmp_file() as tmp_file:\r\n>               ds.to_netcdf(tmp_file)\r\nxarray\\tests\\test_backends.py:3450: \r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _\r\nxarray\\core\\dataset.py:1323: in to_netcdf\r\n    compute=compute)\r\nxarray\\backends\\api.py:767: in to_netcdf\r\n    unlimited_dims=unlimited_dims)\r\nxarray\\backends\\api.py:810: in dump_to_store\r\n    unlimited_dims=unlimited_dims)\r\nxarray\\backends\\common.py:262: in store\r\n    self.set_attributes(attributes)\r\nxarray\\backends\\common.py:278: in set_attributes\r\n    self.set_attribute(k, v)\r\nxarray\\backends\\netCDF4_.py:418: in set_attribute\r\n    _set_nc_attribute(self.ds, key, value)\r\nxarray\\backends\\netCDF4_.py:294: in _set_nc_attribute\r\n    obj.setncattr(key, value)\r\nnetCDF4\\_netCDF4.pyx:2781: in netCDF4._netCDF4.Dataset.setncattr\r\n    ???\r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _\r\n>   ???\r\nE   ValueError: multi-dimensional array attributes not supported\r\nnetCDF4\\_netCDF4.pyx:1514: ValueError\r\n```\r\n\r\n</details>", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 417281904]], "truncated": false, "filtered_table_rows_count": 1, "expanded_columns": [], "expandable_columns": [[{"column": "issue", "other_table": "issues", "other_column": "id"}, "title"], [{"column": "user", "other_table": "users", "other_column": "id"}, "login"]], "columns": ["html_url", "issue_url", "id", "node_id", "user", "created_at", "updated_at", "author_association", "body", "reactions", "performed_via_github_app", "issue"], "primary_keys": ["id"], "units": {}, "query": {"sql": "select html_url, issue_url, id, node_id, user, created_at, updated_at, author_association, body, reactions, performed_via_github_app, issue from issue_comments where \"issue\" = :p0 and \"user\" = :p1 order by updated_at desc limit 101", "params": {"p0": "417281904", "p1": "5635139"}}, "facet_results": {"author_association": {"name": "author_association", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?issue=417281904&user=5635139", "results": [{"value": "MEMBER", "label": "MEMBER", "count": 1, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?issue=417281904&user=5635139&author_association=MEMBER", "selected": false}], "truncated": false}, "user": {"name": "user", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?issue=417281904&user=5635139", "results": [{"value": 5635139, "label": "max-sixty", "count": 1, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?issue=417281904", "selected": true}], "truncated": false}, "issue": {"name": "issue", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?issue=417281904&user=5635139", "results": [{"value": 417281904, "label": "Don't use deprecated np.asscalar()", "count": 1, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?user=5635139", "selected": true}], "truncated": false}}, "suggested_facets": [{"name": "created_at", "type": "date", "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?issue=417281904&user=5635139&_facet_date=created_at"}], "next": null, "next_url": null, "private": false, "allow_execute_sql": true, "query_ms": 3226.5097639992746}