{"database": "github", "table": "issue_comments", "is_view": false, "human_description_en": "where author_association = \"MEMBER\", issue = 440233667 and user = 1217238 sorted by updated_at descending", "rows": [["https://github.com/pydata/xarray/issues/2940#issuecomment-506208573", "https://api.github.com/repos/pydata/xarray/issues/2940", 506208573, "MDEyOklzc3VlQ29tbWVudDUwNjIwODU3Mw==", 1217238, "2019-06-27T06:20:19Z", "2019-06-27T06:20:19Z", "MEMBER", "https://github.com/pydata/xarray/pull/3040 is my preferred fix for the rolling window issue. I plan to merge it sometime tomorrow unless I get any comments....", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 440233667], ["https://github.com/pydata/xarray/issues/2940#issuecomment-504058279", "https://api.github.com/repos/pydata/xarray/issues/2940", 504058279, "MDEyOklzc3VlQ29tbWVudDUwNDA1ODI3OQ==", 1217238, "2019-06-20T14:55:04Z", "2019-06-20T14:55:04Z", "MEMBER", "Looking into this in more detail, the fix looks somewhat non-trivial. For example, we definitely are not padding by enough inside `dask_rolling_wrapper` if `center=False`:\r\nhttps://github.com/pydata/xarray/blob/145f25f69078f245313bb8e07b7c6af7509d0de8/xarray/core/dask_array_ops.py#L29\r\n\r\nI'm not sure if this was ever tested properly, at least for dask arrays with multiple chunks. My guess is that this previously worked by consolidating dask arrays into a single chunk, which would simply fail for arrays that are larger than fit into memory.\r\n\r\nFor now, I think it would be safest to issue a new release that simply disables rolling() methods on dask arrays (by raising an error), and to save a full fix for later. I am concerned about letting the current behavior stick around, which silently calculates the wrong result.", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 440233667]], "truncated": false, "filtered_table_rows_count": 2, "expanded_columns": [], "expandable_columns": [[{"column": "issue", "other_table": "issues", "other_column": "id"}, "title"], [{"column": "user", "other_table": "users", "other_column": "id"}, "login"]], "columns": ["html_url", "issue_url", "id", "node_id", "user", "created_at", "updated_at", "author_association", "body", "reactions", "performed_via_github_app", "issue"], "primary_keys": ["id"], "units": {}, "query": {"sql": "select html_url, issue_url, id, node_id, user, created_at, updated_at, author_association, body, reactions, performed_via_github_app, issue from issue_comments where \"author_association\" = :p0 and \"issue\" = :p1 and \"user\" = :p2 order by updated_at desc limit 101", "params": {"p0": "MEMBER", "p1": "440233667", "p2": "1217238"}}, "facet_results": {"author_association": {"name": "author_association", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?author_association=MEMBER&issue=440233667&user=1217238", "results": [{"value": "MEMBER", "label": "MEMBER", "count": 2, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?issue=440233667&user=1217238", "selected": true}], "truncated": false}, "user": {"name": "user", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?author_association=MEMBER&issue=440233667&user=1217238", "results": [{"value": 1217238, "label": "shoyer", "count": 2, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?author_association=MEMBER&issue=440233667", "selected": true}], "truncated": false}, "issue": {"name": "issue", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?author_association=MEMBER&issue=440233667&user=1217238", "results": [{"value": 440233667, "label": "test_rolling_wrapped_dask is failing with dask-master", "count": 2, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?author_association=MEMBER&user=1217238", "selected": true}], "truncated": false}}, "suggested_facets": [{"name": "created_at", "type": "date", "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?author_association=MEMBER&issue=440233667&user=1217238&_facet_date=created_at"}, {"name": "updated_at", "type": "date", "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?author_association=MEMBER&issue=440233667&user=1217238&_facet_date=updated_at"}], "next": null, "next_url": null, "private": false, "allow_execute_sql": true, "query_ms": 210.27542099909624}