{"database": "github", "table": "issue_comments", "is_view": false, "human_description_en": "where author_association = \"MEMBER\", issue = 174404136 and user = 1217238 sorted by updated_at descending", "rows": [["https://github.com/pydata/xarray/pull/996#issuecomment-246560535", "https://api.github.com/repos/pydata/xarray/issues/996", 246560535, "MDEyOklzc3VlQ29tbWVudDI0NjU2MDUzNQ==", 1217238, "2016-09-13T03:07:11Z", "2016-09-13T03:07:11Z", "MEMBER", "I think this is nearly ready. We just need to decide on the final keyword name (e.g., `notnull_equals` or `no_conflicts`) and add mention of this in the documentation / what's new.\n\nI'm not sure we really need this new method for Dataset/DataArray (for the current implementation, adding it on Variable would be enough). Given that the user can catch `MergeError`, it seems straightforward enough just call `merge` to see if merging is safe.\n", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 174404136], ["https://github.com/pydata/xarray/pull/996#issuecomment-244518325", "https://api.github.com/repos/pydata/xarray/issues/996", 244518325, "MDEyOklzc3VlQ29tbWVudDI0NDUxODMyNQ==", 1217238, "2016-09-03T01:17:27Z", "2016-09-03T01:17:27Z", "MEMBER", "One of the commits in this PR is not yours. Take a look here -- you want to rebase instead of merge (yes git is confusing):\nhttp://stackoverflow.com/questions/5968964/avoid-unwanted-merge-commits-and-other-commits-when-doing-pull-request-on-github\n\nI think you can still safely rebase now.\n", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 174404136], ["https://github.com/pydata/xarray/pull/996#issuecomment-243966597", "https://api.github.com/repos/pydata/xarray/issues/996", 243966597, "MDEyOklzc3VlQ29tbWVudDI0Mzk2NjU5Nw==", 1217238, "2016-09-01T03:31:51Z", "2016-09-01T03:31:51Z", "MEMBER", "`compat='no_conflicts'` is possibly a better keyword argument.\n", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 174404136], ["https://github.com/pydata/xarray/pull/996#issuecomment-243963087", "https://api.github.com/repos/pydata/xarray/issues/996", 243963087, "MDEyOklzc3VlQ29tbWVudDI0Mzk2MzA4Nw==", 1217238, "2016-09-01T03:02:23Z", "2016-09-01T03:02:23Z", "MEMBER", "> Current version is conservative in that it still requires aligned Datasets with all the same variables.\n\n:+1: it's much less obvious to treat missing variables as \"missing data.\"\n\n> Due to the float nature of NaN, type is sometimes not preserved, e.g. merging two int arrays yields a float array, even when the final array has no NaN values itself.\n\nYes, this is consistent with the xarray/pandas type system. (Which is not ideal, but that's another bigger issue.)\n", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 174404136], ["https://github.com/pydata/xarray/pull/996#issuecomment-243962394", "https://api.github.com/repos/pydata/xarray/issues/996", 243962394, "MDEyOklzc3VlQ29tbWVudDI0Mzk2MjM5NA==", 1217238, "2016-09-01T02:57:21Z", "2016-09-01T02:57:21Z", "MEMBER", "This is quite clever! I'm impressed this was so easy using `fillna`.\n\nOne potential concern here is that performance is not going to be so great if you attempt to combine a bunch of variables with lazy data loaded with dask, because each comparison will trigger a separate computation. To that end, it would be nice to do the safety check in a single dask operation.\n\nTo be fair, this is already an issue if you're trying to merge lots of datasets together. But I expect this will become more of an issue when there are _useful_ ways to merge a bunch of datasets, which is what this PR enables.\n", "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 174404136]], "truncated": false, "filtered_table_rows_count": 5, "expanded_columns": [], "expandable_columns": [[{"column": "issue", "other_table": "issues", "other_column": "id"}, "title"], [{"column": "user", "other_table": "users", "other_column": "id"}, "login"]], "columns": ["html_url", "issue_url", "id", "node_id", "user", "created_at", "updated_at", "author_association", "body", "reactions", "performed_via_github_app", "issue"], "primary_keys": ["id"], "units": {}, "query": {"sql": "select html_url, issue_url, id, node_id, user, created_at, updated_at, author_association, body, reactions, performed_via_github_app, issue from issue_comments where \"author_association\" = :p0 and \"issue\" = :p1 and \"user\" = :p2 order by updated_at desc limit 101", "params": {"p0": "MEMBER", "p1": "174404136", "p2": "1217238"}}, "facet_results": {"author_association": {"name": "author_association", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?author_association=MEMBER&issue=174404136&user=1217238", "results": [{"value": "MEMBER", "label": "MEMBER", "count": 5, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?issue=174404136&user=1217238", "selected": true}], "truncated": false}, "user": {"name": "user", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?author_association=MEMBER&issue=174404136&user=1217238", "results": [{"value": 1217238, "label": "shoyer", "count": 5, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?author_association=MEMBER&issue=174404136", "selected": true}], "truncated": false}, "issue": {"name": "issue", "type": "column", "hideable": false, "toggle_url": "/github/issue_comments.json?author_association=MEMBER&issue=174404136&user=1217238", "results": [{"value": 174404136, "label": "add 'no_conflicts' as compat option for merging non-conflicting data", "count": 5, "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?author_association=MEMBER&user=1217238", "selected": true}], "truncated": false}}, "suggested_facets": [{"name": "created_at", "type": "date", "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?author_association=MEMBER&issue=174404136&user=1217238&_facet_date=created_at"}, {"name": "updated_at", "type": "date", "toggle_url": "http://xarray-datasette.fly.dev/github/issue_comments.json?author_association=MEMBER&issue=174404136&user=1217238&_facet_date=updated_at"}], "next": null, "next_url": null, "private": false, "allow_execute_sql": true, "query_ms": 197.83237099909456}