html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1517#issuecomment-324692881,https://api.github.com/repos/pydata/xarray/issues/1517,324692881,MDEyOklzc3VlQ29tbWVudDMyNDY5Mjg4MQ==,5356122,2017-08-24T16:50:45Z,2017-08-24T16:50:45Z,MEMBER,"Wow, this is great stuff!
What's `rs.randn()`?
When this makes it into the public facing API it would be nice to include some guidance on how the chunking scheme affects the run time. Imagine a plot with run time plotted as a function of chunk size or number of chunks. Of course it also depends on the data size and the number of cores available.
To say it in a different way, `array1.chunk({'place': 10})` is a performance tuning parameter, semantically no different than `array1`.
More ambitiously I could imagine an API such as `array1.chunk('place')` or `array1.chunk('auto')` meaning to figure out a reasonable chunking scheme only once `.compute()` is called so that all the compute steps are known. Maybe this is more specific to dask than xarray. I believe it would also be difficult.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,252358450
https://github.com/pydata/xarray/pull/1330#issuecomment-302728009,https://api.github.com/repos/pydata/xarray/issues/1330,302728009,MDEyOklzc3VlQ29tbWVudDMwMjcyODAwOQ==,5356122,2017-05-19T15:05:39Z,2017-05-19T15:05:39Z,MEMBER,This has been sitting for a little while... @shoyer please don't let my comment keep you from merging- it was more to note that this introduces custom error types.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,217287113
https://github.com/pydata/xarray/pull/1330#issuecomment-290578639,https://api.github.com/repos/pydata/xarray/issues/1330,290578639,MDEyOklzc3VlQ29tbWVudDI5MDU3ODYzOQ==,5356122,2017-03-31T00:01:10Z,2017-03-31T00:01:10Z,MEMBER,"I'm thinking about some of the ones in `alignment.py` which are currently `ValueError`, for example: https://github.com/pydata/xarray/blob/master/xarray/core/alignment.py#L303","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,217287113
https://github.com/pydata/xarray/pull/1330#issuecomment-290572513,https://api.github.com/repos/pydata/xarray/issues/1330,290572513,MDEyOklzc3VlQ29tbWVudDI5MDU3MjUxMw==,5356122,2017-03-30T23:20:59Z,2017-03-30T23:20:59Z,MEMBER,"> Does it seem useful to you?
Yes, it's a nice sanity check.
> Does the name join='exact' make sense?
Yes.
> Any thoughts on this feature?
Is it worth introducing custom exception types into xarray? Seems like `ValueError` would be fine here. Then users can write this without having to know we use our own special exceptions:
```
try:
xarray.merge([ds1, ds2], join='exact')
except ValueError:
...
```
Otherwise you'll probably want to change some others to `AlignmentError` for consistency.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,217287113
https://github.com/pydata/xarray/issues/1262#issuecomment-279861287,https://api.github.com/repos/pydata/xarray/issues/1262,279861287,MDEyOklzc3VlQ29tbWVudDI3OTg2MTI4Nw==,5356122,2017-02-14T22:47:28Z,2017-02-14T22:47:28Z,MEMBER,"Other datatypes would be extremely useful. But I think it would be better to start as a separate project and build some confidence in a system first.
@MaximilianR I was just typing nearly the same thing... :+1:
> we might consider lightly wrapping NumPy arrays in a new object that also includes extra dtype information
Pandas seems to be moving away from this approach now.
Any other existing alternatives? [datashape](http://datashape.pydata.org/index.html)?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,207021356
https://github.com/pydata/xarray/pull/1191#issuecomment-269819094,https://api.github.com/repos/pydata/xarray/issues/1191,269819094,MDEyOklzc3VlQ29tbWVudDI2OTgxOTA5NA==,5356122,2016-12-30T20:36:44Z,2016-12-30T20:37:02Z,MEMBER,"> It is consistent with mpl, as long as neither vmin or vmax are set.
The reason for having consistency with MPL is that users can take essentially the same code and produce the same plots with or without xarray. And it's less work on this end.
We're departing from that here to get something that perhaps is more natural for the user. But I think it's ok since the plots generally won't look all that different. If users want more control they can just set all the `levels` explicitly.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,198030158
https://github.com/pydata/xarray/issues/1188#issuecomment-269556854,https://api.github.com/repos/pydata/xarray/issues/1188,269556854,MDEyOklzc3VlQ29tbWVudDI2OTU1Njg1NA==,5356122,2016-12-28T23:16:33Z,2016-12-28T23:16:33Z,MEMBER,I haven't used these arguments in the constructors. But I don't find them distracting either.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,197920258
https://github.com/pydata/xarray/issues/979#issuecomment-264510264,https://api.github.com/repos/pydata/xarray/issues/979,264510264,MDEyOklzc3VlQ29tbWVudDI2NDUxMDI2NA==,5356122,2016-12-02T17:23:46Z,2016-12-02T17:23:46Z,MEMBER,"As an end user, it would be really nice to not have to worry about chunks at all. I'd like to write the same code in xarray using Numpy and have it do the right thing in dask transparently.
It seems like dask is moving in this direction (see Automatic blocksize for read_csv dask/dask#1147).
Agree with @shoyer that these features belong in dask.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,172291585
https://github.com/pydata/xarray/pull/818#issuecomment-220863225,https://api.github.com/repos/pydata/xarray/issues/818,220863225,MDEyOklzc3VlQ29tbWVudDIyMDg2MzIyNQ==,5356122,2016-05-22T23:28:01Z,2016-05-22T23:28:01Z,MEMBER,"Ah, now I see what you were going for. More going on here than I realized. That's a nice plot :)
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,146182176
https://github.com/pydata/xarray/pull/818#issuecomment-220844145,https://api.github.com/repos/pydata/xarray/issues/818,220844145,MDEyOklzc3VlQ29tbWVudDIyMDg0NDE0NQ==,5356122,2016-05-22T17:16:14Z,2016-05-22T18:31:58Z,MEMBER,"The problem is with the shape of these coordinates.
```
>>> ds = xr.tutorial.load_dataset('RASM_example_data')
>>> ds['xc'].shape
(205, 275)
```
EDIT: just to be clear, it doesn't make sense to pass in 2d arrays for both x and y coordinates for a 2d plotting function.
Run this: `ds.Tair[0].plot.pcolormesh(x='x', y='y')` to produce:
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,146182176
https://github.com/pydata/xarray/pull/818#issuecomment-220844279,https://api.github.com/repos/pydata/xarray/issues/818,220844279,MDEyOklzc3VlQ29tbWVudDIyMDg0NDI3OQ==,5356122,2016-05-22T17:18:48Z,2016-05-22T17:18:48Z,MEMBER,"The right thing for `xarray` to do is probably to throw an error when any 2d plot method is called with 2 coordinates that actually have higher dimensions.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,146182176
https://github.com/pydata/xarray/issues/792#issuecomment-195536929,https://api.github.com/repos/pydata/xarray/issues/792,195536929,MDEyOklzc3VlQ29tbWVudDE5NTUzNjkyOQ==,5356122,2016-03-11T20:28:26Z,2016-03-11T20:28:26Z,MEMBER,"Thanks for keeping me in the loop- hopefully next month I can participate. New baby and Phd quals => no time now
1 appears to be the simpler option off the top of my head.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,140264913
https://github.com/pydata/xarray/issues/781#issuecomment-191577576,https://api.github.com/repos/pydata/xarray/issues/781,191577576,MDEyOklzc3VlQ29tbWVudDE5MTU3NzU3Ng==,5356122,2016-03-03T04:31:19Z,2016-03-03T04:31:19Z,MEMBER,"@jhamman Seems like that would work. Might write a test to make sure the edges don't get dropped. I'd say let `cartopy` do as much as possible! `cartopy` integration was a lower priority when I was working on this, but only because we wanted to get the base stuff working first. More seamless integration or documentation for how to use with cartopy would be a good thing.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,138045063
https://github.com/pydata/xarray/issues/704#issuecomment-168861275,https://api.github.com/repos/pydata/xarray/issues/704,168861275,MDEyOklzc3VlQ29tbWVudDE2ODg2MTI3NQ==,5356122,2016-01-05T01:11:54Z,2016-01-05T01:11:54Z,MEMBER,"Wow, going for it! Great. Given the other common imports are
```
import numpy as np
import pandas as pd
import matplotlib.pyplot as plt
```
My vote goes for
```
import xarray as xr
```
Just curious, is `xarray` already decided on? You could call it `namedarray` or `labelarray`...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,124867009
https://github.com/pydata/xarray/issues/657#issuecomment-157757864,https://api.github.com/repos/pydata/xarray/issues/657,157757864,MDEyOklzc3VlQ29tbWVudDE1Nzc1Nzg2NA==,5356122,2015-11-18T15:56:10Z,2015-11-18T15:56:10Z,MEMBER,"This is surprising! But good to know.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,117002929
https://github.com/pydata/xarray/issues/647#issuecomment-156179070,https://api.github.com/repos/pydata/xarray/issues/647,156179070,MDEyOklzc3VlQ29tbWVudDE1NjE3OTA3MA==,5356122,2015-11-12T17:39:54Z,2015-11-12T17:39:54Z,MEMBER,"Yes, thanks.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,115556712
https://github.com/pydata/xarray/issues/647#issuecomment-155520635,https://api.github.com/repos/pydata/xarray/issues/647,155520635,MDEyOklzc3VlQ29tbWVudDE1NTUyMDYzNQ==,5356122,2015-11-10T18:17:58Z,2015-11-10T18:17:58Z,MEMBER,"But the docs on master are good? @shoyer or did you mean something about old vs new behavior?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,115556712
https://github.com/pydata/xarray/issues/647#issuecomment-154839554,https://api.github.com/repos/pydata/xarray/issues/647,154839554,MDEyOklzc3VlQ29tbWVudDE1NDgzOTU1NA==,5356122,2015-11-08T16:30:22Z,2015-11-08T16:30:22Z,MEMBER,"Some changes have been made to the plot functions. This one works for me:
```
atlantic.plot(ax=ax, transform=ccrs.PlateCarree())
```
The latest version of the docs has a better plot that actually uses real data: http://xray.readthedocs.org/en/latest/plotting.html#maps
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,115556712
https://github.com/pydata/xarray/issues/647#issuecomment-154624273,https://api.github.com/repos/pydata/xarray/issues/647,154624273,MDEyOklzc3VlQ29tbWVudDE1NDYyNDI3Mw==,5356122,2015-11-07T05:23:26Z,2015-11-07T05:23:26Z,MEMBER,"@fmaussion Can you post the contents of `test_xray.py`? I tried running a Cartopy script with
> last conda install (xray 0.6.1, linux, python 3.4, mpl 1.4.3)
and everything looks good locally.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,115556712
https://github.com/pydata/xarray/pull/608#issuecomment-146892645,https://api.github.com/repos/pydata/xarray/issues/608,146892645,MDEyOklzc3VlQ29tbWVudDE0Njg5MjY0NQ==,5356122,2015-10-09T14:46:14Z,2015-10-09T14:46:14Z,MEMBER,"thanks @jhamman for making it work!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,109665577
https://github.com/pydata/xarray/pull/608#issuecomment-146666438,https://api.github.com/repos/pydata/xarray/issues/608,146666438,MDEyOklzc3VlQ29tbWVudDE0NjY2NjQzOA==,5356122,2015-10-08T19:43:37Z,2015-10-08T19:43:37Z,MEMBER,"I think it's fine to have `yincrease=True` and `xincrease=True` everywhere as the defaults. This is how most people expect graphs to look. This is a place where internal consistency within xray probably beats conforming to the matplotlib defaults.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,109665577
https://github.com/pydata/xarray/issues/611#issuecomment-146557272,https://api.github.com/repos/pydata/xarray/issues/611,146557272,MDEyOklzc3VlQ29tbWVudDE0NjU1NzI3Mg==,5356122,2015-10-08T14:09:35Z,2015-10-08T14:09:35Z,MEMBER,"If the dimensions are A, B, C, and the call is `da.plot.pcolormesh(col='B')` then it seemed a little ambiguous to assign `x='A', y='C'`. So another option would be to raise an exception here.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,110102454
https://github.com/pydata/xarray/pull/608#issuecomment-146554007,https://api.github.com/repos/pydata/xarray/issues/608,146554007,MDEyOklzc3VlQ29tbWVudDE0NjU1NDAwNw==,5356122,2015-10-08T13:59:07Z,2015-10-08T13:59:07Z,MEMBER,"Simplification of the logic is a good thing, so I'm fine with this.
We should call out the performance difference in the docs, maybe both in the main 2d plot section and the faceting section.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,109665577
https://github.com/pydata/xarray/pull/608#issuecomment-146392455,https://api.github.com/repos/pydata/xarray/issues/608,146392455,MDEyOklzc3VlQ29tbWVudDE0NjM5MjQ1NQ==,5356122,2015-10-08T01:58:13Z,2015-10-08T01:58:13Z,MEMBER,"With a 1000 x 1000 grid I'm seeing 10 ms for `imshow` compared to 200 ms for `pcolormesh`. And much longer to render.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,109665577
https://github.com/pydata/xarray/pull/608#issuecomment-146392233,https://api.github.com/repos/pydata/xarray/issues/608,146392233,MDEyOklzc3VlQ29tbWVudDE0NjM5MjIzMw==,5356122,2015-10-08T01:56:35Z,2015-10-08T01:56:35Z,MEMBER,"`pcolormesh` is more general, and works fine.
The problem, however, is time! How long does it take to plot and render with the two?
`imshow` can be orders of magnitude faster to plot and render.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,109665577
https://github.com/pydata/xarray/issues/605#issuecomment-145187110,https://api.github.com/repos/pydata/xarray/issues/605,145187110,MDEyOklzc3VlQ29tbWVudDE0NTE4NzExMA==,5356122,2015-10-03T00:20:56Z,2015-10-03T00:20:56Z,MEMBER,"Are the `coordinates` not dimensions of those `DataArrays`? Would it be better to make them dimensions when they get read in?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,109589162
https://github.com/pydata/xarray/pull/604#issuecomment-145186449,https://api.github.com/repos/pydata/xarray/issues/604,145186449,MDEyOklzc3VlQ29tbWVudDE0NTE4NjQ0OQ==,5356122,2015-10-03T00:11:42Z,2015-10-03T00:11:42Z,MEMBER,"This looks good. The general strategy with the `FacetGrid` was to bring the minimum amount of code in from Seaborn to make it do what we wanted. I see no issues in iterating like this, ie. bring in pieces of the code with tests as we need them.
Side note- I'm back in grad school studying for qualifying exams, so forgive me if it takes me a while to respond in the future.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,109583455
https://github.com/pydata/xarray/pull/601#issuecomment-144856670,https://api.github.com/repos/pydata/xarray/issues/601,144856670,MDEyOklzc3VlQ29tbWVudDE0NDg1NjY3MA==,5356122,2015-10-01T21:34:50Z,2015-10-01T21:34:50Z,MEMBER,"thanks for looking into it!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,109389491
https://github.com/pydata/xarray/pull/586#issuecomment-142481917,https://api.github.com/repos/pydata/xarray/issues/586,142481917,MDEyOklzc3VlQ29tbWVudDE0MjQ4MTkxNw==,5356122,2015-09-23T03:42:03Z,2015-09-23T03:42:03Z,MEMBER,"Looks good. You might consider testing this in `Common2dMixin` for better coverage.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,107835511
https://github.com/pydata/xarray/issues/585#issuecomment-142480620,https://api.github.com/repos/pydata/xarray/issues/585,142480620,MDEyOklzc3VlQ29tbWVudDE0MjQ4MDYyMA==,5356122,2015-09-23T03:32:23Z,2015-09-23T03:32:23Z,MEMBER,"But do the xray objects have to exist in memory? I was thinking this could also work along with `open_mfdataset`. It just loads and operates on the chunk it needs.
Like the idea of applying this to groupby objects. I wonder if it could be done transparently to the user...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,107424151
https://github.com/pydata/xarray/pull/581#issuecomment-142479881,https://api.github.com/repos/pydata/xarray/issues/581,142479881,MDEyOklzc3VlQ29tbWVudDE0MjQ3OTg4MQ==,5356122,2015-09-23T03:23:47Z,2015-09-23T03:23:47Z,MEMBER,"Unfortunately this didn't seem to fix #562 http://xray.readthedocs.org/en/latest/plotting.html#other-features
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,107050153
https://github.com/pydata/xarray/pull/583#issuecomment-141525850,https://api.github.com/repos/pydata/xarray/issues/583,141525850,MDEyOklzc3VlQ29tbWVudDE0MTUyNTg1MA==,5356122,2015-09-18T18:25:04Z,2015-09-18T18:25:04Z,MEMBER,"Now we can finally start using `A @ B`! ;)
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,107250075
https://github.com/pydata/xarray/issues/582#issuecomment-141525545,https://api.github.com/repos/pydata/xarray/issues/582,141525545,MDEyOklzc3VlQ29tbWVudDE0MTUyNTU0NQ==,5356122,2015-09-18T18:23:26Z,2015-09-18T18:23:26Z,MEMBER,"`Dataset` currently has around 100 attributes. It would be nice to keep this manageable.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,107139131
https://github.com/pydata/xarray/pull/581#issuecomment-141501523,https://api.github.com/repos/pydata/xarray/issues/581,141501523,MDEyOklzc3VlQ29tbWVudDE0MTUwMTUyMw==,5356122,2015-09-18T16:35:20Z,2015-09-18T16:35:20Z,MEMBER,"update - docs are not building after some of the changes. Fixing now.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,107050153
https://github.com/pydata/xarray/pull/581#issuecomment-141258342,https://api.github.com/repos/pydata/xarray/issues/581,141258342,MDEyOklzc3VlQ29tbWVudDE0MTI1ODM0Mg==,5356122,2015-09-17T22:45:58Z,2015-09-17T22:45:58Z,MEMBER,"Wonder if this can also fix #562. The local doc build looks good.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,107050153
https://github.com/pydata/xarray/pull/581#issuecomment-141218332,https://api.github.com/repos/pydata/xarray/issues/581,141218332,MDEyOklzc3VlQ29tbWVudDE0MTIxODMzMg==,5356122,2015-09-17T20:28:52Z,2015-09-17T20:28:52Z,MEMBER,"Failing on Python 2.6 since there is no `inspect.getcallargs`. This particular test is important- it makes sure the 2d methods and the functions have the same signature. So it needs to skip if Python version is less than 2.7.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,107050153
https://github.com/pydata/xarray/issues/575#issuecomment-140585169,https://api.github.com/repos/pydata/xarray/issues/575,140585169,MDEyOklzc3VlQ29tbWVudDE0MDU4NTE2OQ==,5356122,2015-09-16T00:11:28Z,2015-09-16T00:11:28Z,MEMBER,"Not possible now. Wouldn't be much trouble to add it though. @drewokane has been working on generalizing the 1d plotting in #566. This might be a nice thing to include.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,106562046
https://github.com/pydata/xarray/pull/566#issuecomment-140237861,https://api.github.com/repos/pydata/xarray/issues/566,140237861,MDEyOklzc3VlQ29tbWVudDE0MDIzNzg2MQ==,5356122,2015-09-15T00:10:19Z,2015-09-15T00:10:19Z,MEMBER,"Still need tests for these. It would be possible to do something like `test_plots.Common2dMixin` here, or do something more direct.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,105673104
https://github.com/pydata/xarray/pull/559#issuecomment-140082274,https://api.github.com/repos/pydata/xarray/issues/559,140082274,MDEyOklzc3VlQ29tbWVudDE0MDA4MjI3NA==,5356122,2015-09-14T13:54:24Z,2015-09-14T13:54:24Z,MEMBER,"Is this ready or do you want to wait until setting up cartopy?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,104768781
https://github.com/pydata/xarray/pull/570#issuecomment-139581317,https://api.github.com/repos/pydata/xarray/issues/570,139581317,MDEyOklzc3VlQ29tbWVudDEzOTU4MTMxNw==,5356122,2015-09-11T15:46:12Z,2015-09-11T15:46:12Z,MEMBER,"Looks good. Do you know what's going on with the 3.4 tests?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,105929358
https://github.com/pydata/xarray/issues/562#issuecomment-138733804,https://api.github.com/repos/pydata/xarray/issues/562,138733804,MDEyOklzc3VlQ29tbWVudDEzODczMzgwNA==,5356122,2015-09-08T23:53:33Z,2015-09-08T23:53:33Z,MEMBER,"On my local build I see this:
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,105490671
https://github.com/pydata/xarray/issues/561#issuecomment-138729068,https://api.github.com/repos/pydata/xarray/issues/561,138729068,MDEyOklzc3VlQ29tbWVudDEzODcyOTA2OA==,5356122,2015-09-08T23:18:43Z,2015-09-08T23:18:43Z,MEMBER,"```
ds = xray.tutorial.load_dataset('air_temperature')
percents = ds.groupby('time.month').reduce(np.percentile, q=5)
```
Producing:
```
In [80]: percents
Out[80]:
Dimensions: (month: 12)
Coordinates:
* month (month) int64 1 2 3 4 5 6 7 8 9 10 11 12
Data variables:
air (month) float64 239.7 239.3 244.3 251.7 261.4 271.5 274.0 272.5 ...
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,105442957
https://github.com/pydata/xarray/pull/559#issuecomment-138600307,https://api.github.com/repos/pydata/xarray/issues/559,138600307,MDEyOklzc3VlQ29tbWVudDEzODYwMDMwNw==,5356122,2015-09-08T15:27:48Z,2015-09-08T15:27:48Z,MEMBER,"In the future we'll probably want to do more with Cartopy. So yes, it might be nice to get it going on Travis.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,104768781
https://github.com/pydata/xarray/pull/527#issuecomment-137870866,https://api.github.com/repos/pydata/xarray/issues/527,137870866,MDEyOklzc3VlQ29tbWVudDEzNzg3MDg2Ng==,5356122,2015-09-04T22:25:25Z,2015-09-04T22:25:25Z,MEMBER,"Ok, going to merge once the build passes. Will continue with the rest of the stuff next week. @shoyer should I rebase or squash these commits?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137835422,https://api.github.com/repos/pydata/xarray/issues/527,137835422,MDEyOklzc3VlQ29tbWVudDEzNzgzNTQyMg==,5356122,2015-09-04T19:37:08Z,2015-09-04T19:37:08Z,MEMBER,"@shoyer Latest commit also added a little more to the docs on how to use the attributes `data` `axes`, and `name_dicts`.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137588842,https://api.github.com/repos/pydata/xarray/issues/527,137588842,MDEyOklzc3VlQ29tbWVudDEzNzU4ODg0Mg==,5356122,2015-09-03T22:15:47Z,2015-09-03T22:15:47Z,MEMBER,"By the way, I believe this is to a point where we could easily tune any of the aesthetics- say shrinking the width of the colorbar or using a different number of ticks / sizes on the labels.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137587792,https://api.github.com/repos/pydata/xarray/issues/527,137587792,MDEyOklzc3VlQ29tbWVudDEzNzU4Nzc5Mg==,5356122,2015-09-03T22:09:32Z,2015-09-03T22:09:32Z,MEMBER,"Here's what's left to do:
- [ ] convenience method `darray.plot(row='z')`
- [ ] map example using matplotlib quiver plot
- [ ] port any more methods / features from Seaborn FacetGrid
@shoyer, am I forgetting anything?
Ready for this PR to be reviewed now. I can finish the rest in a follow up PR.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-131240388,https://api.github.com/repos/pydata/xarray/issues/527,131240388,MDEyOklzc3VlQ29tbWVudDEzMTI0MDM4OA==,5356122,2015-08-14T21:13:12Z,2015-09-03T21:57:53Z,MEMBER,"For this PR:
- [x] facet on rows and columns
- [x] Align label on colorbar
- [x] Label figure axes
- [x] Use xray plotting logic to make nice colorbar
- [x] Make and test choices around colorbar
EDIT - going to revisit `plt.contour(color='k')` after #537 gets worked out.
- [x] separate iteration over data from plotting - edge case: require the index to actually be unique `.is_unique`.
- [x] Use core string formatting for titles
- [x] tests for all of above
- [x] test `col_wrap`
- [x] write and organize docs
- [x] docs for public attribute- axes and such
On this PR or possibly a different one:
- [ ] Convenience method to easily make faceted plots- something like `darray.plot(col='time')`
- [x] port Seaborn's aspect capabilities
- [ ] matplotlib quiver plot for map example
- [x] Create new `xray.tutorial` module with function like `load_example_dataset` for plotting examples
Different PR:
- [ ] Facets and maps
- [ ] Inline documentation and plots for API reference
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/559#issuecomment-137562762,https://api.github.com/repos/pydata/xarray/issues/559,137562762,MDEyOklzc3VlQ29tbWVudDEzNzU2Mjc2Mg==,5356122,2015-09-03T20:19:37Z,2015-09-03T20:19:37Z,MEMBER,"Works for me. And we still need to do imshow, right?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,104768781
https://github.com/pydata/xarray/pull/527#issuecomment-137490299,https://api.github.com/repos/pydata/xarray/issues/527,137490299,MDEyOklzc3VlQ29tbWVudDEzNzQ5MDI5OQ==,5356122,2015-09-03T15:45:49Z,2015-09-03T15:45:49Z,MEMBER,"@shoyer multiple labels on x / y axes compared to the one above.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137274951,https://api.github.com/repos/pydata/xarray/issues/527,137274951,MDEyOklzc3VlQ29tbWVudDEzNzI3NDk1MQ==,5356122,2015-09-02T23:45:56Z,2015-09-02T23:45:56Z,MEMBER,"Starting to agree with @shoyer and Seaborn on the multiple labels:
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137273992,https://api.github.com/repos/pydata/xarray/issues/527,137273992,MDEyOklzc3VlQ29tbWVudDEzNzI3Mzk5Mg==,5356122,2015-09-02T23:37:56Z,2015-09-02T23:37:56Z,MEMBER,"Getting better...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137263395,https://api.github.com/repos/pydata/xarray/issues/527,137263395,MDEyOklzc3VlQ29tbWVudDEzNzI2MzM5NQ==,5356122,2015-09-02T22:30:03Z,2015-09-02T22:30:03Z,MEMBER,"Thanks for the encouragement @jhamman - I'll take what I can get! Seem to be finding a way around it by setting custom `ax.xaxis.set_major_locator`
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137254992,https://api.github.com/repos/pydata/xarray/issues/527,137254992,MDEyOklzc3VlQ29tbWVudDEzNzI1NDk5Mg==,5356122,2015-09-02T21:52:22Z,2015-09-02T21:52:22Z,MEMBER,"Aaaaaaahhh!!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137237428,https://api.github.com/repos/pydata/xarray/issues/527,137237428,MDEyOklzc3VlQ29tbWVudDEzNzIzNzQyOA==,5356122,2015-09-02T20:37:51Z,2015-09-02T20:37:51Z,MEMBER,"Issues seem to be mostly caused by the colorbar.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/issues/557#issuecomment-137134794,https://api.github.com/repos/pydata/xarray/issues/557,137134794,MDEyOklzc3VlQ29tbWVudDEzNzEzNDc5NA==,5356122,2015-09-02T15:32:17Z,2015-09-02T15:32:17Z,MEMBER,"Just curious- how would we currently do this?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,104484316
https://github.com/pydata/xarray/pull/527#issuecomment-136885470,https://api.github.com/repos/pydata/xarray/issues/527,136885470,MDEyOklzc3VlQ29tbWVudDEzNjg4NTQ3MA==,5356122,2015-09-01T22:54:31Z,2015-09-01T22:54:31Z,MEMBER,"I believe it's possible to fix automatically. Somehow. Will look into it further tomorrow.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136880349,https://api.github.com/repos/pydata/xarray/issues/527,136880349,MDEyOklzc3VlQ29tbWVudDEzNjg4MDM0OQ==,5356122,2015-09-01T22:22:35Z,2015-09-01T22:22:45Z,MEMBER,"For reference, here's what is happening once aspect is adjusted. x axes are all crowded.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136878263,https://api.github.com/repos/pydata/xarray/issues/527,136878263,MDEyOklzc3VlQ29tbWVudDEzNjg3ODI2Mw==,5356122,2015-09-01T22:09:49Z,2015-09-01T22:09:49Z,MEMBER,"Some issues cropping up with using `plt.tight_layout` when manipulating the aspect and size.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136527660,https://api.github.com/repos/pydata/xarray/issues/527,136527660,MDEyOklzc3VlQ29tbWVudDEzNjUyNzY2MA==,5356122,2015-08-31T23:34:11Z,2015-09-01T22:02:34Z,MEMBER,"take aspects and figure sizes from seaborn
Done
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136525214,https://api.github.com/repos/pydata/xarray/issues/527,136525214,MDEyOklzc3VlQ29tbWVudDEzNjUyNTIxNA==,5356122,2015-08-31T23:15:30Z,2015-09-01T21:35:12Z,MEMBER,"add ability to set `margin_titles=True`.
TODO- don't really understand the use case for this.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136849815,https://api.github.com/repos/pydata/xarray/issues/527,136849815,MDEyOklzc3VlQ29tbWVudDEzNjg0OTgxNQ==,5356122,2015-09-01T20:20:49Z,2015-09-01T20:20:49Z,MEMBER,"yep, could definitely do that. I'm still not crazy about repeating the x, y labels like that. Let me see if I can come up with a nice alternative using text on the figure.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136847156,https://api.github.com/repos/pydata/xarray/issues/527,136847156,MDEyOklzc3VlQ29tbWVudDEzNjg0NzE1Ng==,5356122,2015-09-01T20:15:05Z,2015-09-01T20:15:05Z,MEMBER,"Here's what we have now with one missing block.
Not sure about these aesthetics.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136523447,https://api.github.com/repos/pydata/xarray/issues/527,136523447,MDEyOklzc3VlQ29tbWVudDEzNjUyMzQ0Nw==,5356122,2015-08-31T23:03:43Z,2015-09-01T17:53:25Z,MEMBER,"todo- make sure to seed random number generator or else use deterministic
Done
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136524437,https://api.github.com/repos/pydata/xarray/issues/527,136524437,MDEyOklzc3VlQ29tbWVudDEzNjUyNDQzNw==,5356122,2015-08-31T23:10:18Z,2015-08-31T23:10:18Z,MEMBER,"add matplotlib quiver plot for `map` example.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/551#issuecomment-136434352,https://api.github.com/repos/pydata/xarray/issues/551,136434352,MDEyOklzc3VlQ29tbWVudDEzNjQzNDM1Mg==,5356122,2015-08-31T17:23:10Z,2015-08-31T17:23:10Z,MEMBER,"> variable names must be hashable (and unique)
This makes datasets behave like dictionaries, which are familiar for Python users. A good thing.
> raise an error in to_netcdf in the event the variable name is invalid.
@jhamman +1 for this solution
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,103055174
https://github.com/pydata/xarray/pull/527#issuecomment-135912898,https://api.github.com/repos/pydata/xarray/issues/527,135912898,MDEyOklzc3VlQ29tbWVudDEzNTkxMjg5OA==,5356122,2015-08-28T23:29:27Z,2015-08-28T23:29:27Z,MEMBER,"Here's where the progress stands:
```
g = xray.plot.FacetGrid(t5, col='time', col_wrap=2)
g.map_dataarray(xray.plot.contour, color='k')
```
Looks like the column wrapping does the right thing by leaving the last axes blank.
Observe #537 is still an issue here. We'll have to make sure that when that is fixed it also works for these facets.
On Monday morning I can clean the code up, take out the seaborn chunks, reorganize the docs, and then I'll be ready to ask for a review.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/538#issuecomment-135587730,https://api.github.com/repos/pydata/xarray/issues/538,135587730,MDEyOklzc3VlQ29tbWVudDEzNTU4NzczMA==,5356122,2015-08-27T23:59:33Z,2015-08-27T23:59:33Z,MEMBER,"@rabernat We were all Git noobs at some point- don't worry about it!
Seaborn should not be a dependency.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/550#issuecomment-135127141,https://api.github.com/repos/pydata/xarray/issues/550,135127141,MDEyOklzc3VlQ29tbWVudDEzNTEyNzE0MQ==,5356122,2015-08-26T18:10:27Z,2015-08-26T18:10:27Z,MEMBER,"Merging
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,102866893
https://github.com/pydata/xarray/pull/551#issuecomment-135099870,https://api.github.com/repos/pydata/xarray/issues/551,135099870,MDEyOklzc3VlQ29tbWVudDEzNTA5OTg3MA==,5356122,2015-08-26T16:37:59Z,2015-08-26T16:37:59Z,MEMBER,"Were you planning on also adding these checks to the keys of a Dataset in this PR? Because I believe you can still do this:
```
c = xray.Dataset({'a': a, ('b', 'b'): b})
```
and it won't raise an error.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,103055174
https://github.com/pydata/xarray/pull/550#issuecomment-135083835,https://api.github.com/repos/pydata/xarray/issues/550,135083835,MDEyOklzc3VlQ29tbWVudDEzNTA4MzgzNQ==,5356122,2015-08-26T16:16:35Z,2015-08-26T16:16:35Z,MEMBER,"@jhamman any more feedback before merge?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,102866893
https://github.com/pydata/xarray/pull/550#issuecomment-134773368,https://api.github.com/repos/pydata/xarray/issues/550,134773368,MDEyOklzc3VlQ29tbWVudDEzNDc3MzM2OA==,5356122,2015-08-25T23:57:17Z,2015-08-25T23:57:17Z,MEMBER,"@jhamman I took out the `robust_percentile` arg. You're right, it's better this way.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,102866893
https://github.com/pydata/xarray/pull/550#issuecomment-134369449,https://api.github.com/repos/pydata/xarray/issues/550,134369449,MDEyOklzc3VlQ29tbWVudDEzNDM2OTQ0OQ==,5356122,2015-08-24T20:30:25Z,2015-08-24T20:30:25Z,MEMBER,"Was trying to keep the internal code a little more modular by parameterizing the percentiles.
But it was simpler before. Maybe should keep it like it was.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,102866893
https://github.com/pydata/xarray/pull/549#issuecomment-134362572,https://api.github.com/repos/pydata/xarray/issues/549,134362572,MDEyOklzc3VlQ29tbWVudDEzNDM2MjU3Mg==,5356122,2015-08-24T20:10:12Z,2015-08-24T20:10:12Z,MEMBER,"You mentioned in the bug report:
> Another way is just to raise an error if a not string variable name is used.
Raising a `TypeError` seems like the way to go here, since `str` works on anything. Relevant line in 'Zen':
> In the face of ambiguity, refuse the temptation to guess.
Also, are there other places to implement this? Say the keys of a `dataset`?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,102840892
https://github.com/pydata/xarray/pull/538#issuecomment-134281471,https://api.github.com/repos/pydata/xarray/issues/538,134281471,MDEyOklzc3VlQ29tbWVudDEzNDI4MTQ3MQ==,5356122,2015-08-24T16:19:57Z,2015-08-24T16:19:57Z,MEMBER,"@shoyer has laid out a nice plan.
@rabernat do you feel like taking this on now? If not we can merge this and implement the rest later.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/issues/548#issuecomment-134220841,https://api.github.com/repos/pydata/xarray/issues/548,134220841,MDEyOklzc3VlQ29tbWVudDEzNDIyMDg0MQ==,5356122,2015-08-24T14:16:32Z,2015-08-24T14:16:32Z,MEMBER,"This seems useful. xray uses the [netCDF4 library](http://unidata.github.io/netcdf4-python/) here, and they support it. In the meantime, you could always add a post processing step from the command line: http://www.unidata.ucar.edu/blogs/developer/en/entry/netcdf_compression.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,102703065
https://github.com/pydata/xarray/pull/544#issuecomment-133227748,https://api.github.com/repos/pydata/xarray/issues/544,133227748,MDEyOklzc3VlQ29tbWVudDEzMzIyNzc0OA==,5356122,2015-08-21T00:37:12Z,2015-08-21T00:37:12Z,MEMBER,"I forgot to include requests as a dependency.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,102268278
https://github.com/pydata/xarray/issues/537#issuecomment-132828045,https://api.github.com/repos/pydata/xarray/issues/537,132828045,MDEyOklzc3VlQ29tbWVudDEzMjgyODA0NQ==,5356122,2015-08-19T23:47:02Z,2015-08-19T23:47:02Z,MEMBER,"@rabernat Thanks!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101716715
https://github.com/pydata/xarray/issues/541#issuecomment-132675257,https://api.github.com/repos/pydata/xarray/issues/541,132675257,MDEyOklzc3VlQ29tbWVudDEzMjY3NTI1Nw==,5356122,2015-08-19T16:20:37Z,2015-08-19T16:20:37Z,MEMBER,"Thanks for the report. This example indeed fails in 0.5.1, but it works in 0.5.2.
There's a fix documented in the latest release, but it doesn't reference a bug report- http://xray.readthedocs.org/en/stable/whats-new.html#bug-fixes
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101858170
https://github.com/pydata/xarray/issues/185#issuecomment-132307937,https://api.github.com/repos/pydata/xarray/issues/185,132307937,MDEyOklzc3VlQ29tbWVudDEzMjMwNzkzNw==,5356122,2015-08-18T18:25:39Z,2015-08-18T18:25:39Z,MEMBER,"Closed by #466
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,38109425
https://github.com/pydata/xarray/issues/534#issuecomment-132054580,https://api.github.com/repos/pydata/xarray/issues/534,132054580,MDEyOklzc3VlQ29tbWVudDEzMjA1NDU4MA==,5356122,2015-08-18T03:18:07Z,2015-08-18T03:18:07Z,MEMBER,"nice- I had forgotten about those
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101511945
https://github.com/pydata/xarray/issues/324#issuecomment-131891348,https://api.github.com/repos/pydata/xarray/issues/324,131891348,MDEyOklzc3VlQ29tbWVudDEzMTg5MTM0OA==,5356122,2015-08-17T17:04:44Z,2015-08-17T17:04:44Z,MEMBER,"For (2) I think it makes sense to extend the existing groupby to deal with multiple dimensions. Ie, let it take an iterable of dimension names.
```
>>> darray.groupby(['lat', 'lon'])
```
Then we'd have something similar to the [SQL](http://www.w3schools.com/sql/sql_groupby.asp) groupby, which is a good thing.
By the way, in #527 we were considering using this approach to make the faceted plots on both rows and columns.
","{""total_count"": 4, ""+1"": 4, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,58117200
https://github.com/pydata/xarray/issues/533#issuecomment-131195596,https://api.github.com/repos/pydata/xarray/issues/533,131195596,MDEyOklzc3VlQ29tbWVudDEzMTE5NTU5Ng==,5356122,2015-08-14T17:59:53Z,2015-08-14T17:59:53Z,MEMBER,"+1 This came up in discussion on #519
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101061611
https://github.com/pydata/xarray/pull/527#issuecomment-131173521,https://api.github.com/repos/pydata/xarray/issues/527,131173521,MDEyOklzc3VlQ29tbWVudDEzMTE3MzUyMQ==,5356122,2015-08-14T16:37:28Z,2015-08-14T16:37:28Z,MEMBER,"Thanks! The colorbar label spacing is a matplotlib thing- it only became a problem after rotating it to match the row labels. So I expect that I can fix it by changing the anchor point or placing it manually.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-130903866,https://api.github.com/repos/pydata/xarray/issues/527,130903866,MDEyOklzc3VlQ29tbWVudDEzMDkwMzg2Ng==,5356122,2015-08-14T00:47:54Z,2015-08-14T00:47:54Z,MEMBER,"Here's what a 4d array looks like.
```
In [26]: t4d = xray.concat([t2, t2 + 50], pd.Index(['normal', 'hot'], name='fourth_dim'))
# This is a 4d array
In [27]: t4d.coords
Out[27]:
Coordinates:
* lat (lat) float32 75.0 72.5 70.0 67.5 65.0 62.5 60.0 57.5 55.0 ...
* lon (lon) float32 200.0 202.5 205.0 207.5 210.0 212.5 215.0 ...
* time (time) datetime64[ns] 2013-01-01 2013-03-04T12:00:00
* fourth_dim (fourth_dim) object 'normal' 'hot'
In [28]: g = xray.plot.FacetGrid(t4d, col='time', row='fourth_dim')
In [29]: g.map_dataarray(xray.plot.imshow, 'lon', 'lat')
Out[29]:
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-130766241,https://api.github.com/repos/pydata/xarray/issues/527,130766241,MDEyOklzc3VlQ29tbWVudDEzMDc2NjI0MQ==,5356122,2015-08-13T17:17:05Z,2015-08-13T17:17:05Z,MEMBER,"@shoyer Here's what we currently have:
```
In [15]: g = xray.plot.FacetGrid(t, col='time', col_wrap=2)
In [16]: g.map_dataarray(xray.plot.contourf, 'lon', 'lat')
Out[16]:
```
Right now this assumes that the function for map_dataarray has the same signature as 2d xray plotting methods.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/519#issuecomment-130398680,https://api.github.com/repos/pydata/xarray/issues/519,130398680,MDEyOklzc3VlQ29tbWVudDEzMDM5ODY4MA==,5356122,2015-08-12T18:15:22Z,2015-08-12T18:15:22Z,MEMBER,"> Maybe we should restrict squeezing the data to only the magic DataArray.plot() method?
Works for me. The error message should be informative enough in the other cases.
Scalar coordinates- this is the current behavior:
```
In [16]: a = xray.DataArray(np.random.randn(3, 4))
In [17]: a.coords['foo'] = 123
In [18]: a.plot()
```
So scalar coordinates do show up in the title, which is what I was going for. I could add a test for this.
> labelling facets will be more reliable if it is done explicitly in the same code that is doing the indexing/groupby.
That's the approach that I've moved to after spending more time on it. This PR adds the argument `add_labels` to 2d plotting functions. Now for the faceting I'll actually use `add_labels=False`.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,99547211
https://github.com/pydata/xarray/pull/519#issuecomment-129649712,https://api.github.com/repos/pydata/xarray/issues/519,129649712,MDEyOklzc3VlQ29tbWVudDEyOTY0OTcxMg==,5356122,2015-08-10T23:55:33Z,2015-08-10T23:55:33Z,MEMBER,"Will finish this up tomorrow morning.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,99547211
https://github.com/pydata/xarray/pull/519#issuecomment-129630708,https://api.github.com/repos/pydata/xarray/issues/519,129630708,MDEyOklzc3VlQ29tbWVudDEyOTYzMDcwOA==,5356122,2015-08-10T22:11:07Z,2015-08-10T22:11:07Z,MEMBER,"@jhamman Yes, ready for review.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,99547211
https://github.com/pydata/xarray/pull/519#issuecomment-129556441,https://api.github.com/repos/pydata/xarray/issues/519,129556441,MDEyOklzc3VlQ29tbWVudDEyOTU1NjQ0MQ==,5356122,2015-08-10T18:22:58Z,2015-08-10T18:22:58Z,MEMBER,"@jhamman good idea :+1:
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,99547211
https://github.com/pydata/xarray/pull/518#issuecomment-128503193,https://api.github.com/repos/pydata/xarray/issues/518,128503193,MDEyOklzc3VlQ29tbWVudDEyODUwMzE5Mw==,5356122,2015-08-06T20:46:42Z,2015-08-06T20:46:42Z,MEMBER,"```
In [1]: import matplotlib
In [2]: import matplotlib.pyplot
In [3]: matplotlib.use('Agg')
/Users/clark.fitzgerald/anaconda/envs/xray_dev/lib/python2.7/site-packages/matplotlib/__init__.py:1318: UserWarning: This call to matplotlib.use() has no effect
because the backend has already been chosen;
matplotlib.use() must be called *before* pylab, matplotlib.pyplot,
or matplotlib.backends is imported for the first time.
warnings.warn(_use_error_msg)
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,99513363
https://github.com/pydata/xarray/pull/518#issuecomment-128502431,https://api.github.com/repos/pydata/xarray/issues/518,128502431,MDEyOklzc3VlQ29tbWVudDEyODUwMjQzMQ==,5356122,2015-08-06T20:43:19Z,2015-08-06T20:43:19Z,MEMBER,"But really if people need to use a particular backend (like in our case) they should be setting it in the first place. Seaborn doesn't go beyond what `pyplot` does here, so I think it's ok.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,99513363
https://github.com/pydata/xarray/pull/518#issuecomment-128502013,https://api.github.com/repos/pydata/xarray/issues/518,128502013,MDEyOklzc3VlQ29tbWVudDEyODUwMjAxMw==,5356122,2015-08-06T20:41:19Z,2015-08-06T20:41:19Z,MEMBER,"Yes, this is a little tricky. Internally Seaborn uses lots of `pyplot`. And importing `pyplot` sets the backend. So maybe they could try something like [pyplot.switch_backend](http://matplotlib.org/api/pyplot_api.html#matplotlib.pyplot.switch_backend) within their `reset_orig` function?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,99513363
https://github.com/pydata/xarray/pull/518#issuecomment-128494659,https://api.github.com/repos/pydata/xarray/issues/518,128494659,MDEyOklzc3VlQ29tbWVudDEyODQ5NDY1OQ==,5356122,2015-08-06T20:15:57Z,2015-08-06T20:15:57Z,MEMBER,"Explanation-
Looks like the backend is set when Seaborn is imported. When building the docs we don't want to use an interactive [backend](http://matplotlib.org/faq/usage_faq.html#what-is-a-backend).
```
(xray_dev)testimage ~/dev/xray/doc $ ipython
Python 2.7.10 |Continuum Analytics, Inc.| (default, May 28 2015, 17:04:42)
...
In [1]: import seaborn
In [2]: import matplotlib
In [3]: matplotlib.use('Agg')
/Users/clark.fitzgerald/anaconda/envs/xray_dev/lib/python2.7/site-packages/matplotlib/__init__.py:1318: UserWarning: This call to matplotlib.use() has no effect
because the backend has already been chosen;
matplotlib.use() must be called *before* pylab, matplotlib.pyplot,
or matplotlib.backends is imported for the first time.
warnings.warn(_use_error_msg)
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,99513363
https://github.com/pydata/xarray/pull/509#issuecomment-128417092,https://api.github.com/repos/pydata/xarray/issues/509,128417092,MDEyOklzc3VlQ29tbWVudDEyODQxNzA5Mg==,5356122,2015-08-06T15:53:54Z,2015-08-06T15:53:54Z,MEMBER,"Yes, looks good. Merge away!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98629509
https://github.com/pydata/xarray/pull/509#issuecomment-128188132,https://api.github.com/repos/pydata/xarray/issues/509,128188132,MDEyOklzc3VlQ29tbWVudDEyODE4ODEzMg==,5356122,2015-08-06T00:01:02Z,2015-08-06T00:01:02Z,MEMBER,"Nice work @jhamman @shoyer. Tests look pretty thorough and I like all the helper functions.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98629509
https://github.com/pydata/xarray/pull/514#issuecomment-127658427,https://api.github.com/repos/pydata/xarray/issues/514,127658427,MDEyOklzc3VlQ29tbWVudDEyNzY1ODQyNw==,5356122,2015-08-04T15:58:24Z,2015-08-04T15:58:24Z,MEMBER,"@kjordahl this is certainly an improvement.
We're planning on reworking many of these plotting examples to use [this data](https://github.com/xray/xray-data), and it would be great to update this cartopy one as well.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98879536
https://github.com/pydata/xarray/pull/504#issuecomment-126922669,https://api.github.com/repos/pydata/xarray/issues/504,126922669,MDEyOklzc3VlQ29tbWVudDEyNjkyMjY2OQ==,5356122,2015-08-01T14:44:50Z,2015-08-01T14:44:50Z,MEMBER,"Looks good. Merge?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98274024
https://github.com/pydata/xarray/pull/504#issuecomment-126824906,https://api.github.com/repos/pydata/xarray/issues/504,126824906,MDEyOklzc3VlQ29tbWVudDEyNjgyNDkwNg==,5356122,2015-07-31T22:11:03Z,2015-07-31T22:11:03Z,MEMBER,"I was thinking about only allowing it to work only if the array has exactly matching coordinates. Which would be the case in (4) `a[(x > 0) & (y > 0)]`. But then it would be difficult to stay consistent in the 1d case- mask or select?
> My sense is that we'll probably be happier if we have entirely distinct APIs for masking (.where) and
> selection ([] and .loc[]).
That's a concrete and easy to understand distinction. I'm convinced.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98274024
https://github.com/pydata/xarray/pull/502#issuecomment-126813595,https://api.github.com/repos/pydata/xarray/issues/502,126813595,MDEyOklzc3VlQ29tbWVudDEyNjgxMzU5NQ==,5356122,2015-07-31T21:13:39Z,2015-07-31T21:13:39Z,MEMBER,"go for it!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98228846