html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/7788#issuecomment-1551178793,https://api.github.com/repos/pydata/xarray/issues/7788,1551178793,IC_kwDOAMm_X85cdRwp,454724,2023-05-17T10:57:05Z,2023-05-17T10:57:05Z,CONTRIBUTOR,"@dcherian Sure, done :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501
https://github.com/pydata/xarray/pull/7788#issuecomment-1549984548,https://api.github.com/repos/pydata/xarray/issues/7788,1549984548,IC_kwDOAMm_X85cYuMk,454724,2023-05-16T16:21:12Z,2023-05-16T16:21:12Z,CONTRIBUTOR,"I like it, solves the concern in my previous comment as well. Updated the branch.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501
https://github.com/pydata/xarray/pull/7788#issuecomment-1545300010,https://api.github.com/repos/pydata/xarray/issues/7788,1545300010,IC_kwDOAMm_X85cG2gq,454724,2023-05-12T07:26:52Z,2023-05-12T07:26:52Z,CONTRIBUTOR,@kmuehlbauer Do you need any adjustments to merge this?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501
https://github.com/pydata/xarray/pull/7788#issuecomment-1527322138,https://api.github.com/repos/pydata/xarray/issues/7788,1527322138,IC_kwDOAMm_X85bCRYa,454724,2023-04-28T10:10:08Z,2023-04-28T10:10:08Z,CONTRIBUTOR,"@kmuehlbauer Okay, I got it. It only seems to happen with float arrays. I adjusted the test, and it now fails without the fix.

Only tangentially related to this PR, but I noticed that `as_compatible_data` will modify the original data in this path, since asarray passes through the original and afterwards the masked values are replaced with `fill_value`. So `masked_array > some_dataarray` might modify `masked_array`. Shouldn't it default to creating a copy to prevent this?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501
https://github.com/pydata/xarray/pull/7788#issuecomment-1527198919,https://api.github.com/repos/pydata/xarray/issues/7788,1527198919,IC_kwDOAMm_X85bBzTH,454724,2023-04-28T08:41:32Z,2023-04-28T08:41:32Z,CONTRIBUTOR,@kmuehlbauer For some reason I can't reproduce it anymore. I'll monitor whether it occurs again in the original situation and close this otherwise after some time.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501
https://github.com/pydata/xarray/pull/7788#issuecomment-1523837408,https://api.github.com/repos/pydata/xarray/issues/7788,1523837408,IC_kwDOAMm_X85a0-ng,454724,2023-04-26T18:01:45Z,2023-04-26T18:01:45Z,CONTRIBUTOR,"@kmuehlbauer Sure, I pushed the test as I was hoping it would work.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501
https://github.com/pydata/xarray/pull/7788#issuecomment-1523814515,https://api.github.com/repos/pydata/xarray/issues/7788,1523814515,IC_kwDOAMm_X85a05Bz,454724,2023-04-26T17:41:47Z,2023-04-26T17:41:47Z,CONTRIBUTOR,"Hi @kmuehlbauer, no worries! It's in draft because can't figure out how to reproduce this bug for the tests. `data[mask] = fill_value` was crashing when I tried to create a DataArray from a non-writeable MaskedArray I got via [netCDF4](https://github.com/Unidata/netcdf4-python/) from a remote source. `data = np.asarray(data, dtype=dtype)` didn't set `writeable` to `true` in that case, but it does when I create a non-writeable MaskedArray in the tests. Any ideas how to test this properly?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501