html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4006#issuecomment-633103428,https://api.github.com/repos/pydata/xarray/issues/4006,633103428,MDEyOklzc3VlQ29tbWVudDYzMzEwMzQyOA==,40136154,2020-05-23T17:41:56Z,2020-05-23T17:41:56Z,CONTRIBUTOR,Thank you!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,606823874
https://github.com/pydata/xarray/pull/4006#issuecomment-632975460,https://api.github.com/repos/pydata/xarray/issues/4006,632975460,MDEyOklzc3VlQ29tbWVudDYzMjk3NTQ2MA==,40136154,2020-05-23T02:59:24Z,2020-05-23T02:59:24Z,CONTRIBUTOR,@keewis are there any other changes required?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,606823874
https://github.com/pydata/xarray/pull/4026#issuecomment-623753704,https://api.github.com/repos/pydata/xarray/issues/4026,623753704,MDEyOklzc3VlQ29tbWVudDYyMzc1MzcwNA==,40136154,2020-05-04T23:05:48Z,2020-05-04T23:46:41Z,CONTRIBUTOR,"Will surely write.
@max-sixty, Please review it again.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,611850402
https://github.com/pydata/xarray/pull/4026#issuecomment-623680441,https://api.github.com/repos/pydata/xarray/issues/4026,623680441,MDEyOklzc3VlQ29tbWVudDYyMzY4MDQ0MQ==,40136154,2020-05-04T20:12:09Z,2020-05-04T20:12:41Z,CONTRIBUTOR,"@max-sixty, sorry! I am not getting you. Can you be more clearer?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,611850402
https://github.com/pydata/xarray/issues/4002#issuecomment-619403922,https://api.github.com/repos/pydata/xarray/issues/4002,619403922,MDEyOklzc3VlQ29tbWVudDYxOTQwMzkyMg==,40136154,2020-04-25T16:19:26Z,2020-04-25T16:19:26Z,CONTRIBUTOR,"Agreed with that. So, should I open another issue for asserts or not?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,606549469
https://github.com/pydata/xarray/issues/4002#issuecomment-619358326,https://api.github.com/repos/pydata/xarray/issues/4002,619358326,MDEyOklzc3VlQ29tbWVudDYxOTM1ODMyNg==,40136154,2020-04-25T10:37:05Z,2020-04-25T10:37:05Z,CONTRIBUTOR,"@shoyer, I partially agree with your statement that "" `assert` is the appropriate way to verify internal invariants"". This is correct but not every time. When you see the link that you shared it also shows that most of the assert statements are used in tests and not in simple files.
Let me quote again
""Since `assert` provides an easy way to check some condition and fail execution, it’s very common for developers to use it to check validity. But when the Python interpreter is invoked with the -O (optimize) flag, the `assert` statements are removed from the bytecode. So, if `assert` statements are used for user-facing validation in production code, the block won’t be executed at all — potentially opening up a security vulnerability. It is recommended to use assert statements only in tests.""
Again it's just a suggestion IMHO","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,606549469
https://github.com/pydata/xarray/issues/4002#issuecomment-619320551,https://api.github.com/repos/pydata/xarray/issues/4002,619320551,MDEyOklzc3VlQ29tbWVudDYxOTMyMDU1MQ==,40136154,2020-04-25T04:51:10Z,2020-04-25T04:52:30Z,CONTRIBUTOR,"> I might be behind the curve on the pythonic approach there: what's wrong with `assert`s there?
As far as I know, assert should not be used outside of tests because while running python with -O (optimize) flag, it will remove the assert statements.
Will open a separate issue for this. We should have a discussion over asserts over there.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,606549469
https://github.com/pydata/xarray/issues/4002#issuecomment-619320043,https://api.github.com/repos/pydata/xarray/issues/4002,619320043,MDEyOklzc3VlQ29tbWVudDYxOTMyMDA0Mw==,40136154,2020-04-25T04:46:09Z,2020-04-25T04:46:09Z,CONTRIBUTOR,"> > We would take a PR to change these to default `None` and then `x=x or {}`
>
> I like this pattern a little better, because it's clear it's comparing to a default value:
>
> ```python
> if x is None:
> x = {}
> ```
@shoyer I was thinking of the same. Will send a PR with this change.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,606549469
https://github.com/pydata/xarray/issues/4002#issuecomment-619215393,https://api.github.com/repos/pydata/xarray/issues/4002,619215393,MDEyOklzc3VlQ29tbWVudDYxOTIxNTM5Mw==,40136154,2020-04-24T20:04:58Z,2020-04-24T20:04:58Z,CONTRIBUTOR,"Same can also be found in `xarray/tests/test_backends.py`
```python
3621 ny=3,
3622 nz=3,
3623 transform=None,
3624 transform_args=[5000, 80000, 1000, 2000.0],3625 crs={""units"": ""m"", ""no_defs"": True, ""ellps"": ""WGS84"", ""proj"": ""utm"", ""zone"": 18},
3626 open_kwargs=None,
3627 additional_attrs=None,
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,606549469
https://github.com/pydata/xarray/pull/3999#issuecomment-618774966,https://api.github.com/repos/pydata/xarray/issues/3999,618774966,MDEyOklzc3VlQ29tbWVudDYxODc3NDk2Ng==,40136154,2020-04-24T03:01:15Z,2020-04-24T03:01:15Z,CONTRIBUTOR,@shoyer Thanks for the suggestions. I have re-introduced len() over there. Seems like tests were written by taking dates as numpy array and not just simple array.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,605921766