html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/1068#issuecomment-517231392,https://api.github.com/repos/pydata/xarray/issues/1068,517231392,MDEyOklzc3VlQ29tbWVudDUxNzIzMTM5Mg==,3639582,2019-08-01T10:47:12Z,2019-08-01T10:47:12Z,CONTRIBUTOR,"@juliancanellas 
Great! Good to see that someone else actually benefits from this feature, years after it was implemented 😄 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,186169975
https://github.com/pydata/xarray/issues/1775#issuecomment-351051478,https://api.github.com/repos/pydata/xarray/issues/1775,351051478,MDEyOklzc3VlQ29tbWVudDM1MTA1MTQ3OA==,3639582,2017-12-12T13:30:06Z,2017-12-12T13:30:06Z,CONTRIBUTOR,"I got the same error when doing `ds = xr.open_dataset(url, engine='pydap')` using xarray 0.10.0,
but when i install directly from master i don't get the error. So it might have been fixed already.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,281020451
https://github.com/pydata/xarray/pull/1570#issuecomment-329829869,https://api.github.com/repos/pydata/xarray/issues/1570,329829869,MDEyOklzc3VlQ29tbWVudDMyOTgyOTg2OQ==,3639582,2017-09-15T16:19:09Z,2017-09-15T16:19:09Z,CONTRIBUTOR,Thank you too! Cool :) ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/pull/1570#issuecomment-329475573,https://api.github.com/repos/pydata/xarray/issues/1570,329475573,MDEyOklzc3VlQ29tbWVudDMyOTQ3NTU3Mw==,3639582,2017-09-14T13:05:41Z,2017-09-14T13:05:41Z,CONTRIBUTOR,"> This looks great to me!
>
>One last suggestion -- can you add a brief note about the ability to access password protected datasets in the opendap section of the docs?
http://xarray.pydata.org/en/stable/io.html#opendap

Thanks! It's cool to be able to contribute to a library i use daily.

I added some documentation, please tell me what you think. For the second example, with the NASA URS, i wanted to use a URL that points to an actual NASA dataset, but i couldn't find one that wasn't extremely long. I ended up using that one, which is for a real NASA server, but a non-existant dataset. Hope that's not too confusing. Obviously, the username and password are fake as well :) so maybe it doesn't matter.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/pull/1570#issuecomment-329160391,https://api.github.com/repos/pydata/xarray/issues/1570,329160391,MDEyOklzc3VlQ29tbWVudDMyOTE2MDM5MQ==,3639582,2017-09-13T13:02:21Z,2017-09-13T13:02:21Z,CONTRIBUTOR,"I fixed the documentation stuff and changed the test to one that uses a mock of `pydap.client.open_url`, like we talked about.

I decided against adding `open_url`s other keyword arguments to `PydapDataStore.open`, for the reasons that we discussed and since users can still instantiate their own Pydap dataset and pass that, if they really want to change those parameters.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/pull/1570#issuecomment-328967624,https://api.github.com/repos/pydata/xarray/issues/1570,328967624,MDEyOklzc3VlQ29tbWVudDMyODk2NzYyNA==,3639582,2017-09-12T19:59:51Z,2017-09-12T20:02:20Z,CONTRIBUTOR,"Thank you for the fast review! 

> but if there are a few other optional keyword arguments to complete the function signature, then sure, that would be fine. I would definitely avoid using **kwargs, because that precludes the ability for us to add other xarray specific options at some point in the future.

One of the reasons i was unsure about adding the other keyword arguments, is that I'm not entirely sure if changing any of them from their default values will break the interface with xarray. But i guess you could argue that if users are changing these parameters, they probably know what they are doing.

Then there's also the `timeout` parameter, for which I think we will need to import some module within pydap just to get `DEFAULT_TIMEOUT`. That seems a bit awkward? We could also just leave that one out.

I definitely see your point with **kwargs, I had a feeling that would be a bad idea.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/issues/1068#issuecomment-327413829,https://api.github.com/repos/pydata/xarray/issues/1068,327413829,MDEyOklzc3VlQ29tbWVudDMyNzQxMzgyOQ==,3639582,2017-09-06T08:30:22Z,2017-09-06T08:30:22Z,CONTRIBUTOR,"Thank you @shoyer, I'll start work on the implementation.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,186169975
https://github.com/pydata/xarray/issues/1068#issuecomment-327179289,https://api.github.com/repos/pydata/xarray/issues/1068,327179289,MDEyOklzc3VlQ29tbWVudDMyNzE3OTI4OQ==,3639582,2017-09-05T13:43:55Z,2017-09-05T13:43:55Z,CONTRIBUTOR,"@shoyer @jenfly Has this been implemented? I can't see any open PRs relating to this, so I guess no one is working on it?

I would be happy to try and implement it, if that's fine with you? It seems like you settled on the solution of passing a session object to a PydapDataStore and then passing that to open_dataset(), correct?

Thanks in advance!","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,186169975