html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5871#issuecomment-958130347,https://api.github.com/repos/pydata/xarray/issues/5871,958130347,IC_kwDOAMm_X845G-ir,31640292,2021-11-02T20:11:23Z,2021-11-02T20:11:23Z,CONTRIBUTOR,"> the new |-operator

`from __future__ import annotations` does not actually directly enable the use of `|` for union, it changes the semantics of type annotations to [postpone evaluation](https://www.python.org/dev/peps/pep-0563/). In particular, you can then put just about anything in the type annotation without having any runtime behavior:

```python
from __future__ import annotations
def foo(bar: print('hi')) -> None: pass
```

This is separate from [PEP 604](https://www.python.org/dev/peps/pep-0604/) which actually does change the syntax.

Tools like mypy will catch obvious errors like the above, and support `|` if they are versioned sufficiently, but it's probably not a good idea to change unless you're certain that postponing evaluation is correct (Python itself has [delayed](https://mail.python.org/archives/list/python-dev@python.org/thread/CLVXXPQ2T2LQ5MP2Y53VVQFCXYWQJHKZ/) making this the default to resolve some other issues). ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240
https://github.com/pydata/xarray/issues/5164#issuecomment-821233500,https://api.github.com/repos/pydata/xarray/issues/5164,821233500,MDEyOklzc3VlQ29tbWVudDgyMTIzMzUwMA==,31640292,2021-04-16T14:53:03Z,2021-04-16T14:53:48Z,CONTRIBUTOR,"I've been able to confirm locally that the problem is caused by the call to `filters` here
https://github.com/pydata/xarray/blob/18ed29e4086145c29fde31c9d728a939536911c9/xarray/backends/netCDF4_.py#L395-L399

The line is even commented to say it is netcdf4 specific, but it is called unconditionally. I wrapped it in a try/except and then the file loaded, so I think this may just be an oversight in the backend","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,859065068
https://github.com/pydata/xarray/issues/5164#issuecomment-820630936,https://api.github.com/repos/pydata/xarray/issues/5164,820630936,MDEyOklzc3VlQ29tbWVudDgyMDYzMDkzNg==,31640292,2021-04-15T18:11:58Z,2021-04-15T18:11:58Z,CONTRIBUTOR,"> hdf4

Yes, the only mention I can find of hdf4 for xarray relies on PyNIO, which has been discontinued. If netCDF4 can open the raw file, I'm not sure why xarray can't","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,859065068
https://github.com/pydata/xarray/issues/4955#issuecomment-785734038,https://api.github.com/repos/pydata/xarray/issues/4955,785734038,MDEyOklzc3VlQ29tbWVudDc4NTczNDAzOA==,31640292,2021-02-25T08:59:52Z,2021-02-25T08:59:52Z,CONTRIBUTOR,"> Did you mean? (Notice the `x.x`)

Yes, my bad","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,816016031
https://github.com/pydata/xarray/pull/4582#issuecomment-727279860,https://api.github.com/repos/pydata/xarray/issues/4582,727279860,MDEyOklzc3VlQ29tbWVudDcyNzI3OTg2MA==,31640292,2020-11-14T23:23:33Z,2020-11-14T23:23:33Z,CONTRIBUTOR,"I've added test cases for the 3 main numpy floats (16, 32, and 64 bit). In particular they are testing the rounding behavior, which differs if they are matched in the `elif` clauses versus if they are just cast using `str()`","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,742656246
https://github.com/pydata/xarray/issues/4575#issuecomment-726921555,https://api.github.com/repos/pydata/xarray/issues/4575,726921555,MDEyOklzc3VlQ29tbWVudDcyNjkyMTU1NQ==,31640292,2020-11-13T17:57:48Z,2020-11-13T17:57:48Z,CONTRIBUTOR,"> 
> Yes, I think you could change
> 
> https://github.com/pydata/xarray/blob/b76a13f042571d01ca07461f13125a030f7297ea/xarray/core/formatting.py#L144
> 
> to `np.issubdtype(x, np.floating)` so it formats all floats.

This seems simple enough and fixes the main issue I was facing. I may look into the more extensible changes later if I have time, they would still be nice to have.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,741200389