html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/655#issuecomment-156863563,https://api.github.com/repos/pydata/xarray/issues/655,156863563,MDEyOklzc3VlQ29tbWVudDE1Njg2MzU2Mw==,315810,2015-11-15T22:18:13Z,2015-11-15T22:18:13Z,NONE,"Oh, sorry. LGTM.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,116349205
https://github.com/pydata/xarray/pull/655#issuecomment-155884053,https://api.github.com/repos/pydata/xarray/issues/655,155884053,MDEyOklzc3VlQ29tbWVudDE1NTg4NDA1Mw==,315810,2015-11-11T19:21:01Z,2015-11-11T19:21:01Z,NONE,"> The only safe times to assume a diverging colormap is when vmin = -vmax or when center is not None. If you want a diverging colormap for other situations, you need to specify cmap in the plot call.

That's fine for xray to have that opinion. Unfortunately, I think it's going to mean the behavior is going to diverge (heh) from what happens in seaborn.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,116349205
https://github.com/pydata/xarray/pull/655#issuecomment-155820962,https://api.github.com/repos/pydata/xarray/issues/655,155820962,MDEyOklzc3VlQ29tbWVudDE1NTgyMDk2Mg==,315810,2015-11-11T15:42:15Z,2015-11-11T16:05:35Z,NONE,"That's the behavior I would want seaborn to have, but I guess @shoyer can weigh in too since it affects xray as well.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,116349205
https://github.com/pydata/xarray/pull/655#issuecomment-155819176,https://api.github.com/repos/pydata/xarray/issues/655,155819176,MDEyOklzc3VlQ29tbWVudDE1NTgxOTE3Ng==,315810,2015-11-11T15:35:16Z,2015-11-11T15:35:16Z,NONE,"I think that if nothing else than preserving some backwards compatibility, you should take the route that shoyer suggested and assume that data spanning 0 with `center` not explicitly set and at most one of the limits specified should get a diverging palette.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,116349205
https://github.com/pydata/xarray/pull/655#issuecomment-155814771,https://api.github.com/repos/pydata/xarray/issues/655,155814771,MDEyOklzc3VlQ29tbWVudDE1NTgxNDc3MQ==,315810,2015-11-11T15:23:12Z,2015-11-11T15:23:12Z,NONE,"It seems like this will use sequential logic if you set `center` to a value and only one of `vmin` or `vmax`? I would think in that case it looks like the user is asking for a diverging palette.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,116349205
https://github.com/pydata/xarray/issues/642#issuecomment-154923759,https://api.github.com/repos/pydata/xarray/issues/642,154923759,MDEyOklzc3VlQ29tbWVudDE1NDkyMzc1OQ==,315810,2015-11-09T04:54:10Z,2015-11-09T04:54:10Z,NONE,"(Also it would be nice if colormaps had some metadata indicating whether they are sequential, diverging, or qualitative, but that's really a matplotlib issue).
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,114576415
https://github.com/pydata/xarray/issues/642#issuecomment-154921317,https://api.github.com/repos/pydata/xarray/issues/642,154921317,MDEyOklzc3VlQ29tbWVudDE1NDkyMTMxNw==,315810,2015-11-09T04:48:12Z,2015-11-09T04:48:12Z,NONE,"> Seaborn currently doesn't have any notion of ""divergent"" colormaps without breakpoints (beyond explicitly providing one with the cmap argument, but that doesn't trigger the divergent colormap logic currently). To be honest, I'm not sure there's a use case for that -- the only place where I would want to default a breakpoint is around zero, which is straightforward enough to signal with center=0.

My point is, there should be a way to use `vmin`, `vmax`, and `center` together and have them all do what they are expected to.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,114576415
https://github.com/pydata/xarray/issues/642#issuecomment-154918199,https://api.github.com/repos/pydata/xarray/issues/642,154918199,MDEyOklzc3VlQ29tbWVudDE1NDkxODE5OQ==,315810,2015-11-09T04:33:15Z,2015-11-09T04:33:15Z,NONE,"For some reason I thought that was an implementation detail, although I'm having trouble pulling up a reference. Seems weird to test `is False`.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,114576415
https://github.com/pydata/xarray/issues/642#issuecomment-154918082,https://api.github.com/repos/pydata/xarray/issues/642,154918082,MDEyOklzc3VlQ29tbWVudDE1NDkxODA4Mg==,315810,2015-11-09T04:31:29Z,2015-11-09T04:31:29Z,NONE,"Also, the ideal behavior really when you are plotting a diverging colormap and have provided `vmin` and `vmax` is to change the colormap itself so the breakpoint is at the data center but the limits are as provided.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,114576415
https://github.com/pydata/xarray/issues/642#issuecomment-154915488,https://api.github.com/repos/pydata/xarray/issues/642,154915488,MDEyOklzc3VlQ29tbWVudDE1NDkxNTQ4OA==,315810,2015-11-09T04:18:52Z,2015-11-09T04:18:52Z,NONE,"> We already distinguish between center=None and center=0 inside the logic for color limits, so I don't think this would be too much worse.

I just mean practically, how do you tell the difference between `0` and `False` in Python code?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,114576415
https://github.com/pydata/xarray/issues/642#issuecomment-153125033,https://api.github.com/repos/pydata/xarray/issues/642,153125033,MDEyOklzc3VlQ29tbWVudDE1MzEyNTAzMw==,315810,2015-11-02T19:00:11Z,2015-11-02T19:00:11Z,NONE,"You could also just change the logic so that if both `vmin` and `vmax` are provided, they get used, although I'm not sure what that says about the default colormap to use.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,114576415
https://github.com/pydata/xarray/issues/642#issuecomment-153124715,https://api.github.com/repos/pydata/xarray/issues/642,153124715,MDEyOklzc3VlQ29tbWVudDE1MzEyNDcxNQ==,315810,2015-11-02T18:58:50Z,2015-11-02T18:58:50Z,NONE,"`center=False` seems like it will collide with `center=0` in surprising ways, but I agree that avoiding an additional kwarg would be ideal.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,114576415