html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/4131#issuecomment-649976161,https://api.github.com/repos/pydata/xarray/issues/4131,649976161,MDEyOklzc3VlQ29tbWVudDY0OTk3NjE2MQ==,29104956,2020-06-26T05:25:12Z,2020-06-26T05:25:12Z,NONE,Ah! Gotchya :),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,634869703
https://github.com/pydata/xarray/issues/4131#issuecomment-649974315,https://api.github.com/repos/pydata/xarray/issues/4131,649974315,MDEyOklzc3VlQ29tbWVudDY0OTk3NDMxNQ==,29104956,2020-06-26T05:20:00Z,2020-06-26T05:20:00Z,NONE,"Given that the user requested to close it, isn't it unambiguous that it should be closed?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,634869703
https://github.com/pydata/xarray/issues/4131#issuecomment-641607365,https://api.github.com/repos/pydata/xarray/issues/4131,641607365,MDEyOklzc3VlQ29tbWVudDY0MTYwNzM2NQ==,29104956,2020-06-09T22:07:42Z,2020-06-09T22:07:42Z,NONE,"Ah, gotchya. Yeah it was quite jarring to see that leaving the `open_dataset` context manager didn't produce any noticeable change in the data accessibility.
In my passing opinion, it seems like it would be best to protect people, especially those who don't understand what context managers do, from themselves and have a closed dataset raise upon being queried. This is how all ""closed"" objects behave in my experience.
I'll leave this issue open in case there is any useful discussion to host here. But feel free to close it if that is more appropriate. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,634869703
https://github.com/pydata/xarray/pull/3862#issuecomment-612146195,https://api.github.com/repos/pydata/xarray/issues/3862,612146195,MDEyOklzc3VlQ29tbWVudDYxMjE0NjE5NQ==,29104956,2020-04-10T17:58:50Z,2020-04-10T17:58:50Z,NONE,Ah! Nice! Yeah the error message led me to believe that there was no path for in-place updates.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,582708100
https://github.com/pydata/xarray/pull/3862#issuecomment-612141362,https://api.github.com/repos/pydata/xarray/issues/3862,612141362,MDEyOklzc3VlQ29tbWVudDYxMjE0MTM2Mg==,29104956,2020-04-10T17:47:14Z,2020-04-10T17:47:14Z,NONE,"> That's exactly what this change does, making assignment to IndexVariable.values an error.
Sorry, I got a bit criss-crossed between this PR and the thread in #3470.
In light of https://github.com/pydata/xarray/issues/3470#issuecomment-566214653 it seems like the next best thing would be to given `assign_coords` the optional ability to update the `DataArray`/`DataSet` in-place. Thoughts? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,582708100
https://github.com/pydata/xarray/pull/3862#issuecomment-612095122,https://api.github.com/repos/pydata/xarray/issues/3862,612095122,MDEyOklzc3VlQ29tbWVudDYxMjA5NTEyMg==,29104956,2020-04-10T15:59:41Z,2020-04-10T15:59:41Z,NONE,@dcherian @max-sixty is there a reason why this change wasn't incorporated into `values.setter`? This change blocks the ability to update coordinate values in-place. This breaks code in a more fundamental way than just requiring users to rely on `assign_coords` - it can necessitate a substantial change in code design for people who were relying on the ability to mutate coordinates. This also leads me to ask: was it really appropriate to call such a substantial breaking change only a patch? ,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,582708100