html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/7258#issuecomment-1311934208,https://api.github.com/repos/pydata/xarray/issues/7258,1311934208,IC_kwDOAMm_X85OMocA,15079414,2022-11-11T16:43:46Z,2022-11-11T16:43:46Z,CONTRIBUTOR,"Ah, I thought it might be something like that when you mentioned invariance earlier. Thanks!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1436755752
https://github.com/pydata/xarray/issues/7258#issuecomment-1311928206,https://api.github.com/repos/pydata/xarray/issues/7258,1311928206,IC_kwDOAMm_X85OMm-O,15079414,2022-11-11T16:36:47Z,2022-11-11T16:36:47Z,CONTRIBUTOR,"@headtr1ck would you mind explaining a bit more what the complaint was? I had string keys and `str` is hashable, so still a bit confused.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1436755752
https://github.com/pydata/xarray/issues/7258#issuecomment-1304560538,https://api.github.com/repos/pydata/xarray/issues/7258,1304560538,IC_kwDOAMm_X85NwgOa,15079414,2022-11-05T14:48:12Z,2022-11-05T14:58:08Z,CONTRIBUTOR,"Yes mypy is pleased with `encoding: dict[Hashable, dict[str, Any]]` (or if pass `encoding` as dict literal instead of creating a variable beforehand).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1436755752
https://github.com/pydata/xarray/pull/7033#issuecomment-1246053125,https://api.github.com/repos/pydata/xarray/issues/7033,1246053125,IC_kwDOAMm_X85KRUMF,15079414,2022-09-13T23:31:26Z,2022-09-13T23:31:26Z,CONTRIBUTOR,"Some thoughts:
* I am not too sure about the short description for `join='override'` that I added for `Dataset.merge()`.
* Looks like there is a `compat='minimal'` option as well that is not documented.
* If this is desired, I would also change to single quoted strings wrapped in ``` `` ``` for the option descriptions","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1372114101
https://github.com/pydata/xarray/issues/6935#issuecomment-1221124556,https://api.github.com/repos/pydata/xarray/issues/6935,1221124556,IC_kwDOAMm_X85IyOHM,15079414,2022-08-19T22:04:29Z,2022-08-21T18:00:23Z,CONTRIBUTOR,"Also I see the `xr.merge()` one has a different order between the set of options and the descriptions, could fix that too.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1344847532
https://github.com/pydata/xarray/issues/6565#issuecomment-1146190475,https://api.github.com/repos/pydata/xarray/issues/6565,1146190475,IC_kwDOAMm_X85EUXqL,15079414,2022-06-03T17:13:20Z,2022-06-03T17:13:32Z,CONTRIBUTOR,"Some references:
* not listed in [array API attributes](https://data-apis.org/array-api/latest/API_specification/array_object.html#attributes)
* documented [in numpy](https://numpy.org/doc/stable/reference/generated/numpy.ndarray.nbytes.html)
* slightly documented [in dask](https://docs.dask.org/en/stable/generated/dask.array.Array.nbytes.html)
* slightly more documented [in cupy](https://docs.cupy.dev/en/stable/reference/generated/cupy.ndarray.html#cupy.ndarray.nbytes)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223227817
https://github.com/pydata/xarray/issues/6565#issuecomment-1115545322,https://api.github.com/repos/pydata/xarray/issues/6565,1115545322,IC_kwDOAMm_X85Cfd7q,15079414,2022-05-03T02:01:57Z,2022-05-03T02:01:57Z,CONTRIBUTOR,"Also, I guess it is pretty self-explanatory, but perhaps some documentation could be added, maybe at least a reference to `numpy.ndarray.nbytes`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223227817
https://github.com/pydata/xarray/issues/4114#issuecomment-1103009167,https://api.github.com/repos/pydata/xarray/issues/4114,1103009167,IC_kwDOAMm_X85BvpWP,15079414,2022-04-19T19:25:44Z,2022-04-19T20:37:34Z,CONTRIBUTOR,"Thanks @max-sixty. ~~I think~~ it was with `%matplotlib widget` (ipympl) that I got the behavior I described. With `%matplotlib inline` (default inline backend) the figures get closed[^1] at the end of a cell, so the two plot commands would have to be in the same cell to get an overlay, which is fine. But with ipympl, this is not the case so you have to be more careful.
Example
[^1]: You can disable this behavior with `%config InlineBackend.close_figures=False` and get an overlay from plot commands in separate cells, but then you have to manually refresh the plot it seems.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,627805952
https://github.com/pydata/xarray/issues/6063#issuecomment-991053314,https://api.github.com/repos/pydata/xarray/issues/6063,991053314,IC_kwDOAMm_X847EkYC,15079414,2021-12-10T15:13:03Z,2021-12-10T15:13:03Z,CONTRIBUTOR,"Sorry, not sure. I don't *recall* noticing it before.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1076378062
https://github.com/pydata/xarray/issues/5337#issuecomment-845599419,https://api.github.com/repos/pydata/xarray/issues/5337,845599419,MDEyOklzc3VlQ29tbWVudDg0NTU5OTQxOQ==,15079414,2021-05-21T02:06:41Z,2021-05-21T02:11:38Z,CONTRIBUTOR,"Yeah, having a kwarg that is noted to be specifically for the `hue` variable could make it more clear. It doesn't seem like the Dataset plot methods need to have both `cmap` and `colors`. They could be replaced by one, like `palette`, or keep just `colors`? But I guess with `colors` and `levels` you can make colormaps on the fly, which is convenient. And this does work for `plot.scatter`, but the `hue` variable has to be numeric.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,894819396
https://github.com/pydata/xarray/pull/5285#issuecomment-843176731,https://api.github.com/repos/pydata/xarray/issues/5285,843176731,MDEyOklzc3VlQ29tbWVudDg0MzE3NjczMQ==,15079414,2021-05-18T13:34:43Z,2021-05-18T13:34:43Z,CONTRIBUTOR,@dcherian @keewis any comments/suggestions on the currently unresolved comments? Or is this good to go?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,883153591
https://github.com/pydata/xarray/pull/5285#issuecomment-840705544,https://api.github.com/repos/pydata/xarray/issues/5285,840705544,MDEyOklzc3VlQ29tbWVudDg0MDcwNTU0NA==,15079414,2021-05-13T17:17:35Z,2021-05-13T17:17:35Z,CONTRIBUTOR,"> Can we avoid the signature changes, seems like it creates more trouble than it solves.
I can put the positional `ax` args back for now, but I do think it would be better not to have in the signature, since it makes it look like you have to provide `ax`. The `_plot2d` deals with this by modifying the signature to hide it, but `_dsplot` doesn't. I do think it is unlikely that many users were using `ax` positionally, especially since this is never done in the examples, but it is certainly possible.
The positional `u`, `v` in `dataset_plot.scatter` were not used so I think that change is ok?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,883153591
https://github.com/pydata/xarray/pull/5293#issuecomment-840693659,https://api.github.com/repos/pydata/xarray/issues/5293,840693659,MDEyOklzc3VlQ29tbWVudDg0MDY5MzY1OQ==,15079414,2021-05-13T16:57:42Z,2021-05-13T16:57:42Z,CONTRIBUTOR,"@dcherian in some sense this is a ""user visible change"", but quite minor. I wasn't sure if I should have added to *What's New* or not.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,890235341
https://github.com/pydata/xarray/pull/5285#issuecomment-840644935,https://api.github.com/repos/pydata/xarray/issues/5285,840644935,MDEyOklzc3VlQ29tbWVudDg0MDY0NDkzNQ==,15079414,2021-05-13T15:37:57Z,2021-05-13T15:37:57Z,CONTRIBUTOR,"The RTD is failing with
```
Sphinx parallel build error:
nbsphinx.NotebookError: UndefinedError in examples/ERA5-GRIB-example.ipynb:
'nbformat.notebooknode.NotebookNode object' has no attribute 'tags'
```
Doesn't seem like it would be related to this PR, but it was passing before...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,883153591
https://github.com/pydata/xarray/pull/5285#issuecomment-840534009,https://api.github.com/repos/pydata/xarray/issues/5285,840534009,MDEyOklzc3VlQ29tbWVudDg0MDUzNDAwOQ==,15079414,2021-05-13T12:51:16Z,2021-05-13T12:51:16Z,CONTRIBUTOR,"Thanks @mathause for the review.
> Looks good overall. There are two things I am unsure about:
>
> 1. You change the signature of `ds.plot.scatter` etc.. I think that's a worthwhile change but it needs a deprecation cycle - unless I am missing something? I'd suggest not doing that here but in a new PR. (I am also not entirely sure how to best do it...).
Yes, I suppose it would break it for anyone who was using `ax` positionally, but I am pretty sure no xarray docs examples do this, and I feel that the precedent from pandas, etc. is that `ax` is a kwarg.
> 2. I see the `matplotlib:` part of some of the references for the first time (e.g. `` py:meth:`matplotlib:matplotlib.figure.Figure.add_subplot\` ``) - this is used very inconsistently (already before). I am not sure what's correct.
It works both ways (I've been building locally to check things), but I can certainly add in the `matplotlib:`s if you would like. I suppose that makes it more clear that it is an external name, not part of xarray.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,883153591
https://github.com/pydata/xarray/pull/5176#issuecomment-822675523,https://api.github.com/repos/pydata/xarray/issues/5176,822675523,MDEyOklzc3VlQ29tbWVudDgyMjY3NTUyMw==,15079414,2021-04-19T18:18:01Z,2021-04-19T18:18:01Z,CONTRIBUTOR,"> I agree with @zmoon that other API pages might benefit from these links, too, as long as we remember to sufficiently describe the link so the entry is still useful in text mode.
@keewis just wondering, did you see [my comments](https://github.com/pydata/xarray/pull/5176#discussion_r615436804)?. It doesn't matter in this case, but it might be relevant in others.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860274641
https://github.com/pydata/xarray/pull/5163#issuecomment-821716121,https://api.github.com/repos/pydata/xarray/issues/5163,821716121,MDEyOklzc3VlQ29tbWVudDgyMTcxNjEyMQ==,15079414,2021-04-16T23:08:33Z,2021-04-16T23:58:54Z,CONTRIBUTOR,"Currently renders like this, which I don't think is intended.
numpydoc *See Also* section is really intended for references to code; it is taking `http` as the identifier (and linking to Python std lib's http package).
Edit: [looks like](https://github.com/pydata/xarray/blame/master/doc/user-guide/io.rst#L826) there is an `.. _io.zarr:` anchor, so ``:ref:`io.zarr` `` should work? (or ``:doc:`io` `` for just the page)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,859020732