html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/627#issuecomment-808802157,https://api.github.com/repos/pydata/xarray/issues/627,808802157,MDEyOklzc3VlQ29tbWVudDgwODgwMjE1Nw==,1322974,2021-03-27T21:04:20Z,2021-03-27T21:04:20Z,CONTRIBUTOR,"I have not used xarray recently, so I have no opinion there.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,111795064 https://github.com/pydata/xarray/issues/627#issuecomment-468911836,https://api.github.com/repos/pydata/xarray/issues/627,468911836,MDEyOklzc3VlQ29tbWVudDQ2ODkxMTgzNg==,1322974,2019-03-02T11:24:39Z,2019-03-02T11:24:39Z,CONTRIBUTOR,"I don't know whether it's pandas or xarray's fault, but the behavior is definitely still present.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,111795064 https://github.com/pydata/xarray/issues/627#issuecomment-459157183,https://api.github.com/repos/pydata/xarray/issues/627,459157183,MDEyOklzc3VlQ29tbWVudDQ1OTE1NzE4Mw==,1322974,2019-01-30T23:46:43Z,2019-01-30T23:46:43Z,CONTRIBUTOR,The bug is still valid.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,111795064 https://github.com/pydata/xarray/issues/630#issuecomment-458897417,https://api.github.com/repos/pydata/xarray/issues/630,458897417,MDEyOklzc3VlQ29tbWVudDQ1ODg5NzQxNw==,1322974,2019-01-30T10:42:17Z,2019-01-30T10:42:17Z,CONTRIBUTOR,"Looks like the implicit nan-filling behavior is not present anymore, which likely killed the issue?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,112253425 https://github.com/pydata/xarray/issues/712#issuecomment-458306269,https://api.github.com/repos/pydata/xarray/issues/712,458306269,MDEyOklzc3VlQ29tbWVudDQ1ODMwNjI2OQ==,1322974,2019-01-28T21:21:45Z,2019-01-28T21:21:45Z,CONTRIBUTOR,"I don't know anything about the internals of xarray, and to be honest I rarely use it anymore. The issue remains valid (which is why I posted the reply above), but it's not going to be the end of the world if you close it as wontfix.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,125708367 https://github.com/pydata/xarray/issues/712#issuecomment-458084627,https://api.github.com/repos/pydata/xarray/issues/712,458084627,MDEyOklzc3VlQ29tbWVudDQ1ODA4NDYyNw==,1322974,2019-01-28T10:56:27Z,2019-01-28T10:56:27Z,CONTRIBUTOR,"The issue is still relevant. For the record, the repro code is now (e.g.) ``` In [4]: from collections import * ...: import numpy as np ...: from xarray import * ...: ...: d1 = DataArray(np.empty((2, 2)), coords=OrderedDict([(""foo"", [0, 1]), (""bar"", [0, 1])]), dims=[""foo"", ""bar""]) ...: d2 = DataArray(np.empty((2, 2)), coords=OrderedDict([(""bar"", [0, 1]), (""foo"", [0, 1])]), dims=[""bar"", ""foo""]) ...: ...: ds = Dataset({""d1"": d1, ""d2"": d2}) ...: ...: print(ds.d1) ...: print(ds.d2) array([[4.665651e-310, 0.000000e+000], [4.940656e-324, nan]]) Coordinates: * foo (foo) int64 0 1 * bar (bar) int64 0 1 array([[4.66565e-310, 0.00000e+000], [4.94066e-324, nan]]) Coordinates: * foo (foo) int64 0 1 * bar (bar) int64 0 1 ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,125708367 https://github.com/pydata/xarray/issues/712#issuecomment-211207635,https://api.github.com/repos/pydata/xarray/issues/712,211207635,MDEyOklzc3VlQ29tbWVudDIxMTIwNzYzNQ==,1322974,2016-04-18T05:30:31Z,2016-04-18T05:30:31Z,CONTRIBUTOR,"Requesting a reopen: this issue is present again in 0.7.2. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,125708367 https://github.com/pydata/xarray/issues/712#issuecomment-170155204,https://api.github.com/repos/pydata/xarray/issues/712,170155204,MDEyOklzc3VlQ29tbWVudDE3MDE1NTIwNA==,1322974,2016-01-08T23:24:33Z,2016-01-08T23:24:33Z,CONTRIBUTOR,"Awesome, thanks. Any plans for a release soon? Feel free to close the issue. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,125708367 https://github.com/pydata/xarray/issues/659#issuecomment-156925589,https://api.github.com/repos/pydata/xarray/issues/659,156925589,MDEyOklzc3VlQ29tbWVudDE1NjkyNTU4OQ==,1322974,2015-11-16T06:10:25Z,2015-11-16T06:10:25Z,CONTRIBUTOR,"Perhaps worth mentioning in the docs? The difference turned out to be a major bottleneck in my code. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,117039129 https://github.com/pydata/xarray/issues/659#issuecomment-156917053,https://api.github.com/repos/pydata/xarray/issues/659,156917053,MDEyOklzc3VlQ29tbWVudDE1NjkxNzA1Mw==,1322974,2015-11-16T05:14:50Z,2015-11-16T05:14:50Z,CONTRIBUTOR,"In my case I could just switch to pandas, so I'll leave it as it is for now. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,117039129 https://github.com/pydata/xarray/issues/630#issuecomment-152269091,https://api.github.com/repos/pydata/xarray/issues/630,152269091,MDEyOklzc3VlQ29tbWVudDE1MjI2OTA5MQ==,1322974,2015-10-29T18:07:54Z,2015-10-29T18:07:54Z,CONTRIBUTOR,"> If you put arrays in a Dataset, you should not count on modifications to the arrays in the Dataset trickling back to the original arrays. I think the most confusing part is that this the modifications will trickle down _sometimes_ -- even though I'd prefer them to be always propagated, I would still mind much less if they were never propagated. At the end of the day it's not my call, feel free to close the issue if you want. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,112253425 https://github.com/pydata/xarray/issues/630#issuecomment-152105174,https://api.github.com/repos/pydata/xarray/issues/630,152105174,MDEyOklzc3VlQ29tbWVudDE1MjEwNTE3NA==,1322974,2015-10-29T07:49:23Z,2015-10-29T07:49:23Z,CONTRIBUTOR,"Sorry to raise the issue again but I just noticed that I had a couple of other places where I wrote quite naturally ``` d = DataArray(...) e = DataArray(...) ds = Dataset({""d"": d, ""e"": e}) ``` which is equivalent to the form I was mentioning earlier (whether `ds` will actually get initialized properly depends on whether `d` and `e` have exactly matching coordinates). To be honest I don't really understand what you mean by ""Unfortunately, it's impossible to make such automatically aligned arrays views in general, because of numpy's memory model."": when the line `ds = Dataset(...)` gets executed, the ndarrays `ds.d.values` and `ds.e.values` either point to the old ndarrays `d.values` and `e.values` or to some newly created, coordinate-aligned ndarrays. If it is the latter, one can just modify `d.values` and `e.values` (as well as their coordinates systems) to point to the new ndarrays, right? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,112253425 https://github.com/pydata/xarray/issues/630#issuecomment-150044109,https://api.github.com/repos/pydata/xarray/issues/630,150044109,MDEyOklzc3VlQ29tbWVudDE1MDA0NDEwOQ==,1322974,2015-10-21T22:37:56Z,2015-10-21T22:37:56Z,CONTRIBUTOR,"Thinking about it again, I think there could just be a mention in the docs that the pattern ``` foo = dataset[key] = DataArray(...) ``` should be avoided and written as ``` dataset[key] = DataArray(...) foo = dataset[key] ``` That should be good enough? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,112253425 https://github.com/pydata/xarray/issues/630#issuecomment-149990310,https://api.github.com/repos/pydata/xarray/issues/630,149990310,MDEyOklzc3VlQ29tbWVudDE0OTk5MDMxMA==,1322974,2015-10-21T18:45:57Z,2015-10-21T18:45:57Z,CONTRIBUTOR,"""If you use the DataArray constructor instead of inserting an item in a Dataset, the array values will always be a view."" Can you explain what you mean here? I am using the DataArray constructor and then inserting the item in the Dataset. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,112253425 https://github.com/pydata/xarray/issues/630#issuecomment-149590758,https://api.github.com/repos/pydata/xarray/issues/630,149590758,MDEyOklzc3VlQ29tbWVudDE0OTU5MDc1OA==,1322974,2015-10-20T14:49:55Z,2015-10-20T14:50:09Z,CONTRIBUTOR,"I was more expecting that if the coordinates are _not_ already aligned, then the DataArray gets modified to point to the ""larger"" array (though of course there may be issues with other variables pointing to the same array, etc.). I like the pattern ``` some_explicit_dict_name[some_explicit_entry_name] = tmpvar = np.array(...) <... work work work on initializing tmpvar, expecting to initialize some_explicit_dict_name[some_explicit_entry_name]> ``` (because the explicit name is a bit too long to work with and I make it immediately clear what `tmpvar` is used for), but xray's behavior makes this work (on DataArrays) only sometimes, with no warning that this could fail to update the array I care about. Not sure what the best approach is. Perhaps ``` tmpvar = dataset.new_dataarray(*args_and_**kwargs_to_DataArray.__init__) ``` which would make sure that no one else is pointing to the internal array at that point? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,112253425 https://github.com/pydata/xarray/issues/627#issuecomment-148803581,https://api.github.com/repos/pydata/xarray/issues/627,148803581,MDEyOklzc3VlQ29tbWVudDE0ODgwMzU4MQ==,1322974,2015-10-16T18:44:51Z,2015-10-16T18:44:51Z,CONTRIBUTOR,"object arrays look fine to me, but I don't have a strong opinion either. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,111795064