html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/2710#issuecomment-589133779,https://api.github.com/repos/pydata/xarray/issues/2710,589133779,MDEyOklzc3VlQ29tbWVudDU4OTEzMzc3OQ==,10720577,2020-02-20T15:35:22Z,2020-02-20T15:35:22Z,CONTRIBUTOR,"Yes, @TomNicholas. My PR got merged but I forgot to close the issue -- closing it now. Thanks for checking. ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,403326458
https://github.com/pydata/xarray/pull/2936#issuecomment-491032096,https://api.github.com/repos/pydata/xarray/issues/2936,491032096,MDEyOklzc3VlQ29tbWVudDQ5MTAzMjA5Ng==,10720577,2019-05-09T19:19:12Z,2019-05-09T19:19:12Z,CONTRIBUTOR,"@shoyer, I spent sometime looking into it and it looks like the test fails for the shallow copy, and apparently only on Windows for some reason. In Windows coords seem to be immutable unless it's one dataarray deep copied from another (which is why only the `deep=False` test fails). So I decided to just mark the tests as `xfail` for now (but I'd be happy to create an issue and look into it more in the future).
I'll open a new PR marking the tests with `xfail` shortly.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329
https://github.com/pydata/xarray/pull/2936#issuecomment-490967152,https://api.github.com/repos/pydata/xarray/issues/2936,490967152,MDEyOklzc3VlQ29tbWVudDQ5MDk2NzE1Mg==,10720577,2019-05-09T16:08:07Z,2019-05-09T16:08:07Z,CONTRIBUTOR,"Sure. I'm looking into it now.
Sorry about that.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329
https://github.com/pydata/xarray/pull/2936#issuecomment-489878553,https://api.github.com/repos/pydata/xarray/issues/2936,489878553,MDEyOklzc3VlQ29tbWVudDQ4OTg3ODU1Mw==,10720577,2019-05-07T02:07:14Z,2019-05-07T02:07:14Z,CONTRIBUTOR,"Yep, the tests are back now.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329
https://github.com/pydata/xarray/pull/2936#issuecomment-489818753,https://api.github.com/repos/pydata/xarray/issues/2936,489818753,MDEyOklzc3VlQ29tbWVudDQ4OTgxODc1Mw==,10720577,2019-05-06T23:05:20Z,2019-05-06T23:05:20Z,CONTRIBUTOR,"> @pletchm thanks for the PR!
>
> I think the test failuers are dependencies rather than your changes! I kicked off a build of master here: https://travis-ci.org/pydata/xarray/builds/524754660 to confirm - if it's the same failures then we'll know it's not this code
Thanks for looking into this, @max-sixty! It looks like the errors are the same, so the problem is dependencies, right? How do we go about fixing that?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329
https://github.com/pydata/xarray/pull/2936#issuecomment-488862083,https://api.github.com/repos/pydata/xarray/issues/2936,488862083,MDEyOklzc3VlQ29tbWVudDQ4ODg2MjA4Mw==,10720577,2019-05-02T23:00:07Z,2019-05-02T23:00:07Z,CONTRIBUTOR,"Tests and documentation forthcoming. I had already opened a PR, but was perplexed when the build and tests weren't passing -- suspected it was related to my commits.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329
https://github.com/pydata/xarray/pull/2930#issuecomment-488853081,https://api.github.com/repos/pydata/xarray/issues/2930,488853081,MDEyOklzc3VlQ29tbWVudDQ4ODg1MzA4MQ==,10720577,2019-05-02T22:21:28Z,2019-05-02T22:21:28Z,CONTRIBUTOR,"I'm perplexed by why the build and tests are failing on this. I'm going to try 3 things:
1) Make a new branch from master and PR (making sure my fork master is synced up with the upstream master) to see if the tests/build pass without any additional commits
2) Commit my non-test changes and see if the build/tests pass
3) Commit my tests and see if the build/tests pass
Then I'll rebase my 2 commits into 1 commit.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438537597
https://github.com/pydata/xarray/issues/2710#issuecomment-485544371,https://api.github.com/repos/pydata/xarray/issues/2710,485544371,MDEyOklzc3VlQ29tbWVudDQ4NTU0NDM3MQ==,10720577,2019-04-22T20:39:17Z,2019-04-22T20:39:17Z,CONTRIBUTOR,"> Another solution could be adding support for `da.sel(dim1='a', squeeze=False)` to avoid losing the `dim1` dimension/coordinate in the first place
Or equivalently, you could just do
```
da.sel(dim1=['a'])
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,403326458
https://github.com/pydata/xarray/issues/1463#issuecomment-482696887,https://api.github.com/repos/pydata/xarray/issues/1463,482696887,MDEyOklzc3VlQ29tbWVudDQ4MjY5Njg4Nw==,10720577,2019-04-12T19:35:04Z,2019-04-12T19:35:04Z,CONTRIBUTOR,I'd like to take a shot fixing this bug unless someone else already is working on it. Would that be alright?,"{""total_count"": 2, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 2, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,237807730
https://github.com/pydata/xarray/pull/2757#issuecomment-476250173,https://api.github.com/repos/pydata/xarray/issues/2757,476250173,MDEyOklzc3VlQ29tbWVudDQ3NjI1MDE3Mw==,10720577,2019-03-25T15:32:53Z,2019-03-25T15:32:53Z,CONTRIBUTOR,"@shoyer, `dim_kwargs` is no longer allowed to be used for python 3.5. Does anything else need to change in this PR?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,408340215
https://github.com/pydata/xarray/pull/2757#issuecomment-467540238,https://api.github.com/repos/pydata/xarray/issues/2757,467540238,MDEyOklzc3VlQ29tbWVudDQ2NzU0MDIzOA==,10720577,2019-02-26T17:46:00Z,2019-02-26T17:46:00Z,CONTRIBUTOR,"Hi @shoyer and @fujiisoup, I believe I've made all of the updates that you suggested in your comments. How is the PR looking now?
Thank you!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,408340215
https://github.com/pydata/xarray/issues/2710#issuecomment-458730514,https://api.github.com/repos/pydata/xarray/issues/2710,458730514,MDEyOklzc3VlQ29tbWVudDQ1ODczMDUxNA==,10720577,2019-01-29T22:19:58Z,2019-01-29T22:19:58Z,CONTRIBUTOR,"Oh I see what you're saying. Yeah, that makes sense.
To get the equivalent of `da.expand_dims(a=[9, 10, 11])`, you'd do
```
>>> new = da.expand_dims(a=3)
>>> new
<xarray.DataArray (a: 3, b: 5, c: 3)>
...
Coordinates:
* b (b) int64 0 1 2 3 4
* c (c) int64 0 1 2
Dimensions without coordinates: a
>>> new[""a""] = [9, 10, 11]
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,403326458
https://github.com/pydata/xarray/issues/2710#issuecomment-458638827,https://api.github.com/repos/pydata/xarray/issues/2710,458638827,MDEyOklzc3VlQ29tbWVudDQ1ODYzODgyNw==,10720577,2019-01-29T17:49:55Z,2019-01-29T17:49:55Z,CONTRIBUTOR,"Those _would_ be equivalent, I think, assuming they're both manipulating the same `da` object (I meant for them to be separate calls not sequential, but even if they were sequential, `expand_dims` doesn't and wouldn't alter `da`, but instead return a new xarray object). I edited my above post to clarify what `da` is.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,403326458
https://github.com/pydata/xarray/issues/2710#issuecomment-458609172,https://api.github.com/repos/pydata/xarray/issues/2710,458609172,MDEyOklzc3VlQ29tbWVudDQ1ODYwOTE3Mg==,10720577,2019-01-29T16:32:36Z,2019-01-29T17:44:25Z,CONTRIBUTOR,"Hi,
Thanks for replying. I see what you mean about the 2 separate features.
Would it be alright if I opened a PR sometime soon that upgraded `expand_dims` to support the inserting/broadcasting dimensions with size > 1 (the first feature)?
I would use your suggested API, i.e. not requiring explicit coordinate names -- that makes sense. However, it feels like the dimension kwargs (i.e. the new dimension/dimensions), should be allowed to be given implicit or explicit coordinates, in case the user doesn't want 0-based integer coordinates for the new dimension. For example,
```
da.expand_dims(a=3)
```
is equivalent to
```
da.expand_dims(a=[0, 1, 2])
```
but this will also work
```
da.expand_dims(a=['w', 'x', 'y', 'z'])
```
where `da` is
```
>>> coords = {""b"": range(5), ""c"": range(3)}
>>> da = xr.DataArray(np.ones([5, 3]), coords=coords, dims=list(coords.keys()))
>>> da
<xarray.DataArray (b: 5, c: 3)>
array([[1., 1., 1.],
[1., 1., 1.],
[1., 1., 1.],
[1., 1., 1.],
[1., 1., 1.]])
Coordinates:
* b (b) int64 0 1 2 3 4
* c (c) int64 0 1 2
````
Does that make sense?
Thank you!
Martin","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,403326458