html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5776#issuecomment-914756364,https://api.github.com/repos/pydata/xarray/issues/5776,914756364,IC_kwDOAMm_X842hhMM,41898282,2021-09-08T01:07:55Z,2021-09-27T15:14:49Z,CONTRIBUTOR,"## Unit Test Results
         6 files  ±0           6 suites  ±0   1h 1m 57s :stopwatch: ±0s
16 227 tests ±0  14 492 :heavy_check_mark: ±0  1 735 :zzz: ±0  0 :x: ±0 
90 558 runs  ±0  82 384 :heavy_check_mark: ±0  8 174 :zzz: ±0  0 :x: ±0 

Results for commit 19ab40ee. ± Comparison against base commit 19ab40ee.

:recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,990509161
https://github.com/pydata/xarray/pull/5776#issuecomment-927943749,https://api.github.com/repos/pydata/xarray/issues/5776,927943749,IC_kwDOAMm_X843T0xF,10194086,2021-09-27T14:43:27Z,2021-09-27T14:43:27Z,MEMBER,Thanks @znicholls!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,990509161
https://github.com/pydata/xarray/pull/5776#issuecomment-927943455,https://api.github.com/repos/pydata/xarray/issues/5776,927943455,IC_kwDOAMm_X843T0sf,10194086,2021-09-27T14:43:11Z,2021-09-27T14:43:11Z,MEMBER,I'm also happy - so let's merge!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,990509161
https://github.com/pydata/xarray/pull/5776#issuecomment-927232092,https://api.github.com/repos/pydata/xarray/issues/5776,927232092,IC_kwDOAMm_X843RHBc,23625371,2021-09-26T04:59:24Z,2021-09-26T04:59:24Z,CONTRIBUTOR,"> The only other thing this needs is a test to check that the error is raised with the correct message (i.e. `pytest.raises(TypeError, match=""may fix this issue"")`

I believe that's covered by https://github.com/pydata/xarray/blob/ec2657bfc1a426aa3559243b02ecf48de6673506/xarray/tests/test_combine.py#L1109 (i.e. no change is needed to the existing code)","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,990509161
https://github.com/pydata/xarray/pull/5776#issuecomment-927108350,https://api.github.com/repos/pydata/xarray/issues/5776,927108350,IC_kwDOAMm_X843Qoz-,23625371,2021-09-25T11:35:37Z,2021-09-25T11:35:37Z,CONTRIBUTOR,"Alrighty updated, see what you think","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,990509161
https://github.com/pydata/xarray/pull/5776#issuecomment-914762048,https://api.github.com/repos/pydata/xarray/issues/5776,914762048,IC_kwDOAMm_X842hilA,23625371,2021-09-08T01:13:06Z,2021-09-08T01:13:06Z,CONTRIBUTOR,"We could try and tighten this up in a few ways (I'm not sure how much effort it is worth):

- only talk about cf_time if the error is in the time dimension (or if one of the types is `cftime.datetime`)
- only talk about cf_time if the function which tried to do the combining actually has this argument (e.g. `combine_by_coords` doesn't have `use_cftime`, only `open_mfdataset` does so the current implementation could be confusing), to do this I'd use a try except block further up the stack rather than altering the message in `_ensure_same_types`

Thoughts @mathause and @TomNicholas ?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,990509161