html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5763#issuecomment-912390733,https://api.github.com/repos/pydata/xarray/issues/5763,912390733,IC_kwDOAMm_X842YfpN,41898282,2021-09-03T09:17:10Z,2021-10-24T10:56:33Z,CONTRIBUTOR,"## Unit Test Results
6 files 6 suites 53m 30s [:stopwatch:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""duration of all tests"")
16 209 tests 14 462 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""passed tests"") 1 736 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""skipped / disabled tests"") 11 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""failed tests"")
90 450 runs 82 204 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""passed tests"") 8 180 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""skipped / disabled tests"") 66 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""failed tests"")
For more details on these failures, see [this check](https://github.com/pydata/xarray/runs/3988500012).
Results for commit 8ecbb390.
:recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,987559143
https://github.com/pydata/xarray/pull/5763#issuecomment-912376483,https://api.github.com/repos/pydata/xarray/issues/5763,912376483,IC_kwDOAMm_X842YcKj,24736507,2021-09-03T08:55:22Z,2021-10-24T10:33:03Z,NONE,"Hello @dschwoerer! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
* In the file [`xarray/plot/utils.py`](https://github.com/pydata/xarray/blob/8ecbb390acd51ab3b06de9f4edf21b08dd3fa384/xarray/plot/utils.py):
> [Line 4:1](https://github.com/pydata/xarray/blob/8ecbb390acd51ab3b06de9f4edf21b08dd3fa384/xarray/plot/utils.py#L4): [F401](https://duckduckgo.com/?q=pep8%20F401) 'datetime.datetime' imported but unused
##### Comment last updated at 2021-10-24 10:33:03 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,987559143
https://github.com/pydata/xarray/pull/5763#issuecomment-912724289,https://api.github.com/repos/pydata/xarray/issues/5763,912724289,IC_kwDOAMm_X842ZxFB,14371165,2021-09-03T18:19:02Z,2021-09-03T18:19:02Z,MEMBER,"What would you expect the plot to look like if you input a complex number or a multiindex along the x-axis?
I think I would expect it to be shown like a flattened array. And you can kind of get away with that if you cast the arrays to string before hand.
```python
x = 1j * np.arange(0, 5)
y = np.arange(5, 10)
plt.plot(x, y)
ComplexWarning: Casting complex values to real discards the imaginary part
return np.asarray(x, float)
```
```python
x = 1j * np.arange(0, 5)
y = np.arange(5, 10)
plt.plot(np.vectorize(str)(x), y)
```
```python
x = 1j + np.arange(0, 5)
y = np.arange(5, 10)
plt.plot(np.vectorize(str)(x), y)
```
```python
import pandas as pd
arrays = [[1, 1, 2, 2], ['red', 'blue', 'red', 'blue']]
a = pd.MultiIndex.from_arrays(arrays, names=('number', 'color')).to_numpy()
b = np.arange(4, 8)
plt.plot(np.vectorize(str)(a), b)
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,987559143
https://github.com/pydata/xarray/pull/5763#issuecomment-912707634,https://api.github.com/repos/pydata/xarray/issues/5763,912707634,IC_kwDOAMm_X842ZtAy,2448579,2021-09-03T17:50:20Z,2021-09-03T17:50:20Z,MEMBER,"The error for multiindex plotting is not very informative ""setting array element with sequence"" so I would still keep `_ensure_plottable` to raise a nice error for that.
for the tests that now work, we should check that the output is reasonable, so I wouldn't delete them","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,987559143
https://github.com/pydata/xarray/pull/5763#issuecomment-912630631,https://api.github.com/repos/pydata/xarray/issues/5763,912630631,IC_kwDOAMm_X842ZaNn,5637662,2021-09-03T15:40:59Z,2021-09-03T15:40:59Z,CONTRIBUTOR,"I think there are several options:
1. remove the offending tests (simple)
2. reintroduce `_ensure_plottable` but only check for multiindex. This has still the issue that it might at some point be possible, and the tests need to be changed and `_ensure_plottable` needs to be changed
3. Change the test to check for any error. This basically just means we are checking it isn't working, which I see only limited value in.
Which of these options would you prefer?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,987559143
https://github.com/pydata/xarray/pull/5763#issuecomment-912620738,https://api.github.com/repos/pydata/xarray/issues/5763,912620738,IC_kwDOAMm_X842ZXzC,2448579,2021-09-03T15:26:02Z,2021-09-03T15:26:02Z,MEMBER,"Thanks @dschwoerer This makes sense to me.
A lot of failed tests are checking for the raised error. We will need to update these to make sure the plotting worked.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,987559143