html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/5755#issuecomment-918073632,https://api.github.com/repos/pydata/xarray/issues/5755,918073632,IC_kwDOAMm_X842uLEg,4160723,2021-09-13T10:53:16Z,2021-09-13T10:53:16Z,MEMBER,Thank you very much @max-sixty and @Illviljan for looking into this and for the PR!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,985162305
https://github.com/pydata/xarray/issues/5755#issuecomment-910464045,https://api.github.com/repos/pydata/xarray/issues/5755,910464045,IC_kwDOAMm_X842RJQt,14371165,2021-09-01T16:45:47Z,2021-09-01T17:08:14Z,MEMBER,"Before T_Dataset etc. was:
https://github.com/pydata/xarray/blob/d58a5114ccc8656e83d8a31eebf720548f004f86/xarray/core/_typed_ops.pyi#L20-L22
 
Now it is:
https://github.com/pydata/xarray/blob/6b59d9a5058adb8de1661f49bc273aa78d6de7de/xarray/core/types.py#L20-L22

This seems fixable by adding back
https://github.com/pydata/xarray/blob/d58a5114ccc8656e83d8a31eebf720548f004f86/xarray/core/_typed_ops.pyi#L19-L22

What I wonder about is why we called it `T_Dataset` instead of `T_DatasetOpsMixin`?
Is it a trick to make it look good in docs or?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,985162305
https://github.com/pydata/xarray/issues/5755#issuecomment-910480241,https://api.github.com/repos/pydata/xarray/issues/5755,910480241,IC_kwDOAMm_X842RNNx,14371165,2021-09-01T17:05:57Z,2021-09-01T17:05:57Z,MEMBER,"> 
> 
> > What I wonder about is why we called it `T_Dataset` instead of `T_DatasetOpsMixin`?
> > Is it a trick to make it look good in docs or?
> 
> The goal was for the type that's used throughout Xarray to be called `T_Dataset`, but not sure why that means we have to change the definition — I don't think there's a good reason.
> 
> Should we change that back, and change the mypy file files definition to `.py[i]`?

Agreed and maybe add a comment/TODO why it's called `T_Dataset` instead of `T_DatasetOpsMixin` if there is any reason.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,985162305
https://github.com/pydata/xarray/issues/5755#issuecomment-910467901,https://api.github.com/repos/pydata/xarray/issues/5755,910467901,IC_kwDOAMm_X842RKM9,5635139,2021-09-01T16:50:56Z,2021-09-01T16:50:56Z,MEMBER,"> What I wonder about is why we called it `T_Dataset` instead of `T_DatasetOpsMixin`?
> Is it a trick to make it look good in docs or?

The goal was for the type that's used throughout Xarray to be called `T_Dataset`, but not sure why that means we have to change the definition — I don't think there's a good reason.

Should we change that back, and change the mypy file files definition to `.py[i]`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,985162305
https://github.com/pydata/xarray/issues/5755#issuecomment-910464246,https://api.github.com/repos/pydata/xarray/issues/5755,910464246,IC_kwDOAMm_X842RJT2,5635139,2021-09-01T16:46:03Z,2021-09-01T16:47:01Z,MEMBER,"Edit: @Illviljan and I commented at the same time, he seems to have found the error!

---
Great spot @benbovy . I think what's happening is that the standard run only checks `.py` files, rather than `.pyi` files. So `mypy .` collects it, but pre-commit and `mypy` doesn't.

ref https://github.com/pre-commit/mirrors-mypy/issues/33 for the pre-commit issue.

On the errors themselves — @rhkleijn I think I have upset your magnum opus despite the best of intentions. If you're up for having a look, that would be great. Otherwise we could try and revert my original PR, though I worry this sort of refactor is difficult to revert.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,985162305