html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/504#issuecomment-126922669,https://api.github.com/repos/pydata/xarray/issues/504,126922669,MDEyOklzc3VlQ29tbWVudDEyNjkyMjY2OQ==,5356122,2015-08-01T14:44:50Z,2015-08-01T14:44:50Z,MEMBER,"Looks good. Merge?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98274024
https://github.com/pydata/xarray/pull/504#issuecomment-126824906,https://api.github.com/repos/pydata/xarray/issues/504,126824906,MDEyOklzc3VlQ29tbWVudDEyNjgyNDkwNg==,5356122,2015-07-31T22:11:03Z,2015-07-31T22:11:03Z,MEMBER,"I was thinking about only allowing it to work only if the array has exactly matching coordinates. Which would be the case in (4) `a[(x > 0) & (y > 0)]`. But then it would be difficult to stay consistent in the 1d case- mask or select?

> My sense is that we'll probably be happier if we have entirely distinct APIs for masking (.where) and 
> selection ([] and .loc[]).

That's a concrete and easy to understand distinction. I'm convinced.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98274024
https://github.com/pydata/xarray/pull/504#issuecomment-126810402,https://api.github.com/repos/pydata/xarray/issues/504,126810402,MDEyOklzc3VlQ29tbWVudDEyNjgxMDQwMg==,5356122,2015-07-31T20:56:31Z,2015-07-31T20:56:31Z,MEMBER,"Right. Consider following pandas rather than numpy here:

```
In [9]: a = pd.DataFrame(np.random.randn(3, 4))

In [10]: a
Out[10]:
          0         1         2         3
0 -1.188669  0.055286 -0.476962  0.144261
1  1.779646  2.332629  0.326515 -0.179862
2 -0.016739  1.221892 -0.032720 -0.779563

In [11]: a[a < 0]
Out[11]:
          0   1         2         3
0 -1.188669 NaN -0.476962       NaN
1       NaN NaN       NaN -0.179862
2 -0.016739 NaN -0.032720 -0.779563
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98274024
https://github.com/pydata/xarray/pull/504#issuecomment-126779995,https://api.github.com/repos/pydata/xarray/issues/504,126779995,MDEyOklzc3VlQ29tbWVudDEyNjc3OTk5NQ==,5356122,2015-07-31T18:41:29Z,2015-07-31T18:41:29Z,MEMBER,"Agreed- if `a[a < 0] = 0` works then `a[a < 0]` should work also.

Both R and pandas allow the user to do `a[a < 0]` and  `a[a < 0] = 0`. So what I'm wondering is why not extend xray's indexing to also work on arrays that are the same shape and have the same labels as the original array?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98274024
https://github.com/pydata/xarray/pull/504#issuecomment-126771341,https://api.github.com/repos/pydata/xarray/issues/504,126771341,MDEyOklzc3VlQ29tbWVudDEyNjc3MTM0MQ==,5356122,2015-07-31T17:57:01Z,2015-07-31T17:57:01Z,MEMBER,"Here's something related that one can do in Numpy- replace all negative entries with 0.

```
In [15]: a = np.arange(-5, 5).reshape(2, 5)

In [16]: a
Out[16]:
array([[-5, -4, -3, -2, -1],
       [ 0,  1,  2,  3,  4]])

In [17]: a[a < 0] = 0

In [18]: a
Out[18]:
array([[0, 0, 0, 0, 0],
       [0, 1, 2, 3, 4]])
```

Would it be possible to modify `__getitem__` for this common use case?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98274024
https://github.com/pydata/xarray/pull/504#issuecomment-126768529,https://api.github.com/repos/pydata/xarray/issues/504,126768529,MDEyOklzc3VlQ29tbWVudDEyNjc2ODUyOQ==,5356122,2015-07-31T17:45:32Z,2015-07-31T17:45:32Z,MEMBER,"Checking if I understand- this exists in line 79 of ops.py

```
where = _dask_or_eager_func('where')
```

so this PR is to expose it in the users API?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98274024
https://github.com/pydata/xarray/pull/504#issuecomment-126756775,https://api.github.com/repos/pydata/xarray/issues/504,126756775,MDEyOklzc3VlQ29tbWVudDEyNjc1Njc3NQ==,5356122,2015-07-31T17:19:56Z,2015-07-31T17:19:56Z,MEMBER,"Plot makes for a compelling example.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,98274024