html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5735#issuecomment-905044121,https://api.github.com/repos/pydata/xarray/issues/5735,905044121,IC_kwDOAMm_X8418eCZ,41898282,2021-08-24T23:34:06Z,2021-09-01T15:31:44Z,CONTRIBUTOR,"## Unit Test Results
6 files ±0 6 suites ±0 53m 40s :stopwatch: ±0s
16 225 tests ±0 14 491 :heavy_check_mark: ±0 1 734 :zzz: ±0 0 :x: ±0
90 546 runs ±0 82 370 :heavy_check_mark: ±0 8 176 :zzz: ±0 0 :x: ±0
Results for commit 96c56836. ± Comparison against base commit 96c56836.
:recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,978473315
https://github.com/pydata/xarray/pull/5735#issuecomment-910373230,https://api.github.com/repos/pydata/xarray/issues/5735,910373230,IC_kwDOAMm_X842QzFu,2448579,2021-09-01T15:03:26Z,2021-09-01T15:03:26Z,MEMBER,"RTD failure is in plotting.rst which is unrelated.
Thanks @mgrover1. I see this is your first contribution here. Welcome to xarray!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,978473315
https://github.com/pydata/xarray/pull/5735#issuecomment-905913845,https://api.github.com/repos/pydata/xarray/issues/5735,905913845,IC_kwDOAMm_X841_yX1,26660300,2021-08-25T22:17:30Z,2021-08-25T22:17:30Z,CONTRIBUTOR,"@dcherian - I found the issue... those lines doing the subsetting were missing the `time = ` section... below is the adjusted syntax
```python
ds.isel(time = (ds.time.dt.month == 1))
ds.isel(time = (ds.time.dt.month.isin([1, 2, 3])))
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,978473315
https://github.com/pydata/xarray/pull/5735#issuecomment-905869910,https://api.github.com/repos/pydata/xarray/issues/5735,905869910,IC_kwDOAMm_X841_npW,26660300,2021-08-25T20:59:51Z,2021-08-25T20:59:51Z,CONTRIBUTOR,"@dcherian I tried to run it locally, it makes it 98% of the way through, and gets hung up on Dask... I followed the contributors guide instructions","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,978473315
https://github.com/pydata/xarray/pull/5735#issuecomment-905863765,https://api.github.com/repos/pydata/xarray/issues/5735,905863765,IC_kwDOAMm_X841_mJV,2448579,2021-08-25T20:49:56Z,2021-08-25T20:49:56Z,MEMBER,"The docs build failure is real
```
RuntimeError: Non Expected exception in `/home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/5735/doc/user-guide/time-series.rst` line 177
```
we have instructions on building the docs locally here: https://xarray.pydata.org/en/stable/contributing.html#how-to-build-the-xarray-documentation","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,978473315
https://github.com/pydata/xarray/pull/5735#issuecomment-905020588,https://api.github.com/repos/pydata/xarray/issues/5735,905020588,IC_kwDOAMm_X8418YSs,26660300,2021-08-24T22:32:38Z,2021-08-24T22:32:38Z,CONTRIBUTOR,Ohh.. neat! Yeah - I can add those few lines instead.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,978473315
https://github.com/pydata/xarray/pull/5735#issuecomment-905019129,https://api.github.com/repos/pydata/xarray/issues/5735,905019129,IC_kwDOAMm_X8418X75,2448579,2021-08-24T22:29:00Z,2021-08-24T22:29:00Z,MEMBER,"oh oops
for a single month
```
ds.isel(ds.time.dt.month == 1)
```
for multiple months
```
ds.isel(ds.time.dt.month.isin([1, 2, 3]))
```
using groupby's new getitem method
```
ds.groupby(""time.month"")[1]
```
I think we want to encourage the first two; since groupby does a bunch of extra work.
I think we can add an indexing subsection under ""Datetime components"" showing the first two and link to that from the section you just edited.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,978473315
https://github.com/pydata/xarray/pull/5735#issuecomment-905014382,https://api.github.com/repos/pydata/xarray/issues/5735,905014382,IC_kwDOAMm_X8418Wxu,26660300,2021-08-24T22:18:00Z,2021-08-24T22:18:00Z,CONTRIBUTOR,">
> I think this is clearer and potentially faster
>
> ```python
> ds.isel(time=ds.time.dt.month.isin([1]))
> ```
>
> I noticed that this is not mentioned in the docs for [indexing using `isin`](https://xarray.pydata.org/en/stable/user-guide/indexing.html#selecting-values-with-isin) so you could update that too if you're up for it.
I can add that example to the `isin` section... Within the example of looking at multiple months, the approach I included seemed more straight forward... what would subsetting for multiple months look like with using `isin`?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,978473315
https://github.com/pydata/xarray/pull/5735#issuecomment-904991280,https://api.github.com/repos/pydata/xarray/issues/5735,904991280,IC_kwDOAMm_X8418RIw,2448579,2021-08-24T21:31:58Z,2021-08-24T21:31:58Z,MEMBER,"Thanks @mgrover1
I think this is clearer and potentially faster
``` python
ds.isel(time=ds.time.dt.month.isin([1]))
```
I noticed that this is not mentioned in the docs for [indexing using ``isin``](https://xarray.pydata.org/en/stable/user-guide/indexing.html#selecting-values-with-isin) so you could update that too if you're up for it.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,978473315