html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5716#issuecomment-901946960,https://api.github.com/repos/pydata/xarray/issues/5716,901946960,IC_kwDOAMm_X841wp5Q,41898282,2021-08-19T14:08:12Z,2021-09-05T00:04:22Z,CONTRIBUTOR,"## Unit Test Results
         6 files  ±0           6 suites  ±0   50m 28s :stopwatch: ±0s
16 227 tests ±0  14 493 :heavy_check_mark: ±0  1 734 :zzz: ±0  0 :x: ±0 
90 558 runs  ±0  82 382 :heavy_check_mark: ±0  8 176 :zzz: ±0  0 :x: ±0 

Results for commit 9dbeb6bc. ± Comparison against base commit 9dbeb6bc.

:recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,974659059
https://github.com/pydata/xarray/pull/5716#issuecomment-904437683,https://api.github.com/repos/pydata/xarray/issues/5716,904437683,IC_kwDOAMm_X8416J-z,76039838,2021-08-24T08:33:50Z,2021-08-24T08:33:50Z,CONTRIBUTOR,"Awesome, thanks @dcherian and all the reviewers!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,974659059
https://github.com/pydata/xarray/pull/5716#issuecomment-902581059,https://api.github.com/repos/pydata/xarray/issues/5716,902581059,IC_kwDOAMm_X841zEtD,76039838,2021-08-20T10:00:04Z,2021-08-20T10:39:40Z,CONTRIBUTOR,"Thank you @Illviljan @max-sixty 
I've changed the return type to `FrozenDict` and added a check to make sure that `set_options` changes are reflected in `get_options`.

Edit: All unit tests are passing on my local PC but there's one failure in the github checks. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,974659059
https://github.com/pydata/xarray/pull/5716#issuecomment-902286066,https://api.github.com/repos/pydata/xarray/issues/5716,902286066,IC_kwDOAMm_X841x8ry,5635139,2021-08-19T22:13:32Z,2021-08-19T22:13:32Z,MEMBER,"This looks good., thanks @pkopparla  Thanks for reviewing @Illviljan .

Agree re a test — at least to just test it runs, albeit trivial. 

`FrozenDict` would be better, though I think fine to do in another PR. We could return `dict(OPTIONS)` if we're worried people will attempt to set invalid values.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,974659059
https://github.com/pydata/xarray/pull/5716#issuecomment-902010417,https://api.github.com/repos/pydata/xarray/issues/5716,902010417,IC_kwDOAMm_X841w5Yx,14371165,2021-08-19T15:27:44Z,2021-08-19T15:27:44Z,MEMBER,"The returned dict should be read only, otherwise you can bypass all the validation checks that's done in `set_options`. I think you can use `FrozenDict` for that:
https://github.com/pydata/xarray/blob/56cc0778d5edcb0173425b5850b834457c790210/xarray/core/utils.py#L476
Not sure if FrozenDict propagates the typing though, once OPTIONS is typed.

We probably need to make sure that `get_options` is updated if `set_options` has been used. A test for that would be nice.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,974659059