html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5710#issuecomment-900336483,https://api.github.com/repos/pydata/xarray/issues/5710,900336483,IC_kwDOAMm_X841qgtj,41898282,2021-08-17T14:14:49Z,2021-08-18T03:02:25Z,CONTRIBUTOR,"## Unit Test Results
6 files ±0 6 suites ±0 54m 46s :stopwatch: ±0s
16 217 tests ±0 14 483 :heavy_check_mark: ±0 1 733 :zzz: ±0 1 :x: ±0
90 498 runs ±0 82 319 :heavy_check_mark: ±0 8 173 :zzz: ±0 6 :x: ±0
For more details on these failures, see [this check](https://github.com/pydata/xarray/runs/3357118207).
Results for commit de867e61. ± Comparison against base commit de867e61.
:recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,972720354
https://github.com/pydata/xarray/pull/5710#issuecomment-900406087,https://api.github.com/repos/pydata/xarray/issues/5710,900406087,IC_kwDOAMm_X841qxtH,14371165,2021-08-17T15:37:53Z,2021-08-17T15:37:53Z,MEMBER,I like the idea of moving this to `test_label_from_attrs` seems to be a lot of similar tests there.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,972720354
https://github.com/pydata/xarray/pull/5710#issuecomment-900402671,https://api.github.com/repos/pydata/xarray/issues/5710,900402671,IC_kwDOAMm_X841qw3v,14808389,2021-08-17T15:33:34Z,2021-08-17T15:34:38Z,MEMBER,"> Can we skip this entire file if `matplotlib` is not installed?
I would say we can because at the moment plotting requires `matplotlib` to be installed. That might change with the introduction of plotting backends (e.g. #3640), but then we'd probably have to refactor the tests (*and* `xarray.plot`), anyways.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,972720354
https://github.com/pydata/xarray/pull/5710#issuecomment-900393258,https://api.github.com/repos/pydata/xarray/issues/5710,900393258,IC_kwDOAMm_X841qukq,2448579,2021-08-17T15:22:19Z,2021-08-17T15:22:19Z,MEMBER,"Sorry, my mistake. I should've manually checked the min deps test too.
1. Can we skip this entire file if `matplotlib` is not installed? cc @keewis
2. If not we can just put that test in here:
https://github.com/pydata/xarray/blob/41099669c63c7dbb51b112fdec09dfae07379fe7/xarray/tests/test_plot.py#L166","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,972720354
https://github.com/pydata/xarray/pull/5710#issuecomment-900390905,https://api.github.com/repos/pydata/xarray/issues/5710,900390905,IC_kwDOAMm_X841qt_5,14371165,2021-08-17T15:19:25Z,2021-08-17T15:19:25Z,MEMBER,"I only saw the sparse errors on your PR as well. It's rough when you can't trust the CI results.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,972720354
https://github.com/pydata/xarray/pull/5710#issuecomment-900384483,https://api.github.com/repos/pydata/xarray/issues/5710,900384483,IC_kwDOAMm_X841qsbj,13205162,2021-08-17T15:11:23Z,2021-08-17T15:11:23Z,CONTRIBUTOR,"On my end I think this idea is fine! Although I don't really understand why matplotlib would be needed for that test in the first place.
Sorry to have inadvertently introduced a failing test.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,972720354
https://github.com/pydata/xarray/pull/5710#issuecomment-900370243,https://api.github.com/repos/pydata/xarray/issues/5710,900370243,IC_kwDOAMm_X841qo9D,14371165,2021-08-17T14:54:40Z,2021-08-17T14:54:40Z,MEMBER,"@dcherian Is this solution fine or do you have a better idea how to turn off `test_all_figures_closed` for this function?
CC @tomchor","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,972720354