html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5682#issuecomment-899947392,https://api.github.com/repos/pydata/xarray/issues/5682,899947392,IC_kwDOAMm_X841pBuA,13205162,2021-08-17T02:33:45Z,2021-08-17T02:33:45Z,CONTRIBUTOR,"> That's unrelated, see #5654
Ah, I see. Thanks for merging!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,963239311
https://github.com/pydata/xarray/pull/5682#issuecomment-899943472,https://api.github.com/repos/pydata/xarray/issues/5682,899943472,IC_kwDOAMm_X841pAww,13205162,2021-08-17T02:22:01Z,2021-08-17T02:22:01Z,CONTRIBUTOR,"> Looks great. I'll merge when tests pass.
>
> Thanks @tomchor. I see this is your first PR here. Welcome to xarray!
Thanks!
I think you spoke too soon though haha. One of the tests is failing and I don't really know why! I never touched the `test_chunk()` function...:
```
=========================== short test summary info ============================
FAILED xarray/tests/test_sparse.py::test_chunk - TypeError: operand type(s) a...
= 1 failed, 13681 passed, 1110 skipped, 225 xfailed, 67 xpassed, 212 warnings in 445.02s (0:07:25) =
**PNC:/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/PseudoNetCDF/pncwarn.py:24:UserWarning:
pyproj could not be found, so IO/API coordinates cannot be converted to lat/lon; to fix, install pyproj or basemap (e.g., `pip install pyproj)`
Error: Process completed with exit code 1.
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,963239311
https://github.com/pydata/xarray/pull/5682#issuecomment-899085600,https://api.github.com/repos/pydata/xarray/issues/5682,899085600,IC_kwDOAMm_X841lvUg,13205162,2021-08-15T17:32:23Z,2021-08-15T17:32:23Z,CONTRIBUTOR,"> @tomchor thanks. Yes all you need to do is define a test function that checks something and pytest will run it.
>
> you can run it following the instructions here: https://xarray.pydata.org/en/stable/contributing.html#running-the-test-suite
>
> (something like this)
>
> ```
> pytest xarray/tests/test_utils.py -k test_latex_name_isnt_split
> ```
Thanks! This makes it much easier to test everything locally. I test the new test locally and it should pass now.
I also saw that `test_chunk()` isn't passing and I don't know why. Also I can't run that test locally for some reason.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,963239311
https://github.com/pydata/xarray/pull/5682#issuecomment-897160926,https://api.github.com/repos/pydata/xarray/issues/5682,897160926,IC_kwDOAMm_X841eZbe,13205162,2021-08-11T21:17:26Z,2021-08-11T21:17:26Z,CONTRIBUTOR,"I defined a function that tests that a long latex sequence stays intact after going through `label_from_attrs()`, but I'm not sure if that's the same as _adding the test_. It seems from the Pytest docs that you don't need to call the function explicitly; just define it. In which case that do the trick.
@dcherian could you please confirm?
Also the tests weren't passing before I added this last commit, and I have no idea why.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,963239311
https://github.com/pydata/xarray/pull/5682#issuecomment-894882015,https://api.github.com/repos/pydata/xarray/issues/5682,894882015,IC_kwDOAMm_X841VtDf,13205162,2021-08-09T00:27:12Z,2021-08-09T00:27:12Z,CONTRIBUTOR,"> I wonder if it will look best if we avoid splitting inside the latex code?
> `name`, `extra` and `units` can have latex as well so I think we need to handle the entire `name+extra+units` string somehow.
>
> I was playing around a little with regex but I didn't get that far:
>
> ```python
> import textwrap
> import re
>
> name = r""$Ra_s = \mathrm{mean}(\epsilon_k) / \mu M^2_\infty$""
> extra = ""Longwinded comments about something confusing. ""
> units = r""$[N / m]$""
> label_raw = name + extra + units
> label_notex = re.sub(""\$(.+?)\$"", ""X "", label_raw, flags=re.DOTALL)
> label_notex_wrap = textwrap.wrap(label_notex, 30)
> label_tex_wrap = ... # regex to add back the latex strings.
> ```
>
> There might very well be a simpler way of doing this.
I couldn't figure out any way to avoid splitting LaTeX code. I suspect that the way to do it might be kind of complex (but I'm happy if someone can prove me wrong). We can also increase the number of columns for the latex option even more to maintain simplicity...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,963239311