html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/5678#issuecomment-902287190,https://api.github.com/repos/pydata/xarray/issues/5678,902287190,IC_kwDOAMm_X841x89W,5635139,2021-08-19T22:15:34Z,2021-08-19T22:17:14Z,MEMBER,"Thanks @Illviljan ! Please feel free to add a whatsnew in another PR, maybe as a batch for some of your PRs :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,962647570 https://github.com/pydata/xarray/pull/5678#issuecomment-902287027,https://api.github.com/repos/pydata/xarray/issues/5678,902287027,IC_kwDOAMm_X841x86z,5635139,2021-08-19T22:15:15Z,2021-08-19T22:15:15Z,MEMBER,"This looks really good! I didn't know about `Literal`, TIL. We could use that in more places too, I guess.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,962647570 https://github.com/pydata/xarray/pull/5678#issuecomment-894545722,https://api.github.com/repos/pydata/xarray/issues/5678,894545722,IC_kwDOAMm_X841Ua86,5635139,2021-08-06T22:17:16Z,2021-08-06T22:17:16Z,MEMBER,"Yeah, we had similar issues in https://github.com/pydata/xarray/pull/5624 But I think it's fine if it's messy for now given there's a clear path to clean it up when we move to 3.8.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,962647570 https://github.com/pydata/xarray/pull/5678#issuecomment-894446124,https://api.github.com/repos/pydata/xarray/issues/5678,894446124,IC_kwDOAMm_X841UCos,5635139,2021-08-06T18:35:59Z,2021-08-06T18:35:59Z,MEMBER,"As long as it passes mypy on 3.7, I think that's fine. If we're not sure, it's worth confirming that it does pass, either locally or adding a `pre-commit` task...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,962647570 https://github.com/pydata/xarray/pull/5678#issuecomment-894373712,https://api.github.com/repos/pydata/xarray/issues/5678,894373712,IC_kwDOAMm_X841Tw9Q,5635139,2021-08-06T16:26:37Z,2021-08-06T16:26:37Z,MEMBER,"This looks cool! You're ahead of me on the new python features @Illviljan ! Any thoughts before we merge?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,962647570