html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5662#issuecomment-1003205657,https://api.github.com/repos/pydata/xarray/issues/5662,1003205657,IC_kwDOAMm_X847y7QZ,14371165,2021-12-30T22:56:42Z,2021-12-30T22:56:42Z,MEMBER,I'll merge this in a couple of days unless someone minds.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,957439114
https://github.com/pydata/xarray/pull/5662#issuecomment-904159594,https://api.github.com/repos/pydata/xarray/issues/5662,904159594,IC_kwDOAMm_X8415GFq,14371165,2021-08-23T21:54:35Z,2021-08-23T21:54:35Z,MEMBER,"The `2` is not aligned with `(coord39)` because the Attributes part doesn't use `col_width` as input.
Dimensions, Coordinates and Data variables uses it, but not attrs for some reason.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,957439114
https://github.com/pydata/xarray/pull/5662#issuecomment-904000203,https://api.github.com/repos/pydata/xarray/issues/5662,904000203,IC_kwDOAMm_X8414fLL,14371165,2021-08-23T18:13:54Z,2021-08-23T18:13:54Z,MEMBER,"It was easy enough to change so here's how it would look like with one of these extreme datasets:
Original:
```python
Dimensions: (coord0: 2, coord1: 2, coord2: 2, coord3: 2, coord4: 2,
coord5: 2, coord6: 2, coord7: 2, coord8: 2, coord9: 2,
coord10: 2, coord11: 2, coord12: 2, coord13: 2, coord14: 2,
coord15: 2, coord16: 2, coord17: 2, coord18: 2, coord19: 2,
coord20: 2, coord21: 2, coord22: 2, coord23: 2, coord24: 2,
coord25: 2, coord26: 2, coord27: 2, coord28: 2, coord29: 2,
coord30: 2, coord31: 2, coord32: 2, coord33: 2, coord34: 2,
coord35: 2, coord36: 2, coord37: 2, coord38: 2, coord39: 2)
Coordinates: (12/40)
* coord0 (coord0) int32 0 1
* coord1 (coord1) int32 0 1
* coord2 (coord2) int32 0 1
* coord3 (coord3) int32 0 1
* coord4 (coord4) int32 0 1
* coord5 (coord5) int32 0 1
...
* coord34 (coord34) int32 0 1
* coord35 (coord35) int32 0 1
* coord36 (coord36) int32 0 1
* coord37 (coord37) int32 0 1
* coord38 (coord38) int32 0 1
* coord39 (coord39) int32 0 1
Data variables: (12/40)
long_name0 (coord0) int32 3 4
long_name1 (coord1) int32 3 4
long_name2 (coord2) int32 3 4
long_name3 (coord3) int32 3 4
long_name4 (coord4) int32 3 4
long_name5 (coord5) int32 3 4
...
long_name34 (coord34) int32 3 4
long_name35 (coord35) int32 3 4
long_name36 (coord36) int32 3 4
long_name37 (coord37) int32 3 4
long_name38 (coord38) int32 3 4
long_name39 (coord39) int32 3 4
Attributes: (12/30)
attr_0: 2
attr_1: 2
attr_2: 2
attr_3: 2
attr_4: 2
attr_5: 2
...
attr_24: 2
attr_25: 2
attr_26: 2
attr_27: 2
attr_28: 2
attr_29: 2
```
New line with some indent:
```python
Dimensions:
(coord0: 2, coord1: 2, coord2: 2, coord3: 2, coord4: 2, coord5: 2,
coord6: 2, coord7: 2, coord8: 2, coord9: 2, coord10: 2, coord11: 2,
coord12: 2, coord13: 2, coord14: 2, coord15: 2, coord16: 2, coord17: 2,
coord18: 2, coord19: 2, coord20: 2, coord21: 2, coord22: 2, coord23: 2,
coord24: 2, coord25: 2, coord26: 2, coord27: 2, coord28: 2, coord29: 2,
coord30: 2, coord31: 2, coord32: 2, coord33: 2, coord34: 2, coord35: 2,
coord36: 2, coord37: 2, coord38: 2, coord39: 2)
Coordinates: (12/40)
* coord0 (coord0) int32 0 1
* coord1 (coord1) int32 0 1
* coord2 (coord2) int32 0 1
* coord3 (coord3) int32 0 1
* coord4 (coord4) int32 0 1
* coord5 (coord5) int32 0 1
...
* coord34 (coord34) int32 0 1
* coord35 (coord35) int32 0 1
* coord36 (coord36) int32 0 1
* coord37 (coord37) int32 0 1
* coord38 (coord38) int32 0 1
* coord39 (coord39) int32 0 1
Data variables: (12/40)
long_name0 (coord0) int32 3 4
long_name1 (coord1) int32 3 4
long_name2 (coord2) int32 3 4
long_name3 (coord3) int32 3 4
long_name4 (coord4) int32 3 4
long_name5 (coord5) int32 3 4
...
long_name34 (coord34) int32 3 4
long_name35 (coord35) int32 3 4
long_name36 (coord36) int32 3 4
long_name37 (coord37) int32 3 4
long_name38 (coord38) int32 3 4
long_name39 (coord39) int32 3 4
Attributes: (12/30)
attr_0: 2
attr_1: 2
attr_2: 2
attr_3: 2
attr_4: 2
attr_5: 2
...
attr_24: 2
attr_25: 2
attr_26: 2
attr_27: 2
attr_28: 2
attr_29: 2
```
No new line but small indent:
```python
Dimensions: (coord0: 2, coord1: 2, coord2: 2, coord3: 2, coord4: 2, coord5: 2,
coord6: 2, coord7: 2, coord8: 2, coord9: 2, coord10: 2, coord11: 2,
coord12: 2, coord13: 2, coord14: 2, coord15: 2, coord16: 2, coord17: 2,
coord18: 2, coord19: 2, coord20: 2, coord21: 2, coord22: 2, coord23: 2,
coord24: 2, coord25: 2, coord26: 2, coord27: 2, coord28: 2, coord29: 2,
coord30: 2, coord31: 2, coord32: 2, coord33: 2, coord34: 2, coord35: 2,
coord36: 2, coord37: 2, coord38: 2, coord39: 2)
Coordinates: (12/40)
* coord0 (coord0) int32 0 1
* coord1 (coord1) int32 0 1
* coord2 (coord2) int32 0 1
* coord3 (coord3) int32 0 1
* coord4 (coord4) int32 0 1
* coord5 (coord5) int32 0 1
...
* coord34 (coord34) int32 0 1
* coord35 (coord35) int32 0 1
* coord36 (coord36) int32 0 1
* coord37 (coord37) int32 0 1
* coord38 (coord38) int32 0 1
* coord39 (coord39) int32 0 1
Data variables: (12/40)
long_name0 (coord0) int32 3 4
long_name1 (coord1) int32 3 4
long_name2 (coord2) int32 3 4
long_name3 (coord3) int32 3 4
long_name4 (coord4) int32 3 4
long_name5 (coord5) int32 3 4
...
long_name34 (coord34) int32 3 4
long_name35 (coord35) int32 3 4
long_name36 (coord36) int32 3 4
long_name37 (coord37) int32 3 4
long_name38 (coord38) int32 3 4
long_name39 (coord39) int32 3 4
Attributes: (12/30)
attr_0: 2
attr_1: 2
attr_2: 2
attr_3: 2
attr_4: 2
attr_5: 2
...
attr_24: 2
attr_25: 2
attr_26: 2
attr_27: 2
attr_28: 2
attr_29: 2
```
I think I prefer the original one because of the alignment with the dims in coords and data variables.
The second one is nice, familiar format as Coordinates and will likely never get in to the 1 long dimension per row issue like in one of the examples. But it looks a little too dense now maybe?
This is also adds an extra row for all cases which might not be necessary with most real life datasets? Dimensions without coordinates will add 1 extra row as well.
The 3rd one was an alternative to avoid a completely breaking change like the second one is. But I think it looks the worst of these alternatives, too messy. But it's similar to how it looks like right now if the console wraps the printed text.
On another note I'm slightly annoyed that the attribute values aren't aligning the same way as coords and data variables and I cannot unsee it now. :/","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,957439114
https://github.com/pydata/xarray/pull/5662#issuecomment-895850899,https://api.github.com/repos/pydata/xarray/issues/5662,895850899,IC_kwDOAMm_X841ZZmT,14371165,2021-08-10T08:51:25Z,2021-08-10T08:51:25Z,MEMBER,">
>
> ```
> =========================== short test summary info ============================
> FAILED xarray/tests/test_formatting_html.py::test_repr_of_nonstr_dataarray - ...
> ```
>
> I'm affecting html formattings now. That seems unnecessary.
https://github.com/pydata/xarray/blob/4bb9d9c6df77137f05e85c7cc6508fe7a93dc0e4/xarray/core/formatting_html.py#L255
Seems to be this line that caused the error. I don't understand what it does though, some backup of sorts?
If it's only being used as backup when something fails I think this is ready.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,957439114
https://github.com/pydata/xarray/pull/5662#issuecomment-894158453,https://api.github.com/repos/pydata/xarray/issues/5662,894158453,IC_kwDOAMm_X841S8Z1,14371165,2021-08-06T10:13:51Z,2021-08-06T11:04:23Z,MEMBER,"Seems the `OPTIONS` dict isn't being correctly typed, mypy seems to think that `OPTIONS[""display_max_rows""]` is a object somehow.
EDIT:
This seems solvable using typeddict, https://stackoverflow.com/questions/48013561/how-to-use-static-type-checking-using-dict-with-different-value-types-in-python","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,957439114
https://github.com/pydata/xarray/pull/5662#issuecomment-894175194,https://api.github.com/repos/pydata/xarray/issues/5662,894175194,IC_kwDOAMm_X841TAfa,14371165,2021-08-06T10:47:04Z,2021-08-06T10:47:04Z,MEMBER,"```
=========================== short test summary info ============================
FAILED xarray/tests/test_formatting_html.py::test_repr_of_nonstr_dataarray - ...
```
I'm affecting html formattings now. That seems unnecessary.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,957439114