html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5630#issuecomment-885326583,https://api.github.com/repos/pydata/xarray/issues/5630,885326583,IC_kwDOAMm_X840xQL3,41898282,2021-07-23T00:35:57Z,2021-07-23T20:41:23Z,CONTRIBUTOR,"## Unit Test Results
6 files ±0 6 suites ±0 53m 18s :stopwatch: ±0s
16 200 tests ±0 14 481 :heavy_check_mark: ±0 1 719 :zzz: ±0 0 :x: ±0
90 396 runs ±0 82 236 :heavy_check_mark: ±0 8 160 :zzz: ±0 0 :x: ±0
Results for commit c5530d52. ± Comparison against base commit c5530d52.
:recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,951121126
https://github.com/pydata/xarray/pull/5630#issuecomment-885886303,https://api.github.com/repos/pydata/xarray/issues/5630,885886303,IC_kwDOAMm_X840zY1f,14808389,2021-07-23T20:06:07Z,2021-07-23T20:06:07Z,MEMBER,"@TomNicholas, since the latest commit reverted the completion of the `.update` deprecation cycle, I think it should be fine to merge this and issue the release.","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 1, ""eyes"": 0}",,951121126
https://github.com/pydata/xarray/pull/5630#issuecomment-885289891,https://api.github.com/repos/pydata/xarray/issues/5630,885289891,IC_kwDOAMm_X840xHOj,24736507,2021-07-22T23:02:23Z,2021-07-23T18:46:57Z,NONE,"Hello @keewis! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
* In the file [`xarray/tests/test_coarsen.py`](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py):
> [Line 16:1](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L16): [F401](https://duckduckgo.com/?q=pep8%20F401) '.test_dataarray.da' imported but unused
> [Line 17:1](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L17): [F401](https://duckduckgo.com/?q=pep8%20F401) '.test_dataset.ds' imported but unused
> [Line 20:36](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L20): [F811](https://duckduckgo.com/?q=pep8%20F811) redefinition of unused 'ds' from line 17
> [Line 27:26](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L27): [F811](https://duckduckgo.com/?q=pep8%20F811) redefinition of unused 'ds' from line 17
> [Line 42:25](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L42): [F811](https://duckduckgo.com/?q=pep8%20F811) redefinition of unused 'ds' from line 17
> [Line 58:5](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L58): [F811](https://duckduckgo.com/?q=pep8%20F811) redefinition of unused 'da' from line 16
> [Line 69:5](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L69): [F811](https://duckduckgo.com/?q=pep8%20F811) redefinition of unused 'da' from line 16
> [Line 91:5](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L91): [F811](https://duckduckgo.com/?q=pep8%20F811) redefinition of unused 'ds' from line 17
> [Line 160:25](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L160): [F811](https://duckduckgo.com/?q=pep8%20F811) redefinition of unused 'ds' from line 17
> [Line 191:5](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L191): [F811](https://duckduckgo.com/?q=pep8%20F811) redefinition of unused 'da' from line 16
> [Line 240:28](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L240): [F811](https://duckduckgo.com/?q=pep8%20F811) redefinition of unused 'da' from line 16
> [Line 256:5](https://github.com/pydata/xarray/blob/b4252cc006655f559b5fc27014bded01fc8232a8/xarray/tests/test_coarsen.py#L256): [F811](https://duckduckgo.com/?q=pep8%20F811) redefinition of unused 'ds' from line 17
##### Comment last updated at 2021-07-23 18:46:56 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,951121126
https://github.com/pydata/xarray/pull/5630#issuecomment-885830128,https://api.github.com/repos/pydata/xarray/issues/5630,885830128,IC_kwDOAMm_X840zLHw,14808389,2021-07-23T18:42:48Z,2021-07-23T18:43:14Z,MEMBER,"this would essentially mean that we are extending the deprecation (since code and docs should be in sync)... we did consider the wrapper object in #4932, but I think back then we decided that warning in-code was too much trouble. I'll undo the removal and push the version to `0.21`, which should give us some time to discuss what to do.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,951121126
https://github.com/pydata/xarray/pull/5630#issuecomment-885801454,https://api.github.com/repos/pydata/xarray/issues/5630,885801454,IC_kwDOAMm_X840zEHu,1217238,2021-07-23T17:50:16Z,2021-07-23T17:50:57Z,MEMBER,"I would still return something from `Dataset.update()` for now.
I agree that it would be great to remove it, but to do that perhaps we could make some of Dataset subclass that issues a warning when any method is called on it? Perhaps something like:
```python
import xarray
import warnings
class DeprecatedDatasetFromUpdate(xarray.Dataset):
__slots__ = ['_accessed']
def __init__(self, *args, **kwargs):
self._accessed = False
super().__init__(*args, **kwargs)
def __getattribute__(self, key):
if not super().__getattribute__('_accessed'):
warnings.warn(
""This xarray.Dataset was created as the return value of ""
""xarray.Dataset.update(), but update() will return None in the ""
""future"",
category=FutureWarning)
self._accessed = True
return super().__getattribute__(key)
```
But could be a little tricky to get right, so perhaps let's save this for a later PR.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,951121126
https://github.com/pydata/xarray/pull/5630#issuecomment-885795885,https://api.github.com/repos/pydata/xarray/issues/5630,885795885,IC_kwDOAMm_X840zCwt,14808389,2021-07-23T17:40:09Z,2021-07-23T17:40:09Z,MEMBER,"As far as I'm concerned this should be ready for a final review. We didn't yet decide what to do about the `Dataset.update` return value, though.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,951121126
https://github.com/pydata/xarray/pull/5630#issuecomment-885525804,https://api.github.com/repos/pydata/xarray/issues/5630,885525804,IC_kwDOAMm_X840yA0s,14808389,2021-07-23T09:49:49Z,2021-07-23T09:49:49Z,MEMBER,"thanks for the `whats-new.rst` entries, @TomNicholas","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,951121126
https://github.com/pydata/xarray/pull/5630#issuecomment-885482501,https://api.github.com/repos/pydata/xarray/issues/5630,885482501,IC_kwDOAMm_X840x2QF,10194086,2021-07-23T08:25:17Z,2021-07-23T08:25:17Z,MEMBER,"Thanks @keewis for the `keep_attrs` deprecations (and for the other as well, of course).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,951121126
https://github.com/pydata/xarray/pull/5630#issuecomment-885328729,https://api.github.com/repos/pydata/xarray/issues/5630,885328729,IC_kwDOAMm_X840xQtZ,35968931,2021-07-23T00:43:35Z,2021-07-23T01:08:42Z,MEMBER,"This is great - there is one more to remove in `combine.py` isn't there? [line 638](https://github.com/pydata/xarray/blob/deaca14295d23c021a8352e485b199318907f59b/xarray/core/combine.py#L638)
EDIT: I pushed a commit to this branch removing that one too.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,951121126
https://github.com/pydata/xarray/pull/5630#issuecomment-885298762,https://api.github.com/repos/pydata/xarray/issues/5630,885298762,IC_kwDOAMm_X840xJZK,5635139,2021-07-22T23:21:38Z,2021-07-22T23:21:38Z,MEMBER,"Excellent, thanks a lot @keewis !
Maybe it's worth merging from the command line to retain the distinct commits on main (though maybe GH saves them?)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,951121126