html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/468#issuecomment-129430727,https://api.github.com/repos/pydata/xarray/issues/468,129430727,MDEyOklzc3VlQ29tbWVudDEyOTQzMDcyNw==,1197350,2015-08-10T12:50:45Z,2015-08-10T12:50:45Z,MEMBER,"Thanks @jhamman. That's what I thought I did, but I must have screwed up and created my PR from my master branch... Anyway, this is now #524.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94508580
https://github.com/pydata/xarray/pull/468#issuecomment-129285729,https://api.github.com/repos/pydata/xarray/issues/468,129285729,MDEyOklzc3VlQ29tbWVudDEyOTI4NTcyOQ==,2443309,2015-08-10T03:00:50Z,2015-08-10T03:00:50Z,MEMBER,"Ah, yes.  Open a new PR.  You must have pushed your rebased master to your fork. 

In general, I never edit on my fork's `master` branch.  My typical workflow is to create separate `feature` branches off the `xray/xray:master` branch:

``` bash
git checkout master
git pull upstream master
git checkout -b feature/my_feature
# ...edit...
git add edited_files*
git commit ...
git push origin feature/my_feature
# create pull request from my fork's feature/my_feature to xray:master on github
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94508580
https://github.com/pydata/xarray/pull/468#issuecomment-129268785,https://api.github.com/repos/pydata/xarray/issues/468,129268785,MDEyOklzc3VlQ29tbWVudDEyOTI2ODc4NQ==,1197350,2015-08-10T01:27:34Z,2015-08-10T01:27:34Z,MEMBER,"I don't quite understand what happened here. The PR was deleted when I rebased my master branch. My feature branch still exists: https://github.com/rabernat/xray/tree/close_files

Should I just open a new PR?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94508580
https://github.com/pydata/xarray/pull/468#issuecomment-129198878,https://api.github.com/repos/pydata/xarray/issues/468,129198878,MDEyOklzc3VlQ29tbWVudDEyOTE5ODg3OA==,1197350,2015-08-09T15:28:51Z,2015-08-09T15:28:51Z,MEMBER,"No. I meant to close #522. I don't know why this was closed.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94508580
https://github.com/pydata/xarray/pull/468#issuecomment-121466384,https://api.github.com/repos/pydata/xarray/issues/468,121466384,MDEyOklzc3VlQ29tbWVudDEyMTQ2NjM4NA==,1217238,2015-07-15T02:41:07Z,2015-07-15T02:41:07Z,MEMBER,"I'm mostly curious about the performance overhead, for which I think this solution would be fine.

On Tue, Jul 14, 2015 at 7:00 PM, Ryan Abernathey notifications@github.com
wrote:

> ## I would honestly not waste too much time on this pull request. It is a messy solution. I just wanted to see if it could actually be done. (It can.)
> 
> Reply to this email directly or view it on GitHub:
> https://github.com/xray/xray/pull/468#issuecomment-121456713
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94508580
https://github.com/pydata/xarray/pull/468#issuecomment-121456713,https://api.github.com/repos/pydata/xarray/issues/468,121456713,MDEyOklzc3VlQ29tbWVudDEyMTQ1NjcxMw==,1197350,2015-07-15T02:00:37Z,2015-07-15T02:00:37Z,MEMBER,"I would honestly not waste too much time on this pull request. It is a messy solution. I just wanted to see if it could actually be done. (It can.)
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94508580
https://github.com/pydata/xarray/pull/468#issuecomment-121432105,https://api.github.com/repos/pydata/xarray/issues/468,121432105,MDEyOklzc3VlQ29tbWVudDEyMTQzMjEwNQ==,1217238,2015-07-15T00:03:28Z,2015-07-15T00:03:28Z,MEMBER,"Sorry for letting this linger... I'm going to run some tests on this later and see if I notice the same performance issues.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94508580