html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5603#issuecomment-885083060,https://api.github.com/repos/pydata/xarray/issues/5603,885083060,IC_kwDOAMm_X840wUu0,2448579,2021-07-22T17:23:15Z,2021-07-22T17:23:26Z,MEMBER,Your points about (2) being hard to interpret are a good reason to go with (1)! I was thinking it would return a DatasetRolling object but that's not the only interpretation as you point out.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,944714417
https://github.com/pydata/xarray/pull/5603#issuecomment-884313466,https://api.github.com/repos/pydata/xarray/issues/5603,884313466,IC_kwDOAMm_X840tY16,2448579,2021-07-21T16:12:52Z,2021-07-21T16:12:52Z,MEMBER,"Thanks @kmsquire we can take it from here.

There was some discussion about syntax at the dev meeting today. There were multiple votes in favour of allowing full control of padding in the rolling object itself. So we could have
1. `.rolling(time=5, x=3, pad={""x"": {""mode"": ""wrap""}, ""time"": False})`, OR
2. `.rolling(time=5, x=3).pad({""x"": {""mode"": ""wrap""}, ""time"": False})`

@pydata/xarray thoughts?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,944714417
https://github.com/pydata/xarray/pull/5603#issuecomment-883330196,https://api.github.com/repos/pydata/xarray/issues/5603,883330196,IC_kwDOAMm_X840poyU,2448579,2021-07-20T11:51:43Z,2021-07-20T11:51:43Z,MEMBER,">  However, pad has so many arguments that it might become a nightmare to thread them all through. So maybe just sticking with pad=False is ok.

We could also do `pad={""mode"": ""wrap""}` or `pad=True, pad_kwargs={...}` 

I think i prefer `.pad(time=5, mode=""wrap"").rolling(time=5, pad=False)` but it does require specifying the window length twice. I was going to bring this up at our next dev meeting (tomorrow!)

cc @pydata/xarray 

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,944714417
https://github.com/pydata/xarray/pull/5603#issuecomment-881588685,https://api.github.com/repos/pydata/xarray/issues/5603,881588685,IC_kwDOAMm_X840i_nN,2448579,2021-07-16T16:59:19Z,2021-07-16T16:59:19Z,MEMBER,Thanks @kmsquire I'll try and review this soon.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,944714417