html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/466#issuecomment-122929524,https://api.github.com/repos/pydata/xarray/issues/466,122929524,MDEyOklzc3VlQ29tbWVudDEyMjkyOTUyNA==,5356122,2015-07-20T16:07:36Z,2015-07-20T16:07:36Z,MEMBER,"@jhamman
1. The issue with `yincrease=True` as the default is that actual PNG images when loaded will be 'upside down' when plotted with xray.
2. Definitely could add support for `pcolormesh`. Went with `imshow` since it seems more common.
3. +1
4. I recently installed cartopy on a new machine with conda:
```
conda install -c scitools cartopy
```
Seems like it used an old version of matplotlib, but it still worked.
Followed their docs: http://scitools.org.uk/cartopy/docs/latest/installing.html
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-122745978,https://api.github.com/repos/pydata/xarray/issues/466,122745978,MDEyOklzc3VlQ29tbWVudDEyMjc0NTk3OA==,1217238,2015-07-20T03:20:11Z,2015-07-20T03:20:11Z,MEMBER,"Let's follow up on this with some smaller PRs.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-122686257,https://api.github.com/repos/pydata/xarray/issues/466,122686257,MDEyOklzc3VlQ29tbWVudDEyMjY4NjI1Nw==,5356122,2015-07-19T17:17:20Z,2015-07-19T17:17:20Z,MEMBER,"Sure. I'll do it separate from this PR.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-122618273,https://api.github.com/repos/pydata/xarray/issues/466,122618273,MDEyOklzc3VlQ29tbWVudDEyMjYxODI3Mw==,1217238,2015-07-19T03:01:36Z,2015-07-19T03:01:36Z,MEMBER,"> Re Python 3 compatibility with xray.DataArray(d_ylog, zip(('y', 'x'), (y, x))) it would be nice if the DataArray constructor accepted an iterable. Thoughts?
Agreed. Want to add a fix?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-122611548,https://api.github.com/repos/pydata/xarray/issues/466,122611548,MDEyOklzc3VlQ29tbWVudDEyMjYxMTU0OA==,5356122,2015-07-19T01:41:18Z,2015-07-19T01:41:18Z,MEMBER,"Thanks for all the feedback! I'll change the default colormap and look into the other things mentioned on Monday.
Re Python 3 compatibility with `xray.DataArray(d_ylog, zip(('y', 'x'), (y, x)))` it would be nice if the DataArray constructor accepted an iterable. Thoughts?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-122582764,https://api.github.com/repos/pydata/xarray/issues/466,122582764,MDEyOklzc3VlQ29tbWVudDEyMjU4Mjc2NA==,1217238,2015-07-18T19:18:24Z,2015-07-18T19:18:24Z,MEMBER,"Have you tried the ioos conda channel for cartopy? They do a really nice job maintaining builds.
On Sat, Jul 18, 2015 at 11:30 AM, Joe Hamman notifications@github.com
wrote:
> @clarkfitzg - I just spent some time running through your examples and trying to plot some of my own data. Overall - this is really slick and I really liked what you have going here. Below are a few comments I made along the way - take them or leave them.
> 1. Consider `yincrease=True` as the default. Maybe there is a downside to this but I don't see it. I'm pretty sure it is just the convention of `imshow`.
> 1. It may be worth mentioning why you are using `imshow` over `pcolormesh`. The limitation of `imshow` having regularly spaced coordinates will be important to some (myself included). We may, at some point, want to add an option for using `pcolormesh`. This would support irregular grids without forcing the use of `contourf`.
> 1. More examples with `cartopy` would be good. Maybe we can put together example page here: http://xray.readthedocs.org/en/latest/examples.html
>
> ## 1. I continue to have cartopy install problems on osx, even with python2.7 using anaconda. I also had problems on a clean docker image. I know this has nothing to do with this PR but the problems with installing cartopy will limit its applicability here.
>
> Reply to this email directly or view it on GitHub:
> https://github.com/xray/xray/pull/466#issuecomment-122576123
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-122576123,https://api.github.com/repos/pydata/xarray/issues/466,122576123,MDEyOklzc3VlQ29tbWVudDEyMjU3NjEyMw==,2443309,2015-07-18T18:30:16Z,2015-07-18T18:30:16Z,MEMBER,"@clarkfitzg - I just spent some time running through your examples and trying to plot some of my own data. Overall - this is really slick and I really liked what you have going here. Below are a few comments I made along the way - take them or leave them.
1. Consider `yincrease=True` as the default. Maybe there is a downside to this but I don't see it. I'm pretty sure it is just the convention of `imshow`.
2. It may be worth mentioning why you are using `imshow` over `pcolormesh`. The limitation of `imshow` having regularly spaced coordinates will be important to some (myself included). We may, at some point, want to add an option for using `pcolormesh`. This would support irregular grids without forcing the use of `contourf`.
3. More examples with `cartopy` would be good. Maybe we can put together example page here: http://xray.readthedocs.org/en/latest/examples.html
4. I continue to have cartopy install problems on osx, even with python2.7 using anaconda. I also had problems on a clean docker image. I know this has nothing to do with this PR but the problems with installing cartopy will limit its applicability here.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-122489008,https://api.github.com/repos/pydata/xarray/issues/466,122489008,MDEyOklzc3VlQ29tbWVudDEyMjQ4OTAwOA==,2443309,2015-07-18T06:02:59Z,2015-07-18T06:02:59Z,MEMBER,"yeah, +1 for the `viridis` colormap.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-122483377,https://api.github.com/repos/pydata/xarray/issues/466,122483377,MDEyOklzc3VlQ29tbWVudDEyMjQ4MzM3Nw==,1217238,2015-07-18T04:40:38Z,2015-07-18T04:40:38Z,MEMBER,"@jhamman I'd be happy to bundle viridis with xray as the default colormap (the source code is [here](https://github.com/BIDS/colormap/blob/master/option_d.py)) -- or we could just wait a few months, at which time it will be the matplotlib default.
@nbren12 Seaborn has some heuristics for picking sequential vs diverging colormaps. Possibly worth borrowing: https://github.com/mwaskom/seaborn/blob/v0.6.0/seaborn/matrix.py#L158
My inclination is to merge this on master and iterate in future PRs. There are still a few things to fix, but this is a great start.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-122483201,https://api.github.com/repos/pydata/xarray/issues/466,122483201,MDEyOklzc3VlQ29tbWVudDEyMjQ4MzIwMQ==,1386642,2015-07-18T04:34:00Z,2015-07-18T04:34:28Z,CONTRIBUTOR,"I agree that `jet` isn't a good color scheme (this scipy talk is really
good https://www.youtube.com/watch?v=xAoljeRJ3lU), but that is easily
changed by setting cmap='whatever'.
One colorbar issue I find consistently annoying is having to manually
specify `vmin` and `vmax` or `levels` when plotting anomaly fields on a
diverging colorbar with white in the middle. Some sort of
`symmetric_colorbar= ` kwarg would be really nice.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-122480887,https://api.github.com/repos/pydata/xarray/issues/466,122480887,MDEyOklzc3VlQ29tbWVudDEyMjQ4MDg4Nw==,2443309,2015-07-18T04:19:17Z,2015-07-18T04:19:17Z,MEMBER,"I'm going to get around to testing this out tomorrow. I just breezed through the docs and I have one comment. Can we not use `jet` as the default colormap? I know it is the default colormap in matplotlib but we aren't bound by that. There are dozens of sources out there explaining why `jet` is a bad choice. I'll give two of the ones that have popped out to me over the years:
- https://jakevdp.github.io/blog/2014/10/16/how-bad-is-your-colormap/
- http://web.stanford.edu/~mwaskom/software/seaborn/tutorial/color_palettes.html
There is also a lively Github issue over here: https://github.com/matplotlib/matplotlib/issues/875
I'll try to get a few more comments out tomorrow. So far, this work is really encouraging.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-122273892,https://api.github.com/repos/pydata/xarray/issues/466,122273892,MDEyOklzc3VlQ29tbWVudDEyMjI3Mzg5Mg==,5356122,2015-07-17T13:23:38Z,2015-07-17T13:23:38Z,MEMBER,"@shoyer I thought about it more and realized there's no need to return the axis since these functions just update the state. Taking your suggestion and returning whatever the matplotlib function returns in all cases now.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-121004893,https://api.github.com/repos/pydata/xarray/issues/466,121004893,MDEyOklzc3VlQ29tbWVudDEyMTAwNDg5Mw==,5356122,2015-07-13T17:52:02Z,2015-07-13T17:52:02Z,MEMBER,"Gridlines in built docs are distracting- take them out.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-120994910,https://api.github.com/repos/pydata/xarray/issues/466,120994910,MDEyOklzc3VlQ29tbWVudDEyMDk5NDkxMA==,5356122,2015-07-13T17:07:17Z,2015-07-13T17:07:17Z,MEMBER,"@nbren12 good tip- works now :)
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-120573324,https://api.github.com/repos/pydata/xarray/issues/466,120573324,MDEyOklzc3VlQ29tbWVudDEyMDU3MzMyNA==,1386642,2015-07-11T05:08:45Z,2015-07-11T05:08:45Z,CONTRIBUTOR,"For shared colorbars I would check out this [stackoverflow](http://stackoverflow.com/a/21304001) thread.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-120572985,https://api.github.com/repos/pydata/xarray/issues/466,120572985,MDEyOklzc3VlQ29tbWVudDEyMDU3Mjk4NQ==,1386642,2015-07-11T05:01:41Z,2015-07-11T05:03:07Z,CONTRIBUTOR,"Looks really nice! One suggestion I can think of would be to allow the imshow function to work with nonuniform coordinates. matplotlib provides a `NonUniformImage` class for these purposes. It's api is slightly more complicated than `plt.imshow`, but still not too bad. See this [example](http://matplotlib.org/examples/pylab_examples/image_nonuniform.html) .
On Sat, Jul 11, 2015 at 12:29 AM, Clark Fitzgerald wrote:
>
> cc @nbren12 https://github.com/nbren12, @jhamman
> https://github.com/jhamman feedback here is welcome, particularly on
> the API and docs (link is on top of page)
>
> —
> Reply to this email directly or view it on GitHub
> https://github.com/xray/xray/pull/466#issuecomment-120571809.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601
https://github.com/pydata/xarray/pull/466#issuecomment-120571809,https://api.github.com/repos/pydata/xarray/issues/466,120571809,MDEyOklzc3VlQ29tbWVudDEyMDU3MTgwOQ==,5356122,2015-07-11T04:29:42Z,2015-07-11T04:29:42Z,MEMBER,"cc @nbren12, @jhamman feedback here is welcome, particularly on the API and docs (link is on top of page)
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,94417601