html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5571#issuecomment-931724589,https://api.github.com/repos/pydata/xarray/issues/5571,931724589,IC_kwDOAMm_X843iP0t,35968931,2021-09-30T21:39:32Z,2021-09-30T21:39:32Z,MEMBER,The what's new entry for this went in under the wrong edition - I fixed it in https://github.com/pydata/xarray/commit/ebfc6a3db0580cc11418e906766805ff4bf36455,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,936313924
https://github.com/pydata/xarray/pull/5571#issuecomment-930405466,https://api.github.com/repos/pydata/xarray/issues/5571,930405466,IC_kwDOAMm_X843dNxa,35968931,2021-09-29T17:48:31Z,2021-09-29T17:48:31Z,MEMBER,Thanks for the reminder @dcherian - I merged main and all the tests pass so I'll merge this PR now!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,936313924
https://github.com/pydata/xarray/pull/5571#issuecomment-907489614,https://api.github.com/repos/pydata/xarray/issues/5571,907489614,IC_kwDOAMm_X842FzFO,35968931,2021-08-27T21:36:48Z,2021-08-27T21:36:48Z,MEMBER,Doctests passed! Thanks so much @Illviljan !,"{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,936313924
https://github.com/pydata/xarray/pull/5571#issuecomment-905973029,https://api.github.com/repos/pydata/xarray/issues/5571,905973029,IC_kwDOAMm_X842AA0l,35968931,2021-08-26T00:46:35Z,2021-08-26T00:46:35Z,MEMBER,"@Illviljan that actually solved those padding errors! Awesome!

The tests still fail because of something going on with `np.around` in the doctests though :confused: ","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,936313924
https://github.com/pydata/xarray/pull/5571#issuecomment-885213103,https://api.github.com/repos/pydata/xarray/issues/5571,885213103,IC_kwDOAMm_X840w0ev,35968931,2021-07-22T20:31:35Z,2021-07-22T20:31:35Z,MEMBER,"Now there is one more mystery: why do some of the tests for padding fail with output that is 0.5 away from what's expected??:

```
_____________ TestVariableWithDask.test_pad[xr_arg3-np_arg3-mean] ______________
[gw3] linux -- Python 3.7.10 /usr/share/miniconda/envs/xarray-tests/bin/python

self = <xarray.tests.test_variable.TestVariableWithDask object at 0x7f10bd848990>
mode = 'mean', xr_arg = {'x': (3, 1), 'z': (2, 0)}
np_arg = ((3, 1), (0, 0), (2, 0))

    @pytest.mark.parametrize(
        ""mode"",
        [
            ""mean"",
            pytest.param(
                ""median"",
                marks=pytest.mark.xfail(reason=""median is not implemented by Dask""),
            ),
            pytest.param(
                ""reflect"", marks=pytest.mark.xfail(reason=""dask.array.pad bug"")
            ),
            ""edge"",
            pytest.param(
                ""linear_ramp"",
                marks=pytest.mark.xfail(
                    reason=""pint bug: https://github.com/hgrecco/pint/issues/1026""
                ),
            ),
            ""maximum"",
            ""minimum"",
            ""symmetric"",
            ""wrap"",
        ],
    )
    @pytest.mark.parametrize(""xr_arg, np_arg"", _PAD_XR_NP_ARGS)
    @pytest.mark.filterwarnings(
        r""ignore:dask.array.pad.+? converts integers to floats.""
    )
    def test_pad(self, mode, xr_arg, np_arg):
        data = np.arange(4 * 3 * 2).reshape(4, 3, 2)
        v = self.cls([""x"", ""y"", ""z""], data)
    
        actual = v.pad(mode=mode, **xr_arg)
        expected = np.pad(data, np_arg, mode=mode)
   
>       assert_array_equal(actual, expected)
E       AssertionError: 
E       Arrays are not equal
E       
E       Mismatched elements: 48 / 96 (50%)
E       Max absolute difference: 0.5
E       Max relative difference: 0.25
E        x: array([[[ 9.5,  9.5,  9. , 10. ],
E               [11.5, 11.5, 11. , 12. ],
E               [13.5, 13.5, 13. , 14. ]],...
E        y: array([[[10, 10,  9, 10],
E               [12, 12, 11, 12],
E               [14, 14, 13, 14]],...
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,936313924
https://github.com/pydata/xarray/pull/5571#issuecomment-873468285,https://api.github.com/repos/pydata/xarray/issues/5571,873468285,MDEyOklzc3VlQ29tbWVudDg3MzQ2ODI4NQ==,35968931,2021-07-03T20:49:50Z,2021-07-03T20:49:50Z,MEMBER,A net-negative pull request :exploding_head: ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,936313924
https://github.com/pydata/xarray/pull/5571#issuecomment-873459181,https://api.github.com/repos/pydata/xarray/issues/5571,873459181,MDEyOklzc3VlQ29tbWVudDg3MzQ1OTE4MQ==,35968931,2021-07-03T19:31:44Z,2021-07-03T19:31:44Z,MEMBER,"Right I understand the failure now - everywhere where `_dask_or_eager_func` was dispatching numpy->dask is working fine via NEP-18, but my change made pandas.isnull no longer dispatch to dask.isnull, which then computes (and raises because we want it to be lazy). The solution is to special-case that one use of pandas (and perhaps any other uses of pandas?).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,936313924