html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/5564#issuecomment-881959762,https://api.github.com/repos/pydata/xarray/issues/5564,881959762,IC_kwDOAMm_X840kaNS,2448579,2021-07-17T21:04:54Z,2021-07-17T21:04:54Z,MEMBER,Looks great. Thanks @Joeperdefloep . I see this is your first contribution to xarray. Welcome!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935692190 https://github.com/pydata/xarray/pull/5564#issuecomment-872964795,https://api.github.com/repos/pydata/xarray/issues/5564,872964795,MDEyOklzc3VlQ29tbWVudDg3Mjk2NDc5NQ==,41898282,2021-07-02T12:35:32Z,2021-07-02T23:45:32Z,CONTRIBUTOR,"## Unit Test Results 6 files 6 suites 52m 19s :stopwatch: 16 163 tests 14 448 :heavy_check_mark: 1 715 :zzz: 0 :x: 90 174 runs 82 061 :heavy_check_mark: 8 113 :zzz: 0 :x: Results for commit fab8263d. :recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935692190 https://github.com/pydata/xarray/pull/5564#issuecomment-872947547,https://api.github.com/repos/pydata/xarray/issues/5564,872947547,MDEyOklzc3VlQ29tbWVudDg3Mjk0NzU0Nw==,14808389,2021-07-02T12:06:02Z,2021-07-02T12:06:02Z,MEMBER,"Good catch, @Joeperdefloep, this should be fixed by decorating the test with `requires_scipy`. Could you make that change?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935692190 https://github.com/pydata/xarray/pull/5564#issuecomment-872938084,https://api.github.com/repos/pydata/xarray/issues/5564,872938084,MDEyOklzc3VlQ29tbWVudDg3MjkzODA4NA==,33122845,2021-07-02T11:48:07Z,2021-07-02T11:54:57Z,CONTRIBUTOR,"Also there is an issue when: ```fish cd xarray pip install -e . pip install h5netcdf pytest-xdist netcdf4 py.test -n 2 xarray/tests/test_backends.py ``` ```python ======================================================== FAILURES ========================================================= ________________________________________ TestH5NetCDFFileObject.test_open_fileobj _________________________________________ [gw2] linux -- Python 3.9.5 /home/joeperdefloep/miniconda3/envs/xr-dev/bin/python3.9 self = <xarray.tests.test_backends.TestH5NetCDFFileObject object at 0x7f7e841a4220> def test_open_fileobj(self): # open in-memory datasets instead of local file paths expected = create_test_data().drop_vars(""dim3"") expected.attrs[""foo""] = ""bar"" with create_tmp_file() as tmp_file: expected.to_netcdf(tmp_file, engine=""h5netcdf"") with open(tmp_file, ""rb"") as f: with open_dataset(f, engine=""h5netcdf"") as actual: assert_identical(expected, actual) f.seek(0) with open_dataset(f) as actual: assert_identical(expected, actual) f.seek(0) with BytesIO(f.read()) as bio: with open_dataset(bio, engine=""h5netcdf"") as actual: assert_identical(expected, actual) f.seek(0) with pytest.raises(TypeError, match=""not a valid NetCDF 3""): > open_dataset(f, engine=""scipy"") /mnt/e/Git/xarray/xarray/tests/test_backends.py:2887: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ /mnt/e/Git/xarray/xarray/backends/api.py:483: in open_dataset backend = plugins.get_backend(engine) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ engine = 'scipy' def get_backend(engine): """"""Select open_dataset method based on current engine."""""" if isinstance(engine, str): engines = list_engines() if engine not in engines: > raise ValueError( f""unrecognized engine {engine} must be one of: {list(engines)}"" ) E ValueError: unrecognized engine scipy must be one of: ['netcdf4', 'h5netcdf', 'store'] /mnt/e/Git/xarray/xarray/backends/plugins.py:156: ValueError ================================================= short test summary info ================================================= FAILED xarray/tests/test_backends.py::TestH5NetCDFFileObject::test_open_fileobj - ValueError: unrecognized engine scipy ... =========================== 1 failed, 458 passed, 818 skipped, 18 xfailed, 6 xpassed in 25.08s =========================== ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935692190