html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/5560#issuecomment-897697868,https://api.github.com/repos/pydata/xarray/issues/5560,897697868,IC_kwDOAMm_X841gchM,2448579,2021-08-12T14:41:30Z,2021-08-12T14:41:30Z,MEMBER,Thanks @keewis. We can extend the tests for rolling later.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935279688 https://github.com/pydata/xarray/pull/5560#issuecomment-884366726,https://api.github.com/repos/pydata/xarray/issues/5560,884366726,IC_kwDOAMm_X840tl2G,2448579,2021-07-21T17:35:36Z,2021-07-21T17:35:36Z,MEMBER,"> so disabling bottleneck would fail the function. Should we just silently use bottleneck, or raise an error? Ah this is a good test! ``` python with xr.set_options(use_bottleneck=False): with pytest.raises(...): dataarray.ffill() ``` IMO it should raise an error so that `use_bottleneck` is a ""global"" control on whether xarray uses bottleneck or not. The context manager gives the user some flexibility to opt-in to using bottleneck where they want to.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935279688 https://github.com/pydata/xarray/pull/5560#issuecomment-872623510,https://api.github.com/repos/pydata/xarray/issues/5560,872623510,MDEyOklzc3VlQ29tbWVudDg3MjYyMzUxMA==,2448579,2021-07-02T00:09:36Z,2021-07-02T00:09:51Z,MEMBER,"We use it in other places too (for e.g.): https://github.com/pydata/xarray/blob/c472f8a4c79f872edb9dcd7825f786ecb9aff5c0/xarray/core/nputils.py#L139-L147 > xr.set_options(accelerate_with=""bottleneck"") I like this idea but we should wait for more input.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935279688