html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5560#issuecomment-872616814,https://api.github.com/repos/pydata/xarray/issues/5560,872616814,MDEyOklzc3VlQ29tbWVudDg3MjYxNjgxNA==,41898282,2021-07-01T23:49:55Z,2021-08-12T15:05:48Z,CONTRIBUTOR,"## Unit Test Results
         6 files  ±0           6 suites  ±0   57m 2s :stopwatch: ±0s
16 217 tests ±0  14 483 :heavy_check_mark: ±0  1 734 :zzz: ±0  0 :x: ±0 
90 498 runs  ±0  82 324 :heavy_check_mark: ±0  8 174 :zzz: ±0  0 :x: ±0 

Results for commit 3956b73a. ± Comparison against base commit 3956b73a.

:recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935279688
https://github.com/pydata/xarray/pull/5560#issuecomment-897697868,https://api.github.com/repos/pydata/xarray/issues/5560,897697868,IC_kwDOAMm_X841gchM,2448579,2021-08-12T14:41:30Z,2021-08-12T14:41:30Z,MEMBER,Thanks @keewis. We can extend the tests for rolling later.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935279688
https://github.com/pydata/xarray/pull/5560#issuecomment-897161325,https://api.github.com/repos/pydata/xarray/issues/5560,897161325,IC_kwDOAMm_X841eZht,14808389,2021-08-11T21:18:05Z,2021-08-11T21:18:18Z,MEMBER,"I'm not sure how to test rolling: monkeypatching `bottleneck.move_sum` does not work because `Rolling` only accesses that on import, i.e. before the test is executed.

Everything else ~is~ should be done, though.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935279688
https://github.com/pydata/xarray/pull/5560#issuecomment-884366726,https://api.github.com/repos/pydata/xarray/issues/5560,884366726,IC_kwDOAMm_X840tl2G,2448579,2021-07-21T17:35:36Z,2021-07-21T17:35:36Z,MEMBER,"> so disabling bottleneck would fail the function. Should we just silently use bottleneck, or raise an error?

Ah this is a good test!

``` python
with xr.set_options(use_bottleneck=False):
	with pytest.raises(...):
		dataarray.ffill()
```

IMO it should raise an error so that `use_bottleneck` is a ""global"" control on whether xarray uses bottleneck or not. The context manager gives the user some flexibility to opt-in to using bottleneck where they want to.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935279688
https://github.com/pydata/xarray/pull/5560#issuecomment-884359642,https://api.github.com/repos/pydata/xarray/issues/5560,884359642,IC_kwDOAMm_X840tkHa,14808389,2021-07-21T17:23:45Z,2021-07-21T17:30:26Z,MEMBER,"as discussed in the meeting, we will keep `use_bottleneck` for now. I still don't know how to test this, but otherwise this should be ready for reviews and merging.

Edit: we also don't have alternatives for functions like `duck_array_ops.push` (used in `ffill` etc.) so disabling `bottleneck` would fail the function. Should we just silently use `bottleneck`, or raise an error?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935279688
https://github.com/pydata/xarray/pull/5560#issuecomment-872627259,https://api.github.com/repos/pydata/xarray/issues/5560,872627259,MDEyOklzc3VlQ29tbWVudDg3MjYyNzI1OQ==,5635139,2021-07-02T00:20:32Z,2021-07-02T00:20:32Z,MEMBER,"Nice!

pandas [uses](https://pandas.pydata.org/docs/reference/api/pandas.set_option.html) `use_bottleneck` — and same for numba / numexpr.

To what extent would bottleneck & numba be mutually exclusive? Until everything is implemented in numbagg, I guess they won't be, and we might want separate options. Having a single option would be nicer otherwise.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935279688
https://github.com/pydata/xarray/pull/5560#issuecomment-872623510,https://api.github.com/repos/pydata/xarray/issues/5560,872623510,MDEyOklzc3VlQ29tbWVudDg3MjYyMzUxMA==,2448579,2021-07-02T00:09:36Z,2021-07-02T00:09:51Z,MEMBER,"We use it in other places too (for e.g.): https://github.com/pydata/xarray/blob/c472f8a4c79f872edb9dcd7825f786ecb9aff5c0/xarray/core/nputils.py#L139-L147

> xr.set_options(accelerate_with=""bottleneck"")

I like this idea but we should wait for more input.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,935279688