html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5542#issuecomment-886422293,https://api.github.com/repos/pydata/xarray/issues/5542,886422293,IC_kwDOAMm_X8401bsV,5635139,2021-07-26T06:41:38Z,2021-07-26T06:41:38Z,MEMBER,"It's curious that's slow — it's not a deep copy and so should be fast (in python terms!), since it's just copying the class instance.
Totally understand re ASV — and more generally you should choose the most meaningful work for you. I hope you continue to become more involved with the project, and there'll be plenty of time to expand into other areas.
(though down a level, we should have some way of justifying the merge — let me know if you have any profiles to hand, no rush)
Thanks as ever @Illviljan !","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,931016490
https://github.com/pydata/xarray/pull/5542#issuecomment-886253326,https://api.github.com/repos/pydata/xarray/issues/5542,886253326,IC_kwDOAMm_X8400ycO,5635139,2021-07-25T20:25:15Z,2021-07-25T21:19:01Z,MEMBER,"~Yeah, I guess if someone does `x = y.transpose()` and then `x[0] = 42`, then `y` would be inconsistently updated. Don't think we're likely to get copy-on-write semantics soon!~
~So maybe this is the best we can hope for.~
Edit: actually is this already implemented? https://github.com/pydata/xarray/blob/main/xarray/core/variable.py#L1441-L1444. Does interpolate not hit this code path?
Is it worth adding an ASV? I've found them fairly quick to set up a new one, though takes some lift to set up the environment etc. I think in general we should try and have them for performance work, so we can track if it regresses.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,931016490
https://github.com/pydata/xarray/pull/5542#issuecomment-886242665,https://api.github.com/repos/pydata/xarray/issues/5542,886242665,IC_kwDOAMm_X8400v1p,5635139,2021-07-25T18:50:46Z,2021-07-25T18:50:46Z,MEMBER,"Sorry this didn't get @Illviljan .
It looks good, without me having that much context. Do you have any info on whether this has any performance impact?
I imagine this isn't as easy as it sounds, but do you have a view on whether we could apply this concept more broadly, and make transposing 1D arrays a no-op in the transpose method, rather than writing that logic for each method that calls `.transpose`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,931016490