html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5542#issuecomment-886450425,https://api.github.com/repos/pydata/xarray/issues/5542,886450425,IC_kwDOAMm_X8401ij5,14371165,2021-07-26T07:28:58Z,2021-07-26T07:33:57Z,MEMBER,"It probably is decently fast but it can't compare to just not running the `.copy()` code if a copy isn't necessary. :) But this isn't a major bottleneck either:
Before, the transpose is one of the largest bottlenecks in `missing.interp` where the `.copy()` is what takes time. `missing.interp` took 1.33s to run.
After, the transpose obviously isn't a factor anymore since it isn't triggered. `missing.interp` took 1.24s to run.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,931016490
https://github.com/pydata/xarray/pull/5542#issuecomment-886261206,https://api.github.com/repos/pydata/xarray/issues/5542,886261206,IC_kwDOAMm_X84000XW,14371165,2021-07-25T21:38:49Z,2021-07-25T21:38:49Z,MEMBER,"> Edit: actually is this already implemented? https://github.com/pydata/xarray/blob/main/xarray/core/variable.py#L1441-L1444. Does interpolate not hit this code path?
Yes, that's the copy that's slow and there's no real need to create a new copy in the 1D case. My (bad) idea was to just return the original array there instead, but as you noted that might not be fully intuitive.
A ASV for 1D- and ND-interpolation and having it running in the CI would be nice.
Though I'm not really interested in implementing that, It would be just another thing to document for me because I use other profilers anyway and as you said getting it setup requires some work that I don't enjoy.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,931016490
https://github.com/pydata/xarray/pull/5542#issuecomment-886247722,https://api.github.com/repos/pydata/xarray/issues/5542,886247722,IC_kwDOAMm_X8400xEq,14371165,2021-07-25T19:36:12Z,2021-07-25T19:36:12Z,MEMBER,Yes this improves the interp performance a bit. The .copy in the transpose is rather slow so it seems better to just not do it. An alternative is removing the .copy in the transpose or make it an option?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,931016490
https://github.com/pydata/xarray/pull/5542#issuecomment-869223054,https://api.github.com/repos/pydata/xarray/issues/5542,869223054,MDEyOklzc3VlQ29tbWVudDg2OTIyMzA1NA==,14371165,2021-06-27T21:00:55Z,2021-06-27T21:01:17Z,MEMBER,It's just a simple copy/paste job at the moment. I welcome suggestions for a more elegant solution.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,931016490