html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/5501#issuecomment-1484207722,https://api.github.com/repos/pydata/xarray/issues/5501,1484207722,IC_kwDOAMm_X85YdzZq,2448579,2023-03-26T20:04:32Z,2023-03-26T20:04:32Z,MEMBER,We're about to remove the built-in rasterio backend in favour of rioxarray. Sorry for not merging this earlier @agrouaze,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,925533850 https://github.com/pydata/xarray/pull/5501#issuecomment-905752519,https://api.github.com/repos/pydata/xarray/issues/5501,905752519,IC_kwDOAMm_X841_K_H,14808389,2021-08-25T17:58:20Z,2021-08-25T17:58:50Z,MEMBER,can you try if your test (without the other changes) fails with `rasterio=1.2.3` and passes with `rasterio>=1.2.4` (I think that's the first version that includes the commit you referenced)?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,925533850 https://github.com/pydata/xarray/pull/5501#issuecomment-905580429,https://api.github.com/repos/pydata/xarray/issues/5501,905580429,IC_kwDOAMm_X841-g-N,41898282,2021-08-25T14:58:21Z,2021-08-25T14:58:21Z,CONTRIBUTOR,"## Unit Test Results          6 files           6 suites   51m 22s :stopwatch: 16 226 tests 14 490 :heavy_check_mark: 1 736 :zzz: 0 :x: 90 552 runs  82 368 :heavy_check_mark: 8 184 :zzz: 0 :x: Results for commit 674d9b69. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,925533850 https://github.com/pydata/xarray/pull/5501#issuecomment-905555330,https://api.github.com/repos/pydata/xarray/issues/5501,905555330,IC_kwDOAMm_X841-a2C,14925067,2021-08-25T14:34:07Z,2021-08-25T14:35:27Z,NONE,"I added a test in `test_backends.py` : `pytest -s ./test_backends.py::TestRasterio::test_rasterio_complex_dtype` But since there is a coming fix in `rasterio` I am wondering whether this PR is still needed: https://github.com/mapbox/rasterio/commit/7114fb7fb5e48146c4f04eb818daaa1fa632d817 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,925533850 https://github.com/pydata/xarray/pull/5501#issuecomment-864508390,https://api.github.com/repos/pydata/xarray/issues/5501,864508390,MDEyOklzc3VlQ29tbWVudDg2NDUwODM5MA==,24736507,2021-06-20T06:49:57Z,2021-08-25T14:30:57Z,NONE,"Hello @grouny! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found: * In the file [`xarray/tests/test_backends.py`](https://github.com/pydata/xarray/blob/674d9b69fc7cd99c63c8d10764fd900442ec3be2/xarray/tests/test_backends.py): > [Line 4171:42](https://github.com/pydata/xarray/blob/674d9b69fc7cd99c63c8d10764fd900442ec3be2/xarray/tests/test_backends.py#L4171): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ',' > [Line 4705:37](https://github.com/pydata/xarray/blob/674d9b69fc7cd99c63c8d10764fd900442ec3be2/xarray/tests/test_backends.py#L4705): [E201](https://duckduckgo.com/?q=pep8%20E201) whitespace after '(' > [Line 4705:42](https://github.com/pydata/xarray/blob/674d9b69fc7cd99c63c8d10764fd900442ec3be2/xarray/tests/test_backends.py#L4705): [E202](https://duckduckgo.com/?q=pep8%20E202) whitespace before ')' > [Line 4710:39](https://github.com/pydata/xarray/blob/674d9b69fc7cd99c63c8d10764fd900442ec3be2/xarray/tests/test_backends.py#L4710): [E225](https://duckduckgo.com/?q=pep8%20E225) missing whitespace around operator > [Line 4712:35](https://github.com/pydata/xarray/blob/674d9b69fc7cd99c63c8d10764fd900442ec3be2/xarray/tests/test_backends.py#L4712): [E225](https://duckduckgo.com/?q=pep8%20E225) missing whitespace around operator > [Line 4714:1](https://github.com/pydata/xarray/blob/674d9b69fc7cd99c63c8d10764fd900442ec3be2/xarray/tests/test_backends.py#L4714): [E302](https://duckduckgo.com/?q=pep8%20E302) expected 2 blank lines, found 1 ##### Comment last updated at 2021-08-25 14:30:57 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,925533850 https://github.com/pydata/xarray/pull/5501#issuecomment-892776854,https://api.github.com/repos/pydata/xarray/issues/5501,892776854,IC_kwDOAMm_X841NrGW,5635139,2021-08-04T15:57:35Z,2021-08-04T15:57:35Z,MEMBER,"As discussed in the dev meeting, this would be great to merge. The test could be to create a small file, and then read it. Would that work @grouny ? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,925533850 https://github.com/pydata/xarray/pull/5501#issuecomment-867787488,https://api.github.com/repos/pydata/xarray/issues/5501,867787488,MDEyOklzc3VlQ29tbWVudDg2Nzc4NzQ4OA==,8699967,2021-06-24T16:34:50Z,2021-06-24T16:34:50Z,CONTRIBUTOR,Also see: https://github.com/corteva/rioxarray/pull/359,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,925533850 https://github.com/pydata/xarray/pull/5501#issuecomment-867569524,https://api.github.com/repos/pydata/xarray/issues/5501,867569524,MDEyOklzc3VlQ29tbWVudDg2NzU2OTUyNA==,14925067,2021-06-24T11:42:56Z,2021-06-24T11:43:13Z,NONE,Yes I can think about a test. Could this test be a simple .tiff file opening or is it too high level?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,925533850 https://github.com/pydata/xarray/pull/5501#issuecomment-867083353,https://api.github.com/repos/pydata/xarray/issues/5501,867083353,MDEyOklzc3VlQ29tbWVudDg2NzA4MzM1Mw==,2443309,2021-06-23T18:58:58Z,2021-06-23T18:58:58Z,MEMBER,"@grouny - thanks for this PR! And I see that this is your first time contributing to Xarray -- Welcome! This fix you propose looks great. Apart from the linter complaining about some whitespace, I think this would benefit from a simple test. Would you mind adding a test to `xarray/tests/test_backends.py`? Q for @snowman2 - is rioxarray handling complex datatypes in this way?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,925533850