html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5365#issuecomment-1001266238,https://api.github.com/repos/pydata/xarray/issues/5365,1001266238,IC_kwDOAMm_X847rhw-,14371165,2021-12-27T00:41:08Z,2021-12-27T00:41:08Z,MEMBER,I'm will merge this in a couple of days if no one minds.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-939500878,https://api.github.com/repos/pydata/xarray/issues/5365,939500878,IC_kwDOAMm_X843_6VO,14371165,2021-10-10T15:20:46Z,2021-10-10T15:20:46Z,MEMBER,@keewis this is ready for another review if you're up for it.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-938108353,https://api.github.com/repos/pydata/xarray/issues/5365,938108353,IC_kwDOAMm_X8436mXB,14371165,2021-10-07T19:54:17Z,2021-10-07T19:54:17Z,MEMBER,"@max-sixty Had to use `Union[DataArray, Variable]` instead of `Union[T_DataArray, T_Variable]` from `types.py`. Apparently you can't narrow down the typing using `isinstance` if you use `T_DataArray = TypeVar(""T_DataArray"", bound=""DataArray"")`.
Not sure why, I'm just accepting it at this point.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-934822108,https://api.github.com/repos/pydata/xarray/issues/5365,934822108,IC_kwDOAMm_X843uEDc,14371165,2021-10-05T20:56:44Z,2021-10-05T20:56:44Z,MEMBER,"Typing errors:
```
xarray/core/computation.py:1525: error: Item ""Sequence[Sequence[Sequence[Sequence[Sequence[Any]]]]]"" of ""Union[DataArray, Variable, DataArrayGroupBy, Union[Union[Sequence[Sequence[Sequence[Sequence[Sequence[Any]]]]], Union[Union[_SupportsArray[dtype[Any]], Sequence[_SupportsArray[dtype[Any]]], Sequence[Sequence[_SupportsArray[dtype[Any]]]], Sequence[Sequence[Sequence[_SupportsArray[dtype[Any]]]]], Sequence[Sequence[Sequence[Sequence[_SupportsArray[dtype[Any]]]]]]], Union[bool, int, float, complex, str, bytes, Sequence[Union[bool, int, float, complex, str, bytes]], Sequence[Sequence[Union[bool, int, float, complex, str, bytes]]], Sequence[Sequence[Sequence[Union[bool, int, float, complex, str, bytes]]]], Sequence[Sequence[Sequence[Sequence[Union[bool, int, float, complex, str, bytes]]]]]]]], generic, ndarray[Any, Any], Any]]"" has no attribute ""dims"" [union-attr]
xarray/core/computation.py:1525: error: Item ""_SupportsArray[dtype[Any]]"" of ""Union[DataArray, Variable, DataArrayGroupBy, Union[Union[Sequence[Sequence[Sequence[Sequence[Sequence[Any]]]]], Union[Union[_SupportsArray[dtype[Any]], Sequence[_SupportsArray[dtype[Any]]], Sequence[Sequence[_SupportsArray[dtype[Any]]]], Sequence[Sequence[Sequence[_SupportsArray[dtype[Any]]]]], Sequence[Sequence[Sequence[Sequence[_SupportsArray[dtype[Any]]]]]]], Union[bool, int, float, complex, str, bytes, Sequence[Union[bool, int, float, complex, str, bytes]], Sequence[Sequence[Union[bool, int, float, complex, str, bytes]]], Sequence[Sequence[Sequence[Union[bool, int, float, complex, str, bytes]]]], Sequence[Sequence[Sequence[Sequence[Union[bool, int, float, complex, str, bytes]]]]]]]], generic, ndarray[Any, Any], Any]]"" has no attribute ""dims"" [union-attr]
xarray/core/computation.py:1525: error: Item ""Sequence[_SupportsArray[dtype[Any]]]"" of ""Union[DataArray, Variable, DataArrayGroupBy, Union[Union[Sequence[Sequence[Sequence[Sequence[Sequence[Any]]]]], Union[Union[_SupportsArray[dtype[Any]], Sequence[_SupportsArray[dtype[Any]]], Sequence[Sequence[_SupportsArray[dtype[Any]]]], Sequence[Sequence[Sequence[_SupportsArray[dtype[Any]]]]], Sequence[Sequence[Sequence[Sequence[_SupportsArray[dtype[Any]]]]]]], Union[bool, int, float, complex, str, bytes, Sequence[Union[bool, int, float, complex, str, bytes]], Sequence[Sequence[Union[bool, int, float, complex, str, bytes]]], Sequence[Sequence[Sequence[Union[bool, int, float, complex, str, bytes]]]], Sequence[Sequence[Sequence[Sequence[Union[bool, int, float, complex, str, bytes]]]]]]]], generic, ndarray[Any, Any], Any]]"" has no attribute ""dims"" [union-attr]
```
I think it's due to the `ScalarOrArray` type in `DaCompatible`. Not sure what part is supposed to be compatible though.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-908751381,https://api.github.com/repos/pydata/xarray/issues/5365,908751381,IC_kwDOAMm_X842KnIV,14371165,2021-08-30T22:35:38Z,2021-08-30T22:35:38Z,MEMBER,"@keewis, I've removed the ds support. Please check the example if it looks like you thought with .`to_array`, .`to_dataset`. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-887033677,https://api.github.com/repos/pydata/xarray/issues/5365,887033677,IC_kwDOAMm_X8403w9N,14371165,2021-07-26T21:17:42Z,2021-07-26T21:34:19Z,MEMBER,"This however doesn't work as expected:
```python
ds = xr.Dataset({""x"": (""t"", [0, 1]), ""y"": (""t"", [2, 3]), ""z"": (""t"", [4, 5])})
arr = xr.DataArray(data=[0, 2, 4], dims=""cartesian"", coords={""cartesian"": [""x"", ""y"", ""z""]})
xr.cross(ds, arr, dim=""cartesian"") # result: DataArray, should've been Dataset
```
Seems an easy fix fortunately.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-886800215,https://api.github.com/repos/pydata/xarray/issues/5365,886800215,IC_kwDOAMm_X840239X,14371165,2021-07-26T15:24:12Z,2021-07-26T15:24:12Z,MEMBER,Hmm mightve found a bug there. Could you show the examples? my idea was that if there's any dataset as input the output should always be dataset. I think apply_ufunc or some other function has the prio order ds > da > var.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-867907192,https://api.github.com/repos/pydata/xarray/issues/5365,867907192,MDEyOklzc3VlQ29tbWVudDg2NzkwNzE5Mg==,14371165,2021-06-24T19:48:16Z,2021-06-24T19:48:16Z,MEMBER,Green colors. :) I think this is finished now unless someone has any other thoughts.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-864596645,https://api.github.com/repos/pydata/xarray/issues/5365,864596645,MDEyOklzc3VlQ29tbWVudDg2NDU5NjY0NQ==,14371165,2021-06-20T18:52:16Z,2021-06-20T18:52:16Z,MEMBER,"Integers don't work with Numbers:
```
xarray/core/computation.py:1576: error: Dict entry 0 has incompatible type ""Hashable"": ""int""; expected ""Hashable"": ""Union[None, Number, str, Tuple[Number, ...]]"" [dict-item]
xarray/core/computation.py:1576: error: Dict entry 0 has incompatible type ""Hashable"": ""int""; expected ""Hashable"": ""Union[None, Number, Tuple[Number, ...]]"" [dict-item]
xarray/core/computation.py:1536: error: Dict entry 0 has incompatible type ""Hashable"": ""int""; expected ""Hashable"": ""Union[None, Number, str, Tuple[Number, ...]]"" [dict-item]
```
Floats don't work with Numbers:
```
xarray/core/computation.py:1536: error: Dict entry 0 has incompatible type ""Hashable"": ""int""; expected ""Hashable"": ""Union[None, Number, str, Tuple[Number, ...]]"" [dict-item]
xarray/core/computation.py:1578: error: Dict entry 0 has incompatible type ""Hashable"": ""float""; expected ""Hashable"": ""Union[None, Number, str, Tuple[Number, ...]]"" [dict-item]
xarray/core/computation.py:1578: error: Dict entry 0 has incompatible type ""Hashable"": ""float""; expected ""Hashable"": ""Union[None, Number, Tuple[Number, ...]]"" [dict-item]
```
This seems related to: https://github.com/python/mypy/issues/3186
I do wonder why we allow any type of numbers in the chunks? When does it ever make sense to input 1.5 or a complex number?
https://github.com/pydata/xarray/blob/28d3349bbe8c9881448bba45785c1013b006d6f9/xarray/core/dataarray.py#L1041
It will always be forced to integers anyway:
https://github.com/dask/dask/blob/8aea537d925b794a94f828d35211a5da05ad9dce/dask/array/core.py#L2815
So why not force integers to begin with?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-864523157,https://api.github.com/repos/pydata/xarray/issues/5365,864523157,MDEyOklzc3VlQ29tbWVudDg2NDUyMzE1Nw==,14371165,2021-06-20T09:08:31Z,2021-06-20T09:08:31Z,MEMBER,"
> `getattr(array_large, ""coords"", False)` will always pass for DataArrays — even if there are no coords, it's checking whether there's a coords method on the class — which in the case of a DataArray with no coords, would return empty (but still return). Or am I misunderstanding?
Empty coords is False as well, that's the trick here:
```python
a = xr.DataArray([1, 2])
if getattr(a, ""coords"", False):
print(""hey"")
b = xr.DataArray([1, 2], coords=[[0, 1]])
if getattr(b, ""coords"", False):
print(""hey"")
hey
```","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-864448064,https://api.github.com/repos/pydata/xarray/issues/5365,864448064,MDEyOklzc3VlQ29tbWVudDg2NDQ0ODA2NA==,14371165,2021-06-19T18:42:18Z,2021-06-19T18:42:18Z,MEMBER,"mypy doesn't understand `hasattr(array_large, ""reindex_like"") `apparently:
`xarray/core/computation.py:1572: error: ""Variable"" has no attribute ""reindex_like"" [attr-defined]`
Rather surprising that it's this difficult to make mypy happy. The code seems pretty straightforward to me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-864446250,https://api.github.com/repos/pydata/xarray/issues/5365,864446250,MDEyOklzc3VlQ29tbWVudDg2NDQ0NjI1MA==,14371165,2021-06-19T18:27:23Z,2021-06-19T18:27:23Z,MEMBER,">
>
> > It's true that Variable doesn't have it. But a Variable can't use that code path since we check `getattr(array_large, ""coords"", False)`.
>
> Ah, then we can tell mypy this, I think just by switching to `isinstance(array_large, Variable)`
>
> (and in case it wasn't clear, it's also OK to skip some of these or leave them to another PR. They can be useful checks for things we miss, but we shouldn't be beholden to the linting)
The check can't be that simple though because DataArrays doesn't always include `coords` and then it doesn't make sense to use `reindex_like`. I suppose adding a `hasattr(array_large, ""reindex_like"")` is an option, but it feels redundant to me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-864397184,https://api.github.com/repos/pydata/xarray/issues/5365,864397184,MDEyOklzc3VlQ29tbWVudDg2NDM5NzE4NA==,14371165,2021-06-19T12:02:19Z,2021-06-19T12:02:19Z,MEMBER,"> ```
> xarray/core/computation.py:1570: error: ""Variable"" has no attribute ""reindex_like"" [attr-defined]
> ```
>
> Is this legit — does it work with Variables?
It's true that Variable doesn't have it. But a Variable can't use that code path since we check `getattr(array_large, ""coords"", False)`.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-864187643,https://api.github.com/repos/pydata/xarray/issues/5365,864187643,MDEyOklzc3VlQ29tbWVudDg2NDE4NzY0Mw==,14371165,2021-06-18T17:43:13Z,2021-06-18T17:43:13Z,MEMBER,"@max-sixty, any ideas how to fix these mypy errors?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-855409555,https://api.github.com/repos/pydata/xarray/issues/5365,855409555,MDEyOklzc3VlQ29tbWVudDg1NTQwOTU1NQ==,14371165,2021-06-06T14:36:53Z,2021-06-06T14:36:53Z,MEMBER,"@keewis, @max-sixty I think this ready now.
I don't get why my local version managed to pass without having to rechunk the datasets though but it's in the past now.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-855395533,https://api.github.com/repos/pydata/xarray/issues/5365,855395533,MDEyOklzc3VlQ29tbWVudDg1NTM5NTUzMw==,14371165,2021-06-06T13:00:06Z,2021-06-06T13:52:46Z,MEMBER,"Well, look at that. Updating to latest I get the error as well.
```
astroid 2.5.6-py38haa244fe_0 --> 2.5.7-py38haa244fe_0
ca-certificates 2020.12.5-h5b45459_0 --> 2021.5.30-h5b45459_0
certifi 2020.12.5-py38haa244fe_1 --> 2021.5.30-py38haa244fe_0
curl 7.76.1-h789b8ee_2 --> 7.77.0-h789b8ee_0
dask 2021.5.0-pyhd8ed1ab_0 --> 2021.6.0-pyhd8ed1ab_0
dask-core 2021.5.0-pyhd8ed1ab_0 --> 2021.6.0-pyhd8ed1ab_0
distributed 2021.5.0-py38haa244fe_0 --> 2021.6.0-py38haa244fe_0
docutils 0.16-py38haa244fe_3 --> 0.17.1-py38haa244fe_0
importlib-metadata 4.0.1-py38haa244fe_0 --> 4.5.0-py38haa244fe_0
importlib_metadata 4.0.1-hd8ed1ab_0 --> 4.5.0-hd8ed1ab_0
ipython 7.23.1-py38h43734a8_0 --> 7.24.1-py38h43734a8_0
jupyterlab_server 2.5.2-pyhd8ed1ab_0 --> 2.6.0-pyhd8ed1ab_0
libcurl 7.76.1-h789b8ee_2 --> 7.77.0-h789b8ee_0
liblief 0.11.4-h0e60522_0 --> 0.11.5-h0e60522_0
nbclassic 0.2.8-pyhd8ed1ab_0 --> 0.3.1-pyhd8ed1ab_1
networkx 2.5-py_0 --> 2.5.1-pyhd8ed1ab_0
pandoc 2.13-h8ffe710_0 --> 2.14.0.1-h8ffe710_0
prometheus_client 0.10.1-pyhd8ed1ab_0 --> 0.11.0-pyhd8ed1ab_0
py-lief 0.11.4-py38h885f38d_0 --> 0.11.5-py38h885f38d_0
pyerfa 1.7.3-py38h294d835_0 --> 1.7.3-py38hcb5f9af_1
python-libarchive~ 2.9-py38haa244fe_2 --> 3.1-py38haa244fe_0
pyzmq 22.0.3-py38h09162b1_1 --> 22.1.0-py38h09162b1_0
rope 0.18.0-pyhd3deb0d_0 --> 0.19.0-pyhd8ed1ab_0
sphinx 4.0.0-pyh6c4a22f_0 --> 4.0.2-pyh6c4a22f_1
sqlalchemy 1.4.15-py38h294d835_0 --> 1.4.17-py38h294d835_0
tqdm 4.60.0-pyhd8ed1ab_0 --> 4.61.0-pyhd8ed1ab_0
typing_extensions 3.7.4.3-py_0 --> 3.10.0.0-pyha770c72_0
urllib3 1.26.4-pyhd8ed1ab_0 --> 1.26.5-pyhd8ed1ab_0
xarray 0.18.0-pyhd8ed1ab_0 --> 0.18.2-pyhd8ed1ab_0
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876
https://github.com/pydata/xarray/pull/5365#issuecomment-855391730,https://api.github.com/repos/pydata/xarray/issues/5365,855391730,MDEyOklzc3VlQ29tbWVudDg1NTM5MTczMA==,14371165,2021-06-06T12:31:38Z,2021-06-06T12:31:38Z,MEMBER,"The errors with `test_vectorize_dask_dtype_meta` are unrelated to my changes and mentioned in #5366 as well.
Can't replicate the cross errors on my local versions though, maybe the root cause is the same?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,899015876