html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5345#issuecomment-863419727,https://api.github.com/repos/pydata/xarray/issues/5345,863419727,MDEyOklzc3VlQ29tbWVudDg2MzQxOTcyNw==,2448579,2021-06-17T17:18:20Z,2021-06-17T17:18:20Z,MEMBER,Thanks @Illviljan !,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,895713502
https://github.com/pydata/xarray/pull/5345#issuecomment-860086402,https://api.github.com/repos/pydata/xarray/issues/5345,860086402,MDEyOklzc3VlQ29tbWVudDg2MDA4NjQwMg==,5635139,2021-06-12T17:47:24Z,2021-06-12T17:47:24Z,MEMBER,"@shoyer if you get a moment, could you take a glance at this and see if it looks OK, or we should add more tests?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,895713502
https://github.com/pydata/xarray/pull/5345#issuecomment-846113331,https://api.github.com/repos/pydata/xarray/issues/5345,846113331,MDEyOklzc3VlQ29tbWVudDg0NjExMzMzMQ==,5635139,2021-05-21T17:14:34Z,2021-05-21T17:14:34Z,MEMBER,"Yes, pytest can be a bit confusing at first, but it's a really nice framework — `da` comes from https://github.com/pydata/xarray/blob/v0.18.2/xarray/tests/test_dataarray.py#L6458, which is parametrized with both a numpy-backed and a dask-backed array, so it creates two tests.

I agree this seems like it should be fine, and maybe I'm being a bit too cautious. @keewis could you give this a check given my track-record is blotchy now, and we can merge if you agree?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,895713502
https://github.com/pydata/xarray/pull/5345#issuecomment-846078946,https://api.github.com/repos/pydata/xarray/issues/5345,846078946,MDEyOklzc3VlQ29tbWVudDg0NjA3ODk0Ng==,14371165,2021-05-21T16:21:35Z,2021-05-21T16:21:35Z,MEMBER,"> 
> 
> It's probably worth double-checking that the more complex Variable `__getitem__` methods are also tested on Dask arrays. We could you an approach like #5350 if we're not confident.
 
I don't understand how this works, @max-sixty. You're adding the variable `da` to the method but where does `da` then later come from? It doesn't seem to be defined in this file?

The numpy implementation seems very similar to the npcompat version:
https://github.com/numpy/numpy/blob/fb215c76967739268de71aa4bda55dd1b062bc2e/numpy/core/numeric.py#L1405

Maybe the npcompat code was copy/pasted just to avoid waiting on numpy releases?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,895713502
https://github.com/pydata/xarray/pull/5345#issuecomment-845461228,https://api.github.com/repos/pydata/xarray/issues/5345,845461228,MDEyOklzc3VlQ29tbWVudDg0NTQ2MTIyOA==,5635139,2021-05-20T20:39:25Z,2021-05-20T20:39:25Z,MEMBER,It's probably worth double-checking that the more complex Variable `__getitem__` methods are also tested on Dask arrays. We could you an approach like https://github.com/pydata/xarray/pull/5350 if we're not confident.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,895713502
https://github.com/pydata/xarray/pull/5345#issuecomment-845403040,https://api.github.com/repos/pydata/xarray/issues/5345,845403040,MDEyOklzc3VlQ29tbWVudDg0NTQwMzA0MA==,24736507,2021-05-20T19:08:27Z,2021-05-20T20:31:33Z,NONE,"Hello @Illviljan! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:







There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-05-20 20:31:33 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,895713502