html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5285#issuecomment-843176731,https://api.github.com/repos/pydata/xarray/issues/5285,843176731,MDEyOklzc3VlQ29tbWVudDg0MzE3NjczMQ==,15079414,2021-05-18T13:34:43Z,2021-05-18T13:34:43Z,CONTRIBUTOR,@dcherian @keewis any comments/suggestions on the currently unresolved comments? Or is this good to go?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,883153591
https://github.com/pydata/xarray/pull/5285#issuecomment-840732698,https://api.github.com/repos/pydata/xarray/issues/5285,840732698,MDEyOklzc3VlQ29tbWVudDg0MDczMjY5OA==,5635139,2021-05-13T18:03:55Z,2021-05-13T18:03:55Z,MEMBER,"> > Can we avoid the signature changes, seems like it creates more trouble than it solves.
> 
> I can put the positional `ax` args back for now, but I do think it would be better not to have in the signature, since it makes it look like you have to provide `ax`. The `_plot2d` deals with this by modifying the signature to hide it, but `_dsplot` doesn't. I do think it is unlikely that many users were using `ax` positionally, especially since this is never done in the examples, but it is certainly possible.
> 
> The positional `u`, `v` in `dataset_plot.scatter` were not used so I think that change is ok?

I agree many of these could be cleaned up. They do probably need a deprecation cycle though — i.e. checking for the previous args, warning if they're supplied, and then only later removing them.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,883153591
https://github.com/pydata/xarray/pull/5285#issuecomment-840707224,https://api.github.com/repos/pydata/xarray/issues/5285,840707224,MDEyOklzc3VlQ29tbWVudDg0MDcwNzIyNA==,2448579,2021-05-13T17:20:22Z,2021-05-13T17:20:22Z,MEMBER,"> The positional u, v in dataset_plot.scatter were not used so I think that change is ok?

Sounds good to me. I wish I'd thought of this when implementing quiver :)","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,883153591
https://github.com/pydata/xarray/pull/5285#issuecomment-840705544,https://api.github.com/repos/pydata/xarray/issues/5285,840705544,MDEyOklzc3VlQ29tbWVudDg0MDcwNTU0NA==,15079414,2021-05-13T17:17:35Z,2021-05-13T17:17:35Z,CONTRIBUTOR,"> Can we avoid the signature changes, seems like it creates more trouble than it solves.

I can put the positional `ax` args back for now, but I do think it would be better not to have in the signature, since it makes it look like you have to provide `ax`. The `_plot2d` deals with this by modifying the signature to hide it, but `_dsplot` doesn't. I do think it is unlikely that many users were using `ax` positionally, especially since this is never done in the examples, but it is certainly possible.

The positional `u`, `v` in `dataset_plot.scatter` were not used so I think that change is ok?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,883153591
https://github.com/pydata/xarray/pull/5285#issuecomment-840644935,https://api.github.com/repos/pydata/xarray/issues/5285,840644935,MDEyOklzc3VlQ29tbWVudDg0MDY0NDkzNQ==,15079414,2021-05-13T15:37:57Z,2021-05-13T15:37:57Z,CONTRIBUTOR,"The RTD is failing with 
```
Sphinx parallel build error:
nbsphinx.NotebookError: UndefinedError in examples/ERA5-GRIB-example.ipynb:
'nbformat.notebooknode.NotebookNode object' has no attribute 'tags'
```
Doesn't seem like it would be related to this PR, but it was passing before...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,883153591
https://github.com/pydata/xarray/pull/5285#issuecomment-840534009,https://api.github.com/repos/pydata/xarray/issues/5285,840534009,MDEyOklzc3VlQ29tbWVudDg0MDUzNDAwOQ==,15079414,2021-05-13T12:51:16Z,2021-05-13T12:51:16Z,CONTRIBUTOR,"Thanks @mathause for the review.

> Looks good overall. There are two things I am unsure about:
> 
> 1. You change the signature of `ds.plot.scatter` etc.. I think that's a worthwhile change but it needs a deprecation cycle - unless I am missing something? I'd suggest not doing that here but in a new PR. (I am also not entirely sure how to best do it...).

Yes, I suppose it would break it for anyone who was using `ax` positionally, but I am pretty sure no xarray docs examples do this, and I feel that the precedent from pandas, etc. is that `ax` is a kwarg.

> 2. I see the `matplotlib:` part of some of the references for the first time  (e.g. `` py:meth:`matplotlib:matplotlib.figure.Figure.add_subplot\`  ``) - this is used very inconsistently (already before). I am not sure what's correct.

It works both ways (I've been building locally to check things), but I can certainly add in the `matplotlib:`s if you would like. I suppose that makes it more clear that it is an external name, not part of xarray.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,883153591