html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/5232#issuecomment-833871917,https://api.github.com/repos/pydata/xarray/issues/5232,833871917,MDEyOklzc3VlQ29tbWVudDgzMzg3MTkxNw==,1217238,2021-05-06T21:15:02Z,2021-05-06T21:15:02Z,MEMBER,"Thanks everyone, great work!
On Thu, May 6, 2021 at 1:06 PM Deepak Cherian ***@***.***>
wrote:
> Nice work, @TomNicholas
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or
> unsubscribe
>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833824638,https://api.github.com/repos/pydata/xarray/issues/5232,833824638,MDEyOklzc3VlQ29tbWVudDgzMzgyNDYzOA==,2448579,2021-05-06T20:06:03Z,2021-05-06T20:06:03Z,MEMBER,"Nice work, @TomNicholas ","{""total_count"": 4, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 4, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833815937,https://api.github.com/repos/pydata/xarray/issues/5232,833815937,MDEyOklzc3VlQ29tbWVudDgzMzgxNTkzNw==,35968931,2021-05-06T19:51:54Z,2021-05-06T19:51:54Z,MEMBER,I updated the release guide in #5274 by the way.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833799272,https://api.github.com/repos/pydata/xarray/issues/5232,833799272,MDEyOklzc3VlQ29tbWVudDgzMzc5OTI3Mg==,35968931,2021-05-06T19:25:51Z,2021-05-06T19:25:51Z,MEMBER,"My email got bounced from pyaos@lists.johnny-lin.com because I'm not a member, but otherwise I think this is done. (I'm also not subscribed to numpy-discussion@scipy.org or scipy-user@scipy.org so maybe it's about to get bounced from there too).","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833792726,https://api.github.com/repos/pydata/xarray/issues/5232,833792726,MDEyOklzc3VlQ29tbWVudDgzMzc5MjcyNg==,226037,2021-05-06T19:14:44Z,2021-05-06T19:14:44Z,MEMBER,@TomNicholas feel free to close the issue once you are done.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833791756,https://api.github.com/repos/pydata/xarray/issues/5232,833791756,MDEyOklzc3VlQ29tbWVudDgzMzc5MTc1Ng==,226037,2021-05-06T19:13:20Z,2021-05-06T19:13:20Z,MEMBER,"`12899 passed, 1145 skipped, 211 xfailed, 63 xpassed, 321 warnings` on my Mac.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833787927,https://api.github.com/repos/pydata/xarray/issues/5232,833787927,MDEyOklzc3VlQ29tbWVudDgzMzc4NzkyNw==,35968931,2021-05-06T19:07:23Z,2021-05-06T19:07:23Z,MEMBER,"Okay that should be everything except emailing the mailing lists, which I will try now","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833782283,https://api.github.com/repos/pydata/xarray/issues/5232,833782283,MDEyOklzc3VlQ29tbWVudDgzMzc4MjI4Mw==,13301940,2021-05-06T18:59:01Z,2021-05-06T18:59:01Z,MEMBER,"> maybe we should make the ""upload to TestPyPI"" a separate step?
Or we could just set
```yaml
skip_existing: true
```
on the upload to TestPyPI step. ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833781911,https://api.github.com/repos/pydata/xarray/issues/5232,833781911,MDEyOklzc3VlQ29tbWVudDgzMzc4MTkxMQ==,226037,2021-05-06T18:58:28Z,2021-05-06T18:58:28Z,MEMBER,"> How many xarray devs does it take to do a release? Answer: at least 5 apparently
🤦
But next time it will be sooooooo smooth!","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833781236,https://api.github.com/repos/pydata/xarray/issues/5232,833781236,MDEyOklzc3VlQ29tbWVudDgzMzc4MTIzNg==,35968931,2021-05-06T18:57:31Z,2021-05-06T18:57:31Z,MEMBER,How many xarray devs does it take to do a release? Answer: at least 5 apparently,"{""total_count"": 5, ""+1"": 0, ""-1"": 0, ""laugh"": 5, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833780734,https://api.github.com/repos/pydata/xarray/issues/5232,833780734,MDEyOklzc3VlQ29tbWVudDgzMzc4MDczNA==,35968931,2021-05-06T18:56:47Z,2021-05-06T18:56:47Z,MEMBER,Alright I'll carry on with the other steps then I guess? :sweat_smile:,"{""total_count"": 3, ""+1"": 3, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833779348,https://api.github.com/repos/pydata/xarray/issues/5232,833779348,MDEyOklzc3VlQ29tbWVudDgzMzc3OTM0OA==,14808389,2021-05-06T18:54:39Z,2021-05-06T18:56:22Z,MEMBER,"ah, right, only the ""push tag"" workflow run failed","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833779947,https://api.github.com/repos/pydata/xarray/issues/5232,833779947,MDEyOklzc3VlQ29tbWVudDgzMzc3OTk0Nw==,226037,2021-05-06T18:55:33Z,2021-05-06T18:55:33Z,MEMBER,I'm testing after `pip install -U xarray` just to be on the safe side 😄 ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833778762,https://api.github.com/repos/pydata/xarray/issues/5232,833778762,MDEyOklzc3VlQ29tbWVudDgzMzc3ODc2Mg==,2448579,2021-05-06T18:53:45Z,2021-05-06T18:53:45Z,MEMBER,"Yup, nice work everyone!
https://pypi.org/project/xarray/","{""total_count"": 4, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 3, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833778499,https://api.github.com/repos/pydata/xarray/issues/5232,833778499,MDEyOklzc3VlQ29tbWVudDgzMzc3ODQ5OQ==,35968931,2021-05-06T18:53:22Z,2021-05-06T18:53:22Z,MEMBER,Looks like it did push to PyPI this time though? https://github.com/pydata/xarray/runs/2521179293?check_suite_focus=true,"{""total_count"": 2, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 1, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833777214,https://api.github.com/repos/pydata/xarray/issues/5232,833777214,MDEyOklzc3VlQ29tbWVudDgzMzc3NzIxNA==,35968931,2021-05-06T18:51:34Z,2021-05-06T18:51:34Z,MEMBER,"oh - I just deleted both and then re-released just now, but v0.18.0 again...","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833777039,https://api.github.com/repos/pydata/xarray/issues/5232,833777039,MDEyOklzc3VlQ29tbWVudDgzMzc3NzAzOQ==,14808389,2021-05-06T18:51:30Z,2021-05-06T18:51:30Z,MEMBER,"maybe we should make the ""upload to TestPyPI"" a separate step?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833776140,https://api.github.com/repos/pydata/xarray/issues/5232,833776140,MDEyOklzc3VlQ29tbWVudDgzMzc3NjE0MA==,14808389,2021-05-06T18:51:04Z,2021-05-06T18:51:04Z,MEMBER,"errr... we can't do anything about that, PyPI and TestPyPI don't allow republishing the same version","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833774532,https://api.github.com/repos/pydata/xarray/issues/5232,833774532,MDEyOklzc3VlQ29tbWVudDgzMzc3NDUzMg==,13301940,2021-05-06T18:50:11Z,2021-05-06T18:50:46Z,MEMBER,"@keewis, do we need to do anything with the release on test.pypi.org? (since the v0.18 is already published there)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833773673,https://api.github.com/repos/pydata/xarray/issues/5232,833773673,MDEyOklzc3VlQ29tbWVudDgzMzc3MzY3Mw==,14808389,2021-05-06T18:49:44Z,2021-05-06T18:50:22Z,MEMBER,"yes, please. The command to create the tag should be
```
# empty commit unless you update the release date there
git commit --empty -am 'Release v0.18.0'
git tag -a v0.18.0 -m 'v0.18.0'
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833773183,https://api.github.com/repos/pydata/xarray/issues/5232,833773183,MDEyOklzc3VlQ29tbWVudDgzMzc3MzE4Mw==,226037,2021-05-06T18:49:12Z,2021-05-06T18:49:12Z,MEMBER,"> hmm should I also delete the tag? It appears to be also linked to one of @keewis ' PRs (#5272)
yes, sorry: delete release AND tag. Then re-create release.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833772828,https://api.github.com/repos/pydata/xarray/issues/5232,833772828,MDEyOklzc3VlQ29tbWVudDgzMzc3MjgyOA==,13301940,2021-05-06T18:48:41Z,2021-05-06T18:48:41Z,MEMBER,"> hmm should I also delete the tag?
Yes...
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833770927,https://api.github.com/repos/pydata/xarray/issues/5232,833770927,MDEyOklzc3VlQ29tbWVudDgzMzc3MDkyNw==,35968931,2021-05-06T18:45:54Z,2021-05-06T18:45:54Z,MEMBER,hmm should I also delete the tag? It appears to be also linked to one of @keewis ' PRs (#5272),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833768930,https://api.github.com/repos/pydata/xarray/issues/5232,833768930,MDEyOklzc3VlQ29tbWVudDgzMzc2ODkzMA==,13301940,2021-05-06T18:43:04Z,2021-05-06T18:43:04Z,MEMBER,I accidentally closed this via Github's keywords... The bug in the CI workflow should be fixed. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833768013,https://api.github.com/repos/pydata/xarray/issues/5232,833768013,MDEyOklzc3VlQ29tbWVudDgzMzc2ODAxMw==,35968931,2021-05-06T18:41:44Z,2021-05-06T18:41:44Z,MEMBER,Okay let me try that then,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833765097,https://api.github.com/repos/pydata/xarray/issues/5232,833765097,MDEyOklzc3VlQ29tbWVudDgzMzc2NTA5Nw==,226037,2021-05-06T18:37:18Z,2021-05-06T18:37:18Z,MEMBER,Deleting and re-creating the release should work (I've done it on one of my projects),"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833760159,https://api.github.com/repos/pydata/xarray/issues/5232,833760159,MDEyOklzc3VlQ29tbWVudDgzMzc2MDE1OQ==,35968931,2021-05-06T18:29:36Z,2021-05-06T18:29:36Z,MEMBER,Or @andersy005 suggested deleting the last tag and re-making it? Happy to try either (after the meeting I'm lurking in is done),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833756760,https://api.github.com/repos/pydata/xarray/issues/5232,833756760,MDEyOklzc3VlQ29tbWVudDgzMzc1Njc2MA==,2448579,2021-05-06T18:24:55Z,2021-05-06T18:24:55Z,MEMBER,@TomNicholas Sounds good to me; just edit whats-new again.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833755470,https://api.github.com/repos/pydata/xarray/issues/5232,833755470,MDEyOklzc3VlQ29tbWVudDgzMzc1NTQ3MA==,35968931,2021-05-06T18:23:07Z,2021-05-06T18:23:07Z,MEMBER,"If we merge that PR and then I/someone clicks ""New Release"" again (and presumably calls it `v0.18.1`?) then that should just trigger the GitHub action again?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833753256,https://api.github.com/repos/pydata/xarray/issues/5232,833753256,MDEyOklzc3VlQ29tbWVudDgzMzc1MzI1Ng==,13301940,2021-05-06T18:19:41Z,2021-05-06T18:19:41Z,MEMBER,"Never mind... There's a bug in this `if`
https://github.com/pydata/xarray/blob/01c1d25578634306b5d3179989a0a9bd867de176/.github/workflows/pypi-release.yaml#L84
It should be `github.ref` instead of `github.event.ref`... Opening a PR shortly (not sure if you still want to use the GitHub action)... ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833751992,https://api.github.com/repos/pydata/xarray/issues/5232,833751992,MDEyOklzc3VlQ29tbWVudDgzMzc1MTk5Mg==,226037,2021-05-06T18:17:47Z,2021-05-06T18:17:47Z,MEMBER,"> I guess I can't do this because I'm no one of the registered package owners on PyPI?
Nope. The maintainers on PyPI are Deepak, Joe, Max and Stephan.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833750245,https://api.github.com/repos/pydata/xarray/issues/5232,833750245,MDEyOklzc3VlQ29tbWVudDgzMzc1MDI0NQ==,35968931,2021-05-06T18:15:07Z,2021-05-06T18:15:07Z,MEMBER,"> I think the easiest is for you to upload the artefacts using with twine.
I guess I can't do this because I'm no one of the registered package owners on PyPI?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833748655,https://api.github.com/repos/pydata/xarray/issues/5232,833748655,MDEyOklzc3VlQ29tbWVudDgzMzc0ODY1NQ==,226037,2021-05-06T18:12:40Z,2021-05-06T18:13:23Z,MEMBER,@dcherian I'm back. I think the easiest is for you to upload the artefacts using with twine. If you need any help I'm in the zoom room.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833741743,https://api.github.com/repos/pydata/xarray/issues/5232,833741743,MDEyOklzc3VlQ29tbWVudDgzMzc0MTc0Mw==,13301940,2021-05-06T18:03:01Z,2021-05-06T18:03:13Z,MEMBER,"> Hmm... Looks like it built but didn't upload: [pydata/xarray/runs/2520588073?check_suite_focus=true](https://github.com/pydata/xarray/runs/2520588073?check_suite_focus=true)
>
> cc @keewis @andersy005
Sorry about that. I think the culprit here are the `if` conditions which evaluate to `false` on release events... @keewis what do you think? :)
https://github.com/pydata/xarray/blob/01c1d25578634306b5d3179989a0a9bd867de176/.github/workflows/pypi-release.yaml#L66
https://github.com/pydata/xarray/blob/01c1d25578634306b5d3179989a0a9bd867de176/.github/workflows/pypi-release.yaml#L75","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833729171,https://api.github.com/repos/pydata/xarray/issues/5232,833729171,MDEyOklzc3VlQ29tbWVudDgzMzcyOTE3MQ==,2448579,2021-05-06T17:44:59Z,2021-05-06T17:44:59Z,MEMBER,"Hmm... Looks like it built but didn't upload: https://github.com/pydata/xarray/runs/2520588073?check_suite_focus=true
cc @keewis @andersy005 ","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 1, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833682044,https://api.github.com/repos/pydata/xarray/issues/5232,833682044,MDEyOklzc3VlQ29tbWVudDgzMzY4MjA0NA==,14808389,2021-05-06T16:51:28Z,2021-05-06T16:51:28Z,MEMBER,"not sure how far you got with the release, but it would be good to get #5272 in before that.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833672891,https://api.github.com/repos/pydata/xarray/issues/5232,833672891,MDEyOklzc3VlQ29tbWVudDgzMzY3Mjg5MQ==,2448579,2021-05-06T16:38:12Z,2021-05-06T16:38:12Z,MEMBER,OK I think we can go ahead. 3 people is pretty overkill for the release process :P The token has been added and I'm in the Zoom room @TomNicholas ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833652183,https://api.github.com/repos/pydata/xarray/issues/5232,833652183,MDEyOklzc3VlQ29tbWVudDgzMzY1MjE4Mw==,226037,2021-05-06T16:15:06Z,2021-05-06T16:15:06Z,MEMBER,"@dcherian I'm sorry, I have cannot make it by 12:30 EST. I think you and @TomNicholas can go on without me or I will be back later.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833651866,https://api.github.com/repos/pydata/xarray/issues/5232,833651866,MDEyOklzc3VlQ29tbWVudDgzMzY1MTg2Ng==,14808389,2021-05-06T16:14:44Z,2021-05-06T16:14:44Z,MEMBER,"uploading to TestPyPI works so uploading to PyPI *should* work, too, once we have the token","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833603212,https://api.github.com/repos/pydata/xarray/issues/5232,833603212,MDEyOklzc3VlQ29tbWVudDgzMzYwMzIxMg==,226037,2021-05-06T15:13:13Z,2021-05-06T16:13:50Z,MEMBER,"@dcherian 11:30-12:30 EST I'm meeting with Stephan and Joe, I hope to have them merge #5235 :)
~12:30 EST is fine by me.~ I cannot make it :/","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833648432,https://api.github.com/repos/pydata/xarray/issues/5232,833648432,MDEyOklzc3VlQ29tbWVudDgzMzY0ODQzMg==,2448579,2021-05-06T16:11:03Z,2021-05-06T16:11:03Z,MEMBER,I don't have permissions to generate a PyPI token... I think either @jhamman or @shoyer need to do that.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833610586,https://api.github.com/repos/pydata/xarray/issues/5232,833610586,MDEyOklzc3VlQ29tbWVudDgzMzYxMDU4Ng==,14808389,2021-05-06T15:22:57Z,2021-05-06T15:23:29Z,MEMBER,"#5235 shouldn't be that much of an issue. There are two decisions to check: never collapse the `repr` of `MemoryCachedArray` and keep the array used to check that small (we have a limit of `1e5`, after which the `repr` changes from `array([...])` to `[xyz values with dtype=...]`)
Edit: essentially: I don't want to merge it myself","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833599803,https://api.github.com/repos/pydata/xarray/issues/5232,833599803,MDEyOklzc3VlQ29tbWVudDgzMzU5OTgwMw==,2448579,2021-05-06T15:09:10Z,2021-05-06T15:09:10Z,MEMBER,"We're still waiting on #5235.
Let's do 12.30 Eastern at https://columbiauniversity.zoom.us/j/953527251 ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833564314,https://api.github.com/repos/pydata/xarray/issues/5232,833564314,MDEyOklzc3VlQ29tbWVudDgzMzU2NDMxNA==,226037,2021-05-06T14:22:55Z,2021-05-06T14:25:12Z,MEMBER,"@TomNicholas I'm in Europe, with a meeting at 17:30-18:30 CEST (11:30-12:30 EST) we can probably start now-ish and finish after 3pm EST. I propose to hijack the community meeting zoom :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833554579,https://api.github.com/repos/pydata/xarray/issues/5232,833554579,MDEyOklzc3VlQ29tbWVudDgzMzU1NDU3OQ==,35968931,2021-05-06T14:10:18Z,2021-05-06T14:10:18Z,MEMBER,@alexamici yes sure - I'm free anytime today except for 2-3pm EST.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-833539672,https://api.github.com/repos/pydata/xarray/issues/5232,833539672,MDEyOklzc3VlQ29tbWVudDgzMzUzOTY3Mg==,226037,2021-05-06T13:50:28Z,2021-05-06T13:50:28Z,MEMBER,"@TomNicholas & @dcherian I'm having a look at the what's new, shall we set a time for going through the release process? do we want do the steps while in a call?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-832588071,https://api.github.com/repos/pydata/xarray/issues/5232,832588071,MDEyOklzc3VlQ29tbWVudDgzMjU4ODA3MQ==,14808389,2021-05-05T10:37:49Z,2021-05-05T10:40:47Z,MEMBER,"I think that's because nobody had that idea, yet.
Edit: that would also help with the idea in https://github.com/pydata/xarray/pull/5244#issuecomment-831511929. Let's continue that discussion in #5244","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 1, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-832448319,https://api.github.com/repos/pydata/xarray/issues/5232,832448319,MDEyOklzc3VlQ29tbWVudDgzMjQ0ODMxOQ==,226037,2021-05-05T06:35:02Z,2021-05-05T10:38:35Z,MEMBER,"Form what I can see the #5258 ""bump versions"" looks ready, someone with knowledge about minimum versions please merge it.
After that is in, @dcherian you can probably uncomment the `var._meta` bit in #4740 ""faster interp"" and we can merge it as well. Again I'm not a user of that part of code, and I would feel more conformable if someone with more knowledge would click on the ""merge"" button.
This leaves only #5235 as a blocker that has a failing test, a proposed fix by @keewis. ~but the OP hasn't responded yet. How should we handle it?~ This looks ready to merge now. Sorry @tomwhite I read the timestamps wrong. Great job!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-832579692,https://api.github.com/repos/pydata/xarray/issues/5232,832579692,MDEyOklzc3VlQ29tbWVudDgzMjU3OTY5Mg==,5821660,2021-05-05T10:22:07Z,2021-05-05T10:22:07Z,MEMBER,"> we could also temporarily switch the uploads to `test.pypi.org`
Why not always upload pushes to master to `test.pypi.org`?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-832563855,https://api.github.com/repos/pydata/xarray/issues/5232,832563855,MDEyOklzc3VlQ29tbWVudDgzMjU2Mzg1NQ==,14808389,2021-05-05T09:56:42Z,2021-05-05T09:56:42Z,MEMBER,"we could also temporarily switch the uploads to `test.pypi.org` to verify, create debug versions (rc candidates?) and switch back to `pypi.org` once we're confident","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-832452876,https://api.github.com/repos/pydata/xarray/issues/5232,832452876,MDEyOklzc3VlQ29tbWVudDgzMjQ1Mjg3Ng==,226037,2021-05-05T06:44:59Z,2021-05-05T06:46:36Z,MEMBER,"Any thoughts on merging #5244 and doing the v0.18.0 release via GitHub Actions?
I'm using GA in a couple of repositories and I find them very handy, but I usually had to make a couple of releases before getting all the details right, which looks awkward to do with a high profile project like *xarray*.
We could try release one or more release candidates and go for `v0.18.0` only after we are sure the GA release procedure is working though.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-831956692,https://api.github.com/repos/pydata/xarray/issues/5232,831956692,MDEyOklzc3VlQ29tbWVudDgzMTk1NjY5Mg==,2448579,2021-05-04T13:49:10Z,2021-05-04T13:49:10Z,MEMBER,It'd be nice to bump our minimum dependency versions if someone has the time.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-831362303,https://api.github.com/repos/pydata/xarray/issues/5232,831362303,MDEyOklzc3VlQ29tbWVudDgzMTM2MjMwMw==,14808389,2021-05-03T16:03:33Z,2021-05-03T16:03:33Z,MEMBER,"great, you're a maintainer now (for `pint-xarray`, too, btw)","{""total_count"": 2, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 2, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-831358909,https://api.github.com/repos/pydata/xarray/issues/5232,831358909,MDEyOklzc3VlQ29tbWVudDgzMTM1ODkwOQ==,35968931,2021-05-03T15:58:12Z,2021-05-03T15:58:12Z,MEMBER,(@dcherian I've signed up on RTD now),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-830254596,https://api.github.com/repos/pydata/xarray/issues/5232,830254596,MDEyOklzc3VlQ29tbWVudDgzMDI1NDU5Ng==,221526,2021-04-30T17:42:09Z,2021-04-30T17:42:09Z,CONTRIBUTOR,"> We can avoid this by using the pypi github action thing to automatically build and upload when tagging a release on github. It uses a repo-level secret. Just a thought.
$0.02 from an outsider is that this has served us exceedingly well on MetPy. Our release process has become:
1. Close milestone
2. Adjust the auto-generated draft GitHub release (summary notes)
3. Click ""publish release"" -> packages uploaded to PyPI
4. Merge conda-forge update from their bots
It's almost *more* secure this way because the token from PyPI only has upload permissions--no need to store someone's password.","{""total_count"": 3, ""+1"": 3, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-830242266,https://api.github.com/repos/pydata/xarray/issues/5232,830242266,MDEyOklzc3VlQ29tbWVudDgzMDI0MjI2Ng==,2448579,2021-04-30T17:20:24Z,2021-04-30T17:21:53Z,MEMBER,"> IIRC they'll need to be added to the PyPI list
We can avoid this by using the pypi github action thing to automatically build and upload when tagging a release on github. It uses a repo-level secret. Just a thought.
> and RTD list.
I added @alexamici . @TomNicholas you need to sign up on RTD before I can add you there as a maintainer","{""total_count"": 3, ""+1"": 3, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-830236664,https://api.github.com/repos/pydata/xarray/issues/5232,830236664,MDEyOklzc3VlQ29tbWVudDgzMDIzNjY2NA==,5635139,2021-04-30T17:10:21Z,2021-04-30T17:10:21Z,MEMBER,"I think @alexamici 's plan is reasonable. I've had less of a process — no freeze etc — and that's worked fine — we do have a good test suite, and I've been really trying to make the release process a normal thing anyone can do in an hour.
But it's your call (and there's not much practical difference).
Thanks again!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-830073537,https://api.github.com/repos/pydata/xarray/issues/5232,830073537,MDEyOklzc3VlQ29tbWVudDgzMDA3MzUzNw==,35968931,2021-04-30T12:52:31Z,2021-04-30T12:52:31Z,MEMBER,"@alexamici I think you tagged the wrong Tom, but yes that works for me.","{""total_count"": 2, ""+1"": 0, ""-1"": 0, ""laugh"": 2, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-829923818,https://api.github.com/repos/pydata/xarray/issues/5232,829923818,MDEyOklzc3VlQ29tbWVudDgyOTkyMzgxOA==,226037,2021-04-30T08:10:37Z,2021-04-30T08:10:51Z,MEMBER,"I propose the following timeline that is the fastest I can personally try:
- Monday May the 3rd, feature freeze, please refrain from merging new features unless they are discussed here
- during feature freeze everybody please help reviewing the PR in the list above
- Thursday the 6th, target release day, the best would be to schedule a window for a couple of hours (?) for @TomAugspurger and me to going through the release steps together with @dcherian.
@TomAugspurger and others does it work for you all?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042
https://github.com/pydata/xarray/issues/5232#issuecomment-829845029,https://api.github.com/repos/pydata/xarray/issues/5232,829845029,MDEyOklzc3VlQ29tbWVudDgyOTg0NTAyOQ==,14371165,2021-04-30T05:18:14Z,2021-04-30T05:18:14Z,MEMBER,"May I suggest #4740, the only thing this needs I think is a rebase. I recently got a new computer and was reminded how slow the interpolation is without these changes.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,870292042